From e4aead23659ac10e219bacf974bcf47bb34a9a62 Mon Sep 17 00:00:00 2001 From: Abdullah Tahiri Date: Sat, 9 Feb 2019 19:35:40 +0100 Subject: [PATCH] Geometry extensions: remove unnecessary smart pointer deletion ============================================================== When the geometry object is destroyed, std::vector's destructor is called, which in turn calls the destructor of the smart pointers. If a weak_ptr corresponding to one of those shared_ptr is locked (elsewhere, if FC were multithread), the underlaying resource will not be freed until said locked weak_ptr goes out of scope. It will then. --- src/Mod/Part/App/Geometry.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Mod/Part/App/Geometry.cpp b/src/Mod/Part/App/Geometry.cpp index 02730bef08..e6c96ceae9 100644 --- a/src/Mod/Part/App/Geometry.cpp +++ b/src/Mod/Part/App/Geometry.cpp @@ -192,8 +192,7 @@ Geometry::Geometry() Geometry::~Geometry() { - for(std::vector>::iterator it = extensions.begin(); it != extensions.end(); it++) - (*it).reset(); + } // Persistence implementer