Remove magic number and hard type enums in ArrowPropEnum.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
This commit is contained in:
Benjamin Bræstrup Sayoc
2025-02-02 22:21:44 +01:00
parent 9aef91b3ca
commit e60c800a0b
19 changed files with 80 additions and 69 deletions

View File

@@ -166,7 +166,7 @@ void DlgPrefsTechDrawAnnotationImp::loadSettings()
ui->pcbBalloonArrow->onRestore();
DrawGuiUtil::loadArrowBox(ui->pcbBalloonArrow);
ui->pcbBalloonArrow->setCurrentIndex(prefBalloonArrow());
ui->pcbBalloonArrow->setCurrentIndex(static_cast<int>(prefBalloonArrow()));
ui->cbEndCap->onRestore();
@@ -207,7 +207,7 @@ void DlgPrefsTechDrawAnnotationImp::changeEvent(QEvent *e)
}
}
int DlgPrefsTechDrawAnnotationImp::prefBalloonArrow() const
TechDraw::ArrowType DlgPrefsTechDrawAnnotationImp::prefBalloonArrow() const
{
return Preferences::balloonArrow();
}