From e77f181393b93ba72bce3704771b7f3d0d70b684 Mon Sep 17 00:00:00 2001 From: Syres916 <46537884+Syres916@users.noreply.github.com> Date: Sat, 27 Sep 2025 06:33:57 +0100 Subject: [PATCH] [Part] Fix Part Boolean operations Refine incorrectly set for new users (#24256) * [Part] Fix Part Boolean operations Refine incorrectly set for new users * [Part] update tests to specify Refine to be... ...false where necessary --- src/Mod/Part/App/FeaturePartBoolean.cpp | 2 +- tests/src/Mod/Part/App/FeatureChamfer.cpp | 1 + tests/src/Mod/Part/App/FeatureFillet.cpp | 1 + tests/src/Mod/Part/App/FeatureMirroring.cpp | 1 + tests/src/Mod/Part/App/FeaturePartFuse.cpp | 2 +- tests/src/Mod/Part/App/PartFeatures.cpp | 1 + tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp | 1 + 7 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Mod/Part/App/FeaturePartBoolean.cpp b/src/Mod/Part/App/FeaturePartBoolean.cpp index 5e2c2a51e2..0eec69550b 100644 --- a/src/Mod/Part/App/FeaturePartBoolean.cpp +++ b/src/Mod/Part/App/FeaturePartBoolean.cpp @@ -61,7 +61,7 @@ bool getRefineModelParameter() { Base::Reference hGrp = App::GetApplication().GetUserParameter() .GetGroup("BaseApp")->GetGroup("Preferences")->GetGroup("Mod/Part/Boolean"); - return hGrp->GetBool("RefineModel", false); + return hGrp->GetBool("RefineModel", true); } } diff --git a/tests/src/Mod/Part/App/FeatureChamfer.cpp b/tests/src/Mod/Part/App/FeatureChamfer.cpp index 963153c57b..1bf53df0d9 100644 --- a/tests/src/Mod/Part/App/FeatureChamfer.cpp +++ b/tests/src/Mod/Part/App/FeatureChamfer.cpp @@ -31,6 +31,7 @@ protected: _fused = _doc->addObject(); _fused->Base.setValue(_boxes[0]); _fused->Tool.setValue(_boxes[1]); + _fused->Refine.setValue(false); _fused->execute(); _chamfer = _doc->addObject(); } diff --git a/tests/src/Mod/Part/App/FeatureFillet.cpp b/tests/src/Mod/Part/App/FeatureFillet.cpp index 0f1aeb1bb2..0cffb75b50 100644 --- a/tests/src/Mod/Part/App/FeatureFillet.cpp +++ b/tests/src/Mod/Part/App/FeatureFillet.cpp @@ -31,6 +31,7 @@ protected: _fused = _doc->addObject(); _fused->Base.setValue(_boxes[0]); _fused->Tool.setValue(_boxes[1]); + _fused->Refine.setValue(false); _fused->execute(); _fillet = _doc->addObject(); } diff --git a/tests/src/Mod/Part/App/FeatureMirroring.cpp b/tests/src/Mod/Part/App/FeatureMirroring.cpp index abd8177c4d..18e8d767d4 100644 --- a/tests/src/Mod/Part/App/FeatureMirroring.cpp +++ b/tests/src/Mod/Part/App/FeatureMirroring.cpp @@ -64,6 +64,7 @@ TEST_F(FeatureMirroringTest, testYMirrorWithExistingElementMap) _fuse = _doc->addObject(); _fuse->Base.setValue(_boxes[0]); _fuse->Tool.setValue(_boxes[1]); + _fuse->Refine.setValue(false); // Act _fuse->execute(); _mirror->Source.setValue(_fuse); diff --git a/tests/src/Mod/Part/App/FeaturePartFuse.cpp b/tests/src/Mod/Part/App/FeaturePartFuse.cpp index b95806b807..2b914ab78d 100644 --- a/tests/src/Mod/Part/App/FeaturePartFuse.cpp +++ b/tests/src/Mod/Part/App/FeaturePartFuse.cpp @@ -240,7 +240,7 @@ TEST_F(FeaturePartFuseTest, testRefine) // Arrange _fuse->Base.setValue(_boxes[0]); _fuse->Tool.setValue(_boxes[1]); - + _fuse->Refine.setValue(false); // Act _fuse->execute(); Part::TopoShape ts = _fuse->Shape.getValue(); diff --git a/tests/src/Mod/Part/App/PartFeatures.cpp b/tests/src/Mod/Part/App/PartFeatures.cpp index d5f07f8e6c..bb53b03f34 100644 --- a/tests/src/Mod/Part/App/PartFeatures.cpp +++ b/tests/src/Mod/Part/App/PartFeatures.cpp @@ -150,6 +150,7 @@ TEST_F(PartFeaturesTest, testRefine) auto _fuse = _doc->addObject(); _fuse->Base.setValue(_boxes[0]); _fuse->Tool.setValue(_boxes[3]); + _fuse->Refine.setValue(false); _fuse->execute(); Part::TopoShape fusedts = _fuse->Shape.getShape(); auto _refine = _doc->addObject(); diff --git a/tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp b/tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp index 14e048c2d1..f9ee3656d7 100644 --- a/tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp +++ b/tests/src/Mod/Part/App/TopoShapeMakeElementRefine.cpp @@ -32,6 +32,7 @@ TEST_F(FeaturePartMakeElementRefineTest, makeElementRefineBoxes) auto _fuse = _doc->addObject(); _fuse->Base.setValue(_boxes[0]); _fuse->Tool.setValue(_boxes[3]); + _fuse->Refine.setValue(false); // Act _fuse->execute(); Part::TopoShape ts = _fuse->Shape.getShape();