From e8a0ffcd3fe1234be8d95e0a2d4cb3e26bf4b29b Mon Sep 17 00:00:00 2001 From: Kacper Donat Date: Mon, 8 Sep 2025 23:17:59 +0200 Subject: [PATCH] CI: Disable implicit bool conversion linter warning Implicit conversion from integer to boolean and vice versa is very common in FreeCAD due to SbBool (from coin) being defined as int. This creates a lot of false positives that should not be addressed in code reviews. We also use such implicit coversions in FreeCAD often in general so that warning is usually ignored. --- .clang-tidy | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 41a4460324..7286977aa0 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -2,7 +2,7 @@ Checks: 'clang-diagnostic-*,clang-analyzer-*,boost-*,bugprone-*, performance-*,readability-*,portability-*,modernize-*,cppcoreguidelines-*,google-explicit-constructor, concurrency-*,-modernize-use-trailing-return-type, -modernize-use-nodiscard,-readability-identifier-length, --readability-redundant-access-specifiers,-readability-qualified-auto, +-readability-redundant-access-specifiers,-readability-qualified-auto,-readability-implicit-bool-conversion, -cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-owning-memory,-cppcoreguidelines-avoid-do-while, -readability-convert-member-functions-to-static,-bugprone-easily-swappable-parameters, -cppcoreguidelines-pro-type-static-cast-downcast' @@ -203,8 +203,6 @@ CheckOptions: value: '4294967295' - key: bugprone-suspicious-missing-comma.RatioThreshold value: '0.200000' - - key: readability-implicit-bool-conversion.AllowIntegerConditions - value: 'false' - key: readability-identifier-length.IgnoredParameterNames value: '^[n]$' - key: readability-function-size.StatementThreshold