From e8dd1802f67935f0dfc49d45e796957e3b975bf6 Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Sat, 25 Feb 2023 20:40:33 -0600 Subject: [PATCH] Sketcher: Silence Coverity warning Coverity CID 350580: Uninitialized scalar variable. The analyzer doesn't like the incomplete construction of the ConstraintId object (the 'Type' field was uninitialized). --- src/Mod/Sketcher/App/SketchAnalysis.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Mod/Sketcher/App/SketchAnalysis.cpp b/src/Mod/Sketcher/App/SketchAnalysis.cpp index 3b5b0dd31c..031cdbbc92 100644 --- a/src/Mod/Sketcher/App/SketchAnalysis.cpp +++ b/src/Mod/Sketcher/App/SketchAnalysis.cpp @@ -655,11 +655,14 @@ int SketchAnalysis::detectMissingEqualityConstraints(double precision) std::vector constraint = sketch->Constraints.getValues(); for (std::vector::iterator it = constraint.begin(); it != constraint.end(); ++it) { if ((*it)->Type == Sketcher::Equal) { - ConstraintIds id; - id.First = (*it)->First; - id.FirstPos = (*it)->FirstPos; - id.Second = (*it)->Second; - id.SecondPos = (*it)->SecondPos; + ConstraintIds id { + Base::Vector3d{}, + (*it)->First, + (*it)->Second, + (*it)->FirstPos, + (*it)->SecondPos, + (*it)->Type + }; std::list::iterator pos = std::find_if (equallines.begin(), equallines.end(), Constraint_Equal(id));