From e91c2d6afd8093eb9010a683248d202cadaeebb1 Mon Sep 17 00:00:00 2001 From: wmayer Date: Thu, 12 Mar 2020 11:39:09 +0100 Subject: [PATCH] fixes #0004286: PartDesign hole: angle of the tapered hole does not match the tapered angle specified [skip ci] See https://forum.freecadweb.org/viewtopic.php?f=13&t=44056#p375915 --- src/Mod/PartDesign/App/FeatureHole.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Mod/PartDesign/App/FeatureHole.cpp b/src/Mod/PartDesign/App/FeatureHole.cpp index d6afbff035..5343d9cce7 100644 --- a/src/Mod/PartDesign/App/FeatureHole.cpp +++ b/src/Mod/PartDesign/App/FeatureHole.cpp @@ -1019,7 +1019,7 @@ App::DocumentObjectExecReturn *Hole::execute(void) bool isCountersink = (holeCutType == "Countersink" || holeCutType == "Countersink socket screw"); bool isCounterbore = (holeCutType == "Counterbore" || holeCutType == "Cheesehead" || holeCutType == "Cap screw"); double hasTaperedAngle = Tapered.getValue() ? Base::toRadians( TaperedAngle.getValue() ) : Base::toRadians(90.0); - double radiusBottom = Diameter.getValue() / 2.0 - length * cos( hasTaperedAngle ); + double radiusBottom = Diameter.getValue() / 2.0 - length * 1.0 / tan( hasTaperedAngle ); double radius = Diameter.getValue() / 2.0; double holeCutRadius = HoleCutDiameter.getValue() / 2.0; gp_Pnt firstPoint(0, 0, 0);