From e9ec2422e186e13210e56e915604ebae95d538bd Mon Sep 17 00:00:00 2001 From: mosfet80 Date: Mon, 11 Mar 2024 18:20:32 +0100 Subject: [PATCH] [Mod] Removed unnecessary function (#12772) * Removed unnecessary function the "renamedDocumentObjet" function does nothing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- src/Mod/Spreadsheet/App/PropertySheet.cpp | 23 ----------------------- src/Mod/Spreadsheet/App/PropertySheet.h | 1 - src/Mod/Spreadsheet/App/SheetObserver.cpp | 4 +--- 3 files changed, 1 insertion(+), 27 deletions(-) diff --git a/src/Mod/Spreadsheet/App/PropertySheet.cpp b/src/Mod/Spreadsheet/App/PropertySheet.cpp index 57efc9c6e1..742f380d6d 100644 --- a/src/Mod/Spreadsheet/App/PropertySheet.cpp +++ b/src/Mod/Spreadsheet/App/PropertySheet.cpp @@ -1561,29 +1561,6 @@ void PropertySheet::onRemoveDep(App::DocumentObject* obj) depConnections.erase(obj); } -void PropertySheet::renamedDocumentObject(const App::DocumentObject* docObj) -{ -#if 1 - (void)docObj; -#else - if (documentObjectName.find(docObj) == documentObjectName.end()) { - return; - } - - std::map::iterator i = data.begin(); - - while (i != data.end()) { - RelabelDocumentObjectExpressionVisitor v(*this, docObj); - i->second->visit(v); - if (v.changed()) { - v.reset(); - recomputeDependencies(i->first); - setDirty(i->first); - } - ++i; - } -#endif -} void PropertySheet::onRelabeledDocument(const App::Document& doc) { diff --git a/src/Mod/Spreadsheet/App/PropertySheet.h b/src/Mod/Spreadsheet/App/PropertySheet.h index 09c80c857b..500e78d48c 100644 --- a/src/Mod/Spreadsheet/App/PropertySheet.h +++ b/src/Mod/Spreadsheet/App/PropertySheet.h @@ -201,7 +201,6 @@ public: void invalidateDependants(const App::DocumentObject* docObj); - void renamedDocumentObject(const App::DocumentObject* docObj); void renameObjectIdentifiers(const std::map& paths); diff --git a/src/Mod/Spreadsheet/App/SheetObserver.cpp b/src/Mod/Spreadsheet/App/SheetObserver.cpp index a3e84b7fb9..4007ccafae 100644 --- a/src/Mod/Spreadsheet/App/SheetObserver.cpp +++ b/src/Mod/Spreadsheet/App/SheetObserver.cpp @@ -70,9 +70,7 @@ void SheetObserver::slotDeletedObject(const DocumentObject& Obj) void SheetObserver::slotChangedObject(const DocumentObject& Obj, const Property& Prop) { - if (&Prop == &Obj.Label) { - sheet->renamedDocumentObject(&Obj); - } + if (&Prop == &Obj.Label) {} else { const char* name = Obj.getPropertyName(&Prop);