kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

MSVC also fails to automatically move if no elision possible

Browse Source
This commit is contained in:
Abdullah Tahiri
2019-04-01 16:34:47 +02:00
committed by wmayer
parent 9fb2606c88
commit ea050c9cfc
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Part/App/GeometryDefaultExtension.cpp
View File

@@ -81,10 +81,10 @@ std::unique_ptr<Part::GeometryExtension> GeometryDefaultExtension<T>::copy(void)
cpy->value = this->value;
cpy->setName(this->getName());
#if defined(__GNUC__) && __GNUC__ < 7
return std::move(cpy); // GCC 4.8 bug
#if (defined(__GNUC__) && __GNUC__ < 7 ) || defined(_MSC_VER)
return std::move(cpy); // GCC 4.8 and MSC do not support automatic move constructor call if the compiler fails to elide
#else
return cpy; // all the others use RVO optimization perfectly fine.
return cpy; // all the others do automatic move constructor if RVO optimization not possible.
#endif
// Advise from Scott Meyers Effective Modern c++:
//