From ea0f95739bb2cc2102ef9f5d34153fcc2bfce615 Mon Sep 17 00:00:00 2001 From: wmayer Date: Wed, 3 Mar 2021 14:56:16 +0100 Subject: [PATCH] PD: [skip ci] fix angle checks for groove and revolution --- src/Mod/PartDesign/App/FeatureGroove.cpp | 4 ++-- src/Mod/PartDesign/App/FeatureRevolution.cpp | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureGroove.cpp b/src/Mod/PartDesign/App/FeatureGroove.cpp index 7738a9a5a2..2b4ffc00ba 100644 --- a/src/Mod/PartDesign/App/FeatureGroove.cpp +++ b/src/Mod/PartDesign/App/FeatureGroove.cpp @@ -83,12 +83,12 @@ App::DocumentObjectExecReturn *Groove::execute(void) { // Validate parameters double angle = Angle.getValue(); - if (angle < Precision::Confusion()) - return new App::DocumentObjectExecReturn("Angle of groove too small"); if (angle > 360.0) return new App::DocumentObjectExecReturn("Angle of groove too large"); angle = Base::toRadians(angle); + if (angle < Precision::Angular()) + return new App::DocumentObjectExecReturn("Angle of groove too small"); // Reverse angle if selected if (Reversed.getValue() && !Midplane.getValue()) diff --git a/src/Mod/PartDesign/App/FeatureRevolution.cpp b/src/Mod/PartDesign/App/FeatureRevolution.cpp index cf1f81e468..419dc5b817 100644 --- a/src/Mod/PartDesign/App/FeatureRevolution.cpp +++ b/src/Mod/PartDesign/App/FeatureRevolution.cpp @@ -81,12 +81,13 @@ App::DocumentObjectExecReturn *Revolution::execute(void) { // Validate parameters double angle = Angle.getValue(); - if (angle < Precision::Confusion()) - return new App::DocumentObjectExecReturn("Angle of revolution too small"); if (angle > 360.0) return new App::DocumentObjectExecReturn("Angle of revolution too large"); angle = Base::toRadians(angle); + if (angle < Precision::Angular()) + return new App::DocumentObjectExecReturn("Angle of revolution too small"); + // Reverse angle if selected if (Reversed.getValue() && !Midplane.getValue()) angle *= (-1.0);