From ec86e2a440ad28355e32d9487ca7c100476bb427 Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Sun, 15 Jun 2025 20:59:54 -0500 Subject: [PATCH] Sketcher: Remove redundant checks Also cleanup missing curly braces. --- src/Mod/Sketcher/App/SketchObject.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Mod/Sketcher/App/SketchObject.cpp b/src/Mod/Sketcher/App/SketchObject.cpp index c6002f29c5..1102153654 100644 --- a/src/Mod/Sketcher/App/SketchObject.cpp +++ b/src/Mod/Sketcher/App/SketchObject.cpp @@ -1784,8 +1784,9 @@ int SketchObject::delGeometry(int GeoId, bool deleteinternalgeo) Base::StateLocker lock(managedoperation, true); const std::vector& vals = getInternalGeometry(); - if (GeoId < 0 || GeoId >= int(vals.size())) + if (GeoId >= int(vals.size())) { return -1; + } if (deleteinternalgeo && hasInternalGeometry(getGeometry(GeoId))) { // Only for supported types @@ -7568,8 +7569,9 @@ const Part::Geometry* SketchObject::_getGeometry(int GeoId) const if (GeoId < int(geomlist.size())) return geomlist[GeoId]; } - else if (GeoId < 0 && -GeoId-1 < ExternalGeo.getSize()) + else if (-GeoId-1 < ExternalGeo.getSize()) { return ExternalGeo[-GeoId-1]; + } return nullptr; }