kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Remove magic numbers and hard type enums in DimensionFormatter.h.h

Browse Source 
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
This commit is contained in:
Benjamin Bræstrup Sayoc
2025-01-30 22:45:48 +01:00
committed by WandererFan
parent 63d9806b86
commit f115ed4bb1
7 changed files with 56 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/TechDraw/App/DrawViewDimension.cpp
View File

@@ -605,7 +605,7 @@ bool DrawViewDimension::isMultiValueSchema() const
}
std::string
DrawViewDimension::formatValue(qreal value, QString qFormatSpec, int partial, bool isDim)
DrawViewDimension::formatValue(qreal value, QString qFormatSpec, DimensionFormatter::Format partial, bool isDim)
{
return m_formatter->formatValue(value, qFormatSpec, partial, isDim);
}
@@ -622,19 +622,19 @@ bool DrawViewDimension::haveTolerance()
return false;
}
std::string DrawViewDimension::getFormattedToleranceValue(int partial)
std::string DrawViewDimension::getFormattedToleranceValue(DimensionFormatter::Format partial)
{
return m_formatter->getFormattedToleranceValue(partial);
}
////get over and under tolerances
std::pair<std::string, std::string> DrawViewDimension::getFormattedToleranceValues(int partial)
std::pair<std::string, std::string> DrawViewDimension::getFormattedToleranceValues(DimensionFormatter::Format partial)
{
return m_formatter->getFormattedToleranceValues(partial);
}
////partial = 2 unit only
std::string DrawViewDimension::getFormattedDimensionValue(int partial)
std::string DrawViewDimension::getFormattedDimensionValue(DimensionFormatter::Format partial)
{
return m_formatter->getFormattedDimensionValue(partial);
}