From f3bce14f29dbbc1cfecf16f3ab6021ca56c04240 Mon Sep 17 00:00:00 2001
From: Aapo <aapo.lankinen@gmail.com>
Date: Tue, 15 Dec 2020 23:32:11 +0200
Subject: [PATCH] [TD] Balloon, move property LineVisible to View tab and fix a
 refresh bug.

---
 src/Mod/TechDraw/App/DrawViewBalloon.cpp     | 2 --
 src/Mod/TechDraw/App/DrawViewBalloon.h       | 1 -
 src/Mod/TechDraw/Gui/QGIViewBalloon.cpp      | 2 +-
 src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp | 4 +++-
 src/Mod/TechDraw/Gui/ViewProviderBalloon.h   | 1 +
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Mod/TechDraw/App/DrawViewBalloon.cpp b/src/Mod/TechDraw/App/DrawViewBalloon.cpp
index ed9f6ca837..2f40d08e37 100644
--- a/src/Mod/TechDraw/App/DrawViewBalloon.cpp
+++ b/src/Mod/TechDraw/App/DrawViewBalloon.cpp
@@ -113,8 +113,6 @@ DrawViewBalloon::DrawViewBalloon(void)
     ADD_PROPERTY_TYPE(KinkLength,(prefKinkLength()),"",(App::PropertyType)(App::Prop_None),
                                   "Distance from symbol to leader kink");
 
-    ADD_PROPERTY_TYPE(LineVisible,(true),"",(App::PropertyType)(App::Prop_None),"Balloon line visible or hidden");
-
     SourceView.setScope(App::LinkScope::Global);
     Rotation.setStatus(App::Property::Hidden,true);
     Caption.setStatus(App::Property::Hidden,true);
diff --git a/src/Mod/TechDraw/App/DrawViewBalloon.h b/src/Mod/TechDraw/App/DrawViewBalloon.h
index 0892aac32a..ac72ae8699 100644
--- a/src/Mod/TechDraw/App/DrawViewBalloon.h
+++ b/src/Mod/TechDraw/App/DrawViewBalloon.h
@@ -59,7 +59,6 @@ public:
     App::PropertyDistance        OriginY;
     App::PropertyFloat           TextWrapLen;
     App::PropertyDistance        KinkLength;
-    App::PropertyBool            LineVisible;
 
     short mustExecute() const override;
 
diff --git a/src/Mod/TechDraw/Gui/QGIViewBalloon.cpp b/src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
index 1b7b062a0e..205cbfe093 100644
--- a/src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
+++ b/src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
@@ -766,7 +766,7 @@ void QGIViewBalloon::draw()
     balloonLines->setPath(dLinePath);
 
     // This overwrites the previously created QPainterPath with empty one, in case it should be hidden.  Should be refactored.
-    if (!balloon->LineVisible.getValue()) {
+    if (!vp->LineVisible.getValue()) {
         arrow->hide();
         balloonLines->setPath(QPainterPath());
     }
diff --git a/src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp b/src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp
index f88dbb6f09..f79910b5e5 100644
--- a/src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp
+++ b/src/Mod/TechDraw/Gui/ViewProviderBalloon.cpp
@@ -75,6 +75,7 @@ ViewProviderBalloon::ViewProviderBalloon()
     double weight = lg->getWeight("Thin");
     delete lg;                                   //Coverity CID 174670
     ADD_PROPERTY_TYPE(LineWidth,(weight),group,(App::PropertyType)(App::Prop_None),"Leader line width");
+    ADD_PROPERTY_TYPE(LineVisible,(true),group,(App::PropertyType)(App::Prop_None),"Balloon line visible or hidden");
 
     ADD_PROPERTY_TYPE(Color,(PreferencesGui::dimColor()),
                                               group,App::Prop_None,"Color of the balloon");
@@ -148,7 +149,8 @@ void ViewProviderBalloon::onChanged(const App::Property* p)
     if ((p == &Font)  ||
         (p == &Fontsize) ||
         (p == &Color) ||
-        (p == &LineWidth)) {
+        (p == &LineWidth) ||
+        (p == &LineVisible)) {
         QGIView* qgiv = getQView();
         if (qgiv) {
             qgiv->updateView(true);
diff --git a/src/Mod/TechDraw/Gui/ViewProviderBalloon.h b/src/Mod/TechDraw/Gui/ViewProviderBalloon.h
index fd9cb6ad27..2f88a50434 100644
--- a/src/Mod/TechDraw/Gui/ViewProviderBalloon.h
+++ b/src/Mod/TechDraw/Gui/ViewProviderBalloon.h
@@ -48,6 +48,7 @@ public:
     App::PropertyFont   Font;
     App::PropertyLength Fontsize;
     App::PropertyLength LineWidth;
+    App::PropertyBool   LineVisible;
     App::PropertyColor  Color;
 
     virtual void attach(App::DocumentObject *);