From f429b568bb8948066a416a766dbe70e2318d78de Mon Sep 17 00:00:00 2001 From: mwganson Date: Sun, 19 Jul 2020 14:51:30 -0500 Subject: [PATCH] [openscad] add icon for mirror mesh feature --- src/Mod/OpenSCAD/OpenSCADCommands.py | 8 ++++++-- src/Mod/OpenSCAD/OpenSCADUtils.py | 2 +- src/Mod/OpenSCAD/Resources/OpenSCAD.qrc | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/Mod/OpenSCAD/OpenSCADCommands.py b/src/Mod/OpenSCAD/OpenSCADCommands.py index 99f17bffde..afb4d7f850 100644 --- a/src/Mod/OpenSCAD/OpenSCADCommands.py +++ b/src/Mod/OpenSCAD/OpenSCADCommands.py @@ -168,8 +168,12 @@ class MirrorMeshFeature: newobj=selobj.Document.addObject("Mesh::Feature",'mirror') newobj.Label='mirror_%s' % selobj.Object.Label msh=selobj.Object.Mesh - newobj.Mesh=OpenSCADUtils.mirror(msh) - selobj.Object.ViewObject.hide() + newmesh=OpenSCADUtils.mirror(msh) + if not newmesh: + selobj.Document.removeObject(newobj.Name) + else: + newobj.Mesh=newmesh + selobj.Object.ViewObject.hide() FreeCAD.ActiveDocument.recompute() def GetResources(self): return {'Pixmap' : 'OpenSCAD_MirrorMeshFeature', diff --git a/src/Mod/OpenSCAD/OpenSCADUtils.py b/src/Mod/OpenSCAD/OpenSCADUtils.py index 22dc486426..080a6b52e0 100644 --- a/src/Mod/OpenSCAD/OpenSCADUtils.py +++ b/src/Mod/OpenSCAD/OpenSCADUtils.py @@ -309,7 +309,7 @@ def mirror(msh): mi = callopenscadmeshstring('%s{%s}' % (param,''.join(poly))) mi.flipNormals() return mi - return msh + return None def angneg(d): diff --git a/src/Mod/OpenSCAD/Resources/OpenSCAD.qrc b/src/Mod/OpenSCAD/Resources/OpenSCAD.qrc index 52e78016d5..0b8290ed24 100644 --- a/src/Mod/OpenSCAD/Resources/OpenSCAD.qrc +++ b/src/Mod/OpenSCAD/Resources/OpenSCAD.qrc @@ -1,5 +1,5 @@ - + icons/preferences-openscad.svg icons/OpenSCAD_AddOpenSCADElement.svg icons/OpenSCAD_ColorCodeShape.svg @@ -50,5 +50,6 @@ translations/OpenSCAD_val-ES.qm translations/OpenSCAD_ar.qm translations/OpenSCAD_vi.qm + icons/OpenSCAD_MirrorMeshFeature.svg