fix readability-*:

* readability-const-return-type
* readability-container-data-pointer
* readability-container-size-empty
* readability-delete-null-pointer
* readability-else-after-return
* readability-inconsistent-declaration-parameter-name
* readability-redundant-member-init
* readability-redundant-smartptr-get
* readability-redundant-string-cstr
* readability-use-anyofallof
* readability-static-definition-in-anonymous-namespace
* readability-static-accessed-through-instance
* readability-simplify-boolean-expr

src/Base/Factory.cpp

@@ -50,9 +50,8 @@ void* Factory::Produce(const char* sClassName) const
     if (pProd != _mpcProducers.end()) {
         return pProd->second->Produce();
     }
-    else {
-        return nullptr;
-    }
+
+    return nullptr;
 }
 
 void Factory::AddProducer(const char* sClassName, AbstractProducer* pcProducer)
@@ -91,9 +90,7 @@ ScriptFactorySingleton& ScriptFactorySingleton::Instance()
 
 void ScriptFactorySingleton::Destruct()
 {
-    if (_pcSingleton) {
-        delete _pcSingleton;
-    }
+    delete _pcSingleton;
     _pcSingleton = nullptr;
 }