fix readability-*:

* readability-const-return-type
* readability-container-data-pointer
* readability-container-size-empty
* readability-delete-null-pointer
* readability-else-after-return
* readability-inconsistent-declaration-parameter-name
* readability-redundant-member-init
* readability-redundant-smartptr-get
* readability-redundant-string-cstr
* readability-use-anyofallof
* readability-static-definition-in-anonymous-namespace
* readability-static-accessed-through-instance
* readability-simplify-boolean-expr

src/Base/Matrix.cpp

@@ -978,24 +978,23 @@ std::array<Matrix4D, 4> Matrix4D::decompose() const
             prim_dir = i;
             continue;
         }
-        else {
-            Vector3d cross = dirs[prim_dir].Cross(residualMatrix.getCol(i));
-            if (cross.IsNull()) {
-                continue;
-            }
-            cross.Normalize();
-            int last_dir = 3 - i - prim_dir;
-            if (i - prim_dir == 1) {
-                dirs[last_dir] = cross;
-                dirs[i] = cross.Cross(dirs[prim_dir]);
-            }
-            else {
-                dirs[last_dir] = -cross;
-                dirs[i] = dirs[prim_dir].Cross(-cross);
-            }
-            prim_dir = -2;  // done
-            break;
+
+        Vector3d cross = dirs[prim_dir].Cross(residualMatrix.getCol(i));
+        if (cross.IsNull()) {
+            continue;
         }
+        cross.Normalize();
+        int last_dir = 3 - i - prim_dir;
+        if (i - prim_dir == 1) {
+            dirs[last_dir] = cross;
+            dirs[i] = cross.Cross(dirs[prim_dir]);
+        }
+        else {
+            dirs[last_dir] = -cross;
+            dirs[i] = dirs[prim_dir].Cross(-cross);
+        }
+        prim_dir = -2;  // done
+        break;
     }
     if (prim_dir >= 0) {
         // handle case with only one valid direction