kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests Actions 4 Packages Projects 9 Releases 2 Wiki Activity

fix readability-*:

Browse Source 
* readability-const-return-type
* readability-container-data-pointer
* readability-container-size-empty
* readability-delete-null-pointer
* readability-else-after-return
* readability-inconsistent-declaration-parameter-name
* readability-redundant-member-init
* readability-redundant-smartptr-get
* readability-redundant-string-cstr
* readability-use-anyofallof
* readability-static-definition-in-anonymous-namespace
* readability-static-accessed-through-instance
* readability-simplify-boolean-expr
This commit is contained in:
wmayer
2023-11-15 10:50:27 +01:00
parent e4975f0153
commit f539138dd9
42 changed files with 330 additions and 458 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/Base/Type.cpp
View File

@@ -119,7 +119,7 @@ Type Type::badType()
}
const Type Type::createType(const Type& parent, const char* name, instantiationMethod method)
Type Type::createType(const Type& parent, const char* name, instantiationMethod method)
{
Type newType;
newType.index = static_cast<unsigned int>(Type::typedata.size());
@@ -135,7 +135,7 @@ const Type Type::createType(const Type& parent, const char* name, instantiationM
void Type::init()
{
assert(Type::typedata.size() == 0);
assert(Type::typedata.empty());
Type::typedata.push_back(new TypeData("BadType"));
@@ -160,9 +160,8 @@ Type Type::fromName(const char* name)
if (pos != typemap.end()) {
return typedata[pos->second]->type;
}
else {
return Type::badType();
}
return Type::badType();
}
Type Type::fromKey(unsigned int key)
@@ -170,9 +169,8 @@ Type Type::fromKey(unsigned int key)
if (key < typedata.size()) {
return typedata[key]->type;
}
else {
return Type::badType();
}
return Type::badType();
}
const char* Type::getName() const
@@ -180,7 +178,7 @@ const char* Type::getName() const
return typedata[index]->name.c_str();
}
const Type Type::getParent() const
Type Type::getParent() const
{
return typedata[index]->parent;
}
@@ -228,7 +226,6 @@ Type Type::getTypeIfDerivedFrom(const char* name, const Type& parent, bool bLoad
if (type.isDerivedFrom(parent)) {
return type;
}
else {
return Type::badType();
}
return Type::badType();
}