From feb4ffc6933a89e50cf2b7d65f73306318d2162f Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Sun, 7 Feb 2021 19:59:06 -0600 Subject: [PATCH] Correct minimum distance calculation in SplitFacet Found via LGTM. --- src/Mod/Mesh/App/Core/TopoAlgorithm.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Mod/Mesh/App/Core/TopoAlgorithm.cpp b/src/Mod/Mesh/App/Core/TopoAlgorithm.cpp index 830a18a327..d591bb2607 100644 --- a/src/Mod/Mesh/App/Core/TopoAlgorithm.cpp +++ b/src/Mod/Mesh/App/Core/TopoAlgorithm.cpp @@ -1148,7 +1148,7 @@ void MeshTopoAlgorithm::SplitFacet(unsigned long ulFacetPos, const Base::Vector3 Base::Vector3f cDir = cEnd - cBase; float fDist = rP2.DistanceToLine(cBase, cDir); - if ( fMinDist < fDist ) + if ( fDist < fMinDist ) { fMinDist = fDist; iEdgeNo = i; @@ -1174,7 +1174,7 @@ void MeshTopoAlgorithm::SplitFacet(unsigned long ulFacetPos, const Base::Vector3 Base::Vector3f cDir = cEnd - cBase; float fDist = rP1.DistanceToLine(cBase, cDir); - if ( fMinDist < fDist ) + if ( fDist < fMinDist ) { fMinDist = fDist; iEdgeNo = i; @@ -1201,13 +1201,13 @@ void MeshTopoAlgorithm::SplitFacet(unsigned long ulFacetPos, const Base::Vector3 Base::Vector3f cDir = cEnd - cBase; float fDist = rP1.DistanceToLine(cBase, cDir); - if ( fMinDist1 < fDist ) + if ( fDist < fMinDist1 ) { fMinDist1 = fDist; iEdgeNo1 = i; } fDist = rP2.DistanceToLine(cBase, cDir); - if ( fMinDist2 < fDist ) + if ( fDist < fMinDist2 ) { fMinDist2 = fDist; iEdgeNo2 = i;