kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
22,438 Commits 40 Branches 6 Tags
00dc2c84762dc9f688f7c3a688d7b43a88dac476
Commit Graph

2329 Commits

Author SHA1 Message Date
vocx-fc
00dc2c8476 Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
vocx-fc
ff79e28054 Path: add missing postprocessor to CMakeLists 2020-09-14 22:18:00 -05:00
wmayer
1c9573e8d2 dxf: [skip ci] Coverity: Buffer not null terminated 2020-09-14 14:37:20 +02:00
luz paz
6f62fd09df Fix typos in various files [skip-ci] 
Found via `codespell 2.0.dev0`  
```
codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-09-04 10:10:31 +02:00
luz paz
ab7e5fb087 Fix typos in source comments 
Found via `codespell`
 2020-08-29 19:14:13 +02:00
luz paz
f0d823eb51 Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
sliptonic
6db220a458 Merge pull request #3763 from Russ4262/PocketShape_fix_t4411 
Path: PocketShape - Fixes ticket #4411
 2020-08-04 10:40:53 -05:00
sliptonic
0a9f7034a9 Merge pull request #3751 from J-Dunn/master 
Path: prevent added paths creating tool crash: fixed #4260
 2020-08-04 10:40:13 -05:00
sliptonic
169a66b225 Merge pull request #3706 from etrombly/emptyPath 
[PATH] don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same.
 2020-08-04 10:20:13 -05:00
Russell Johnson
10b5cbc115 Path: Fix reference to undefined ns, and adjust comments 
This `ns` fix might need further attention after testing.  The section to which it pertains deals with optimizing rotations between ops with similar rotational axes.
 2020-08-02 13:27:32 -05:00
Russell Johnson
8e4032fc0d Path: Fix the rotational LimitDepthToFace feature 2020-08-02 13:27:32 -05:00
Russell Johnson
32f82a9b5e Path: Fix InverseAngle feature 
The `ReverseDirection` property is now hidden by default.  It should not be necessary due to recent implementation of `isFaceUp()` method.
 2020-08-02 13:27:32 -05:00
Russell Johnson
015eb0421b Path: PocketShape - Fixes ticket #4411 
Existing code to determine if shape volume indeed existed, failed.
Added additional pre-check for existing edges in shape to determine if shape geometry indeed exists.
In forum:
[Ticket #4411 - Can only generate pocket once for this shape, then it fails.](https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49035).
 2020-08-02 13:27:32 -05:00
sliptonic
d95527ca50 Merge pull request #3700 from etrombly/deletedFaces 
[Path] handle makeOffset2D exception in path pocket operation
 2020-07-28 11:50:27 -05:00
sliptonic
1a68959160 Merge pull request #3585 from gwicke/unified_region_experiments 
Path: Area based unified projection implementation
 2020-07-28 11:48:56 -05:00
J-Dunn
2b79cb731a prevent added paths creating tool crash #4260 #3028 
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
 2020-07-28 14:12:11 +01:00
sliptonic
ebe45e5603 Merge pull request #3689 from etrombly/edgesMatchShape 
[PATH] fix pocket attribute error if edge cannot be flipped
 2020-07-27 12:53:37 -05:00
wmayer
13fc0554a0 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
45e0673645 LGTM: [skip ci] fix: Declaration hides parameter 
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
 2020-07-27 10:57:34 +02:00
wmayer
e079e7a7bb LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
c162037476 LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
Mark Ganson TheMarkster
181eaa1b7a coverity issue cid 305102 2020-07-23 13:55:32 +02:00
Gabriel Wicke
670f3b6098 Path: Area based unified projection implementation 
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
 2020-07-21 18:34:09 -07:00
sliptonic
43f4ae927d Merge pull request #3709 from etrombly/3dSurface 
[Path] fix two never ending while loops in PathSurfaceSupport
 2020-07-21 10:58:48 -05:00
wmayer
c4bb1ff762 Coverity: Copied into fixed size buffer 2020-07-20 17:34:25 +02:00
wmayer
083d0e012f Coverity: Invalid printf format string 2020-07-20 17:34:23 +02:00
wmayer
4807fd3b33 PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
Eric Trombly
fca189debc fix two never ending while loops in PathSurfaceSupport 2020-07-17 13:59:10 -05:00
Eric Trombly
e630e3786f handle offset error in PathPocketShapeGui 2020-07-15 21:31:34 -05:00
Eric Trombly
5fe22270cc handle makeOffset2D exception 2020-07-15 21:31:34 -05:00
Eric Trombly
cf9fec5ffd don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same. 2020-07-15 19:35:18 -05:00
Eric Trombly
29e842d4e0 fix attributeError if edge can't be flipped 2020-07-14 18:53:54 -05:00
luz paz
e4f6689e0a Merged crowdin translations 2020-07-13 14:49:45 +02:00
Yorik van Havre
da262c0b45 Updated master ts files 2020-07-13 13:20:21 +02:00
sliptonic
5faa738002 Merge pull request #3688 from etrombly/deleted 
[PATH] fix Cannot access attribute 'Document' of deleted object when cancelling PathPocket operation
 2020-07-12 16:27:35 -05:00
Eric Trombly
547c6fa26e cleaner fix 2020-07-10 15:42:00 -05:00
Eric Trombly
6a1c68a647 fix deleted object error 2020-07-10 15:42:00 -05:00
sliptonic
82f13231c7 unhide the property for the interpolation surface 2020-07-09 10:47:58 -05:00
Russell Johnson
7c3a1f2ee8 Path: Add basic support for arc and circular edges 
- Arc and circular slots available using single edge selection.
- `ExtendRadius` property to allow for tool compensation.
- Extend path start and end is available. Value is measured along the arc, not linear.
- Includes collision check for arc and circular slots.
 2020-07-02 01:16:22 -05:00
luz.paz
ef37cc3930 Fix typos [skip-ci] 
Found via codespell v1.18.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-06-29 20:52:23 +02:00
sliptonic
1b643536b9 Merge pull request #3657 from Russ4262/MillFace_fix 
[Path] MillFace - Fix calculation of OpFinalDepth default value
 2020-06-29 09:54:04 -05:00
sliptonic
2c74dd8e28 Merge pull request #3645 from Russ4262/BaseGeomList_resize 
[Path] Resize the Base Geometry list dynamically
 2020-06-29 09:53:18 -05:00
Eric Trombly
74ef899a75 check if pcLineCoords is empty 2020-06-28 19:52:59 -05:00
Eric Trombly
031a3d0816 fix null reference 2020-06-28 19:52:59 -05:00
Russell Johnson
22bc65b54c Path: Resize the Base Geometry list dynamically 
Make the size of the Base Geometry list dynamically adjust to its contents.
 2020-06-27 15:05:00 -05:00
Russell Johnson
ebc1a42880 Path: Fix calculation of OpFinalDepth default value 
Remove commented lines.
Modify PathLog.Level assignment for easier readability.
 2020-06-27 09:36:14 -05:00
sliptonic
5c5a882ec5 Merge pull request #3599 from GeneGH/Edits 
Path Simulator - Recognition of canned cycle cancellation
 2020-06-21 13:22:49 -05:00
sliptonic
0c79264d5c Merge branch 'master' into master 2020-06-21 10:38:47 -05:00
Russell Johnson
f525fedd11 Path: Slot operation fixes and improvements 
- Add `CutPattern` feature, defaulting to `ZigZag`.
- Change inter-pass retractions to SafeHeight for multi-pass operations.
- Fix division by zero instance for particular Perpendicular use case.
- Synchronize property values with inputs in both the Property View and Tasks Editor windows.
- Change `LayerMode` default value to `Multi-pass`.
- Improve debug messaging.
- Consolidate code and remove unused code.

Path: fix exception thrown
 2020-06-20 14:27:12 -05:00
sliptonic
48b0c71c20 [Path] Make jobs delete cleanly. 
Deletion of tool controllers now works for toolbits as well
 2020-06-19 13:17:17 -05:00