Commit Graph

285 Commits

Author SHA1 Message Date
tarman3
01bd4a1f9e CAM: Remove tool body with Job onDelete (#22924) 2025-08-23 12:11:51 -05:00
tarman3
9bcbc17433 CAM: Do not show models of the toolbits in Job dialog (#22893) 2025-08-23 12:10:38 -05:00
tarman3
bb444a4a04 CAM: Fix seach tool controller in Operations group (#22728) 2025-08-11 11:04:06 -05:00
Ryan Kembrey
4ff71394da CAM: Update UI strings for consistency
Closes: #22350
2025-08-04 20:13:52 +02:00
J-Dunn
8a65e29d23 CAM: revert grbl_post regression (#22569)
* CAM: revert grbl_post regression

I recently noticed a bug in grbl_proc post processor where it was not correctly setting OLD_Z  if current machine_z is below G81 retract plane in R parmeter. 

On digging into my original commit is looks like the two lines which did this have been commented out. 
I can never find the Blame feature when I need so if someone else can find the culprit feel free. 

2bd617a2b3

This PR simply reinstates the missing lines and adds a snippet of NIST as a comment block  to prevent any over-zealous editing in the future. 

This regression means that drilling cycles start with z=clearance height instead of z=safe height leading to much costly air cutting.
This similarly messes up the  the retract plane for G98 leading to excessive machine time wasting and incorrect application of G98 returns. 

Indeed this regression was noticed because some were claiming the Safe height was redundant in drilling ops since it was never used. 

There is much discussion about all this at the moment which is being disrupted by people assuming the current broken paths are what FreeCAD is intended to do. 

Let's fix this ASAP, so we can stop this confusion and get discussions back to reality.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-04 10:57:03 -05:00
sliptonic
35a6d485ee Merge pull request #22228 from knipknap/fix-custom-attribute-edit
CAM: Various bugfixes for CAM tool management
2025-08-04 10:39:25 -05:00
sliptonic
35fbdf7978 Merge pull request #22392 from knipknap/fix-test-uses-user-data
CAM: fix: CAM tests use files from user asset dir
2025-07-28 11:08:50 -05:00
sliptonic
6c71317029 Merge pull request #22314 from tarman3/vcarve
CAM: Vcarve fix
2025-07-25 12:44:16 -05:00
sliptonic
0665872310 Merge pull request #22398 from dbtayl/fix_22073
CAM: Adaptive: Fix NULL input shapes when top of stock equals top of model
2025-07-21 11:35:39 -05:00
sliptonic
117b3352b4 Merge pull request #22524 from jffmichi/drilling_remove_redundant
CAM: remove redundant move after drilling
2025-07-18 14:15:19 -05:00
sliptonic
7e0d2d21f7 Merge pull request #22374 from z0r0/CAM-Inspect-Fix
CAM: Fixing Length Check in CommandPathInspect class
2025-07-17 13:40:08 -05:00
jffmichi
5d48197a5d CAM: remove redundant move after drilling 2025-07-16 20:31:42 +02:00
sliptonic
901deb1373 Merge pull request #22330 from z0r0/fanuc-postprocessor-fix
CAM: Fix for Fanuc Post-Processor
2025-07-11 11:00:50 -05:00
Ian Abreu
7fb9b71cd8 Merge branch 'main' into CAM-Inspect-Fix 2025-07-09 19:40:30 -04:00
Samuel Abels
5a9b1fac8f CAM: silence unnecessary log for preferences change when no change was actually made 2025-07-09 10:19:22 +02:00
Dan Taylor
99d435b3c2 CAM: Adaptive: Fix NULL input shapes when top of stock equals top of model (fix #22073) 2025-07-08 20:09:33 -05:00
Samuel Abels
8430fd5615 CAM: fix: CAM tests use files from user asset dir 2025-07-08 20:39:52 +02:00
tarman3
55ae838394 CAM: Vcarve fix 2025-07-07 19:56:02 +03:00
sliptonic
c5f97ee894 Merge pull request #21341 from tarman3/arraywarning
CAM: Changes in warnings of old Array
2025-07-07 11:06:11 -05:00
Ian Abreu
7908b3b266 fixing typos 2025-07-06 16:30:53 -04:00
Ian Abreu
41500dcffb adding sanity fix 2025-07-06 16:26:50 -04:00
Ian Abreu
1c3a4e5d69 Merge branch 'main' into CAM-Inspect-Fix 2025-07-06 16:24:42 -04:00
Ian Abreu
5b962e7ec3 Adding simple check 2025-07-06 11:07:15 -04:00
Kacper Donat
e65f69715b CAM: Fix origin indicator for Job
This commit fixes how origin (coordinate system) indicator looks. Before
it showed as disc, and now it shows as point which is more approperiate
given the context.
2025-07-05 18:46:01 +02:00
Samuel
5d051c0159 Merge branch 'main' into fix-custom-attribute-edit 2025-07-04 20:32:37 +02:00
Ian Abreu
8a69bdb0c4 correcting to use Tool vs. ToolController 2025-07-04 11:30:46 -04:00
Ian Abreu
2ec501f802 initial fix 2025-07-04 11:10:43 -04:00
tarman3
3836f8dbb9 CAM: Changes in warnings of old Array 2025-07-01 06:11:56 +03:00
Samuel Abels
59b73c08d3 CAM: Fix: rename vbit and threadmill back to v-bit and thread-mill to avoid backward compatibility issues 2025-06-30 22:59:14 +02:00
Samuel Abels
071747b376 CAM: Fix: shape parameters coming from the attributes section in the fctb file were not normalized 2025-06-30 21:48:21 +02:00
Samuel Abels
f952728809 remove unused import of PartGui 2025-06-30 21:30:34 +02:00
Samuel Abels
6464196d3a CAM: Fix: Tool editor ignored shape attributes if they were not in the Shape group. Now it reads all except Base 2025-06-30 20:27:54 +02:00
Samuel Abels
be16390773 CAM: make ToolBitShape more robust against invalidly typed parameters in toolbit files (e.g. Flutes with string value) 2025-06-30 20:27:26 +02:00
Samuel Abels
e23a01d8c6 CAM: Fix: Remove invalid normalization of shape name 2025-06-30 20:26:51 +02:00
Samuel Abels
55ed4e2e47 CAM: gracefully handle tool numbers that are strings in the tool library JSON 2025-06-29 21:39:04 +02:00
Samuel Abels
1f4799ecf4 CAM: Fix: ToolBitShapeCustom properties not editable if they had no type specified in the schema 2025-06-29 21:34:06 +02:00
Samuel Abels
f7038b9d64 CAM: fix toolbit editor shape resolution for high DPI displays 2025-06-29 13:15:47 +02:00
Samuel Abels
15b8dedc1c CAM: Fix: Tools without icon now display the thumbnail from the FCStd file 2025-06-29 12:57:32 +02:00
Samuel Abels
c69707a42f CAM: Fix: Chipload is not written to fctb file 2025-06-29 11:52:22 +02:00
Samuel Abels
7a614cb45a CAM: store tool quantities in user units, not metric 2025-06-29 11:52:07 +02:00
Samuel Abels
d19dcb2bcb CAM: Fix: custom shape attributes not showing in toolbit editor 2025-06-29 01:30:06 +02:00
sliptonic
79d22d1bd6 Merge pull request #22168 from Roy-043/CAM-fix-window-handling-in-ImageBuilder.py
CAM: fix window handling in ImageBuilder.py
2025-06-25 14:39:41 -05:00
sliptonic
76ff1b5e46 Merge pull request #22051 from tarman3/tagfixes
CAM: Dressup Tag some fixes
2025-06-25 13:03:10 -05:00
Roy-043
822999ba93 Update ImageBuilder.py 2025-06-24 20:30:46 +02:00
tarman3
8a0d3d2423 Merge branch 'main' into engrave 2025-06-24 08:14:59 +03:00
sliptonic
441d3742cc Merge pull request #21961 from knipknap/tool-cleanups
CAM: Some cleanups (moving DetachedDocumentObject around)
2025-06-23 15:02:24 -05:00
sliptonic
062f40d2b6 Refactor slot op. (#21799)
* Refactor slot op.
Move out of experimenation features

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Incorporate Hyarion's suggestions

* Update src/Mod/CAM/Path/Op/Slot.py

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-06-23 21:22:33 +02:00
LarryWoestman
f6842ebbf8 CAM: added command line arguments for finish label, (#21881)
output machine name, and post operation.
	With tests.
2025-06-23 10:45:19 -05:00
jffmichi
f829a09018 CAM: sort tool paths for Engrave and Deburr operation (#21531)
Co-authored-by: jffmichi <>
2025-06-23 10:22:21 -05:00
tarman3
91cc7c37e5 CAM: Custom gcode - Improve error messages (#21509) 2025-06-23 10:05:01 -05:00