kindred/create
1
1
Fork 0
Code Issues 31 Pull Requests 1 Actions 6 Packages Projects 9 Releases 2 Wiki Activity
28,811 Commits 41 Branches 6 Tags
03c56616907bd6fc75f614baead7be3dc0427e6f
Commit Graph

2410 Commits

Author SHA1 Message Date
Russell Johnson
03c5661690 Path: Relocate valueChanged signal translation to QSB class 
Moved the translation method from PathFeatureExtensionsGui module to proper location within QuantitySpinBox class in PathGui module.
This change adds a missing translation method for passing the `editingFinished` signal to the parent task panel when the user is finished editing a QuantitySpinBox object with an active expression in the Gui.
If no expression is active, this new method is dormant.

Some cleanup of initial changes related to development of this fix are included.
 2022-05-06 17:10:41 -05:00
Russell Johnson
477c912ad0 Path: Fix delayed extension length updates 
These changes allow for the extensions to be updated immediately upon changing either the Default Length expression or spinbox value, without having to click outside the spinbox.
 2022-05-06 17:10:40 -05:00
sliptonic
b97e141e01 Merge pull request #6796 from Russ4262/fix/3d_surface_opt_step_trans 
Path: Fixes #6775 - Check for end of range
 2022-05-05 09:55:52 -05:00
Russell Johnson
5321edca3c Path: Fixes #6775 - Check for end of range 
Change transition target point to last point at Safe Height if no more parts are available for processing.
 2022-04-25 21:50:10 -05:00
LarryWoestman
68d9afa58e Added a missing "continue". 2022-04-25 19:25:03 -07:00
sliptonic
27efdf9caf Fixes #6275 
Make PathPost emit tool controllers even if tool number is same.
 2022-04-10 10:15:17 -05:00
Markus Lampert
2b35d19ce4 Removed debugging globals 2022-04-04 21:12:45 -07:00
Uwe
2714e682db [Path] manual merge of #6580 2022-04-04 01:42:41 +02:00
sliptonic
cf867ae96d [Path] fix index error with PocketMode 2022-04-02 12:30:56 -05:00
Russell Johnson
a27c964279 Path: Correct PocketLastStepOver name 
Correct case of property name used
 2022-04-01 22:31:16 -05:00
sliptonic
5dff636cf8 Merge pull request #6605 from Russ4262/fix/misaligned_extensions 
Path: Fix some misaligned extensions [Bug]
 2022-04-01 09:30:49 -05:00
Russell Johnson
e5b52aebb2 Path: Fix some misaligned extensions 
This commit also corrects some wire extensions by trimming them with the source model.
 2022-03-31 22:33:58 -05:00
Russell Johnson
5e852b1791 Path: Correct method name spelling error 2022-03-31 22:10:07 -05:00
sliptonic
5505c59231 cleanup 2022-03-30 11:20:27 -05:00
sliptonic
6839d2235d Merge pull request #6662 from Russ4262/fix/import_gcode 
Path:  Fixes #6629 - Add missing Job for import G-code [Bug]
 2022-03-30 11:16:00 -05:00
Russell Johnson
e82283bd5b Path: Refactor insert() function and catch exceptions 
Path: Add method to verify dependencies for import
Path: Add label to Custom op referencing imported filename when available
Path: Fix module for command-line usage
 2022-03-29 20:57:31 -05:00
Russell Johnson
b1e4864910 Path: Allow GUI Job creation without task panel interaction 
These changes allow for a Job object to be created with view provider support, but without the initial task panel interaction at creation.

This is useful for scripting and other internal Job creation tasks.
 2022-03-29 20:57:31 -05:00
sliptonic
eaf9adeb0f [Path] minor tweaks to inspect 2022-03-29 18:38:14 -05:00
sliptonic
be44c979d0 minor fix 2022-03-29 17:46:49 -05:00
sliptonic
0d847fd482 Merge pull request #6657 from sliptonic/bug/leadinout 
Bug/leadinout
 2022-03-29 17:38:17 -05:00
sliptonic
d51608bce5 [Path] Fix initial descent at start 2022-03-28 16:30:41 -05:00
sliptonic
11156e2836 Merge pull request #6647 from Russ4262/fix/millface_face_region_no_base 
Path: MillFace - Fix Face Region with no Base geometry [Bug]
 2022-03-28 09:51:18 -05:00
sliptonic
1b5b6965cc remove pylint, commented code, and uncomment PathLogs 2022-03-28 09:46:20 -05:00
sliptonic
4e607304b9 Black reformat 2022-03-28 09:46:20 -05:00
sliptonic
bae73e0056 Changes from lcorley 2022-03-28 09:46:20 -05:00
sliptonic
460a95cabf Merge pull request #6659 from sliptonic/bug/profile 
[Path] Fixes #6658
 2022-03-27 10:58:41 -05:00
sliptonic
945c4c7ec5 [Path] Make tool controller set default spindle direction from tool attributes if it exists 2022-03-26 12:17:22 -05:00
sliptonic
d53a2ed34b [Path] Make 'forward' the default for spindle direction 2022-03-26 11:27:33 -05:00
sliptonic
895667bb49 [Path] Fixes #6658 2022-03-24 15:36:35 -05:00
sliptonic
c01a82e3b5 Merge pull request #6651 from sliptonic/bug/5956 
[Path] Fix # 5956.
 2022-03-24 09:05:39 -05:00
sliptonic
d4623baf0a Expose PocketLastStepOver property 
Property can be useful to fine tune the last stepover for some shapes
 2022-03-23 15:10:34 -05:00
Uwe
5496accd5f [Path] Fixes #5832 
Remove unused and confusing spiral and triangle patterns
 2022-03-23 10:35:58 -05:00
Russell Johnson
4821cbac54 Path: Fix Face Region with no Base 
This fix addresses an incorrect shape variable passed when Boundary Shape is set to Face Region and there is no Base geometry - indicating entire model to be milled.
 2022-03-22 18:16:31 -05:00
sliptonic
553554f936 Merge pull request #6612 from mlampert/bugfix/bag-of-minor-isssues 
PATH: Bugfix/bag of minor isssues
 2022-03-21 08:34:23 -05:00
Markus Lampert
d52fc71663 Blanket black formatting for Path python files 2022-03-20 13:23:48 -07:00
Markus Lampert
efc942a8f6 Fixed read-only state of quantity spin box when expression is 'clear'ed 2022-03-20 13:23:48 -07:00
markus
a23b610f41 Fixed setting a face's normal as the axis for model alignment 2022-03-20 13:23:48 -07:00
Russell Johnson
95cffaf502 Path: Simplify changes per developer conversations 
Also update TestPathDepthParams.py to reflect simplification of changes.
Remove some comments.
Employ `sorted()` function per MLampert suggestion
 2022-03-20 14:25:17 -05:00
sliptonic
afb3262118 simpler way to filter roughly equal depth values 2022-03-20 14:25:16 -05:00
Russell Johnson
3e6d542cd7 Path: Fix roughly equal depth entries 
Add code block to remove first of any two consecutive, roughly equal depth values (twin values).

Add two unit tests to support new code block and use cases.
 2022-03-20 14:25:14 -05:00
luz paz
8939e3a2eb Path: remove superfluous 'pass' per LGTM 
ref: https://lgtm.com/rules/910088/
 2022-03-19 20:06:48 -04:00
sliptonic
06959ededb Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui 
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
 2022-03-19 15:44:28 -05:00
Russell Johnson
b06389edb2 Path: Change action to warning with option for action. 2022-03-16 11:47:51 -05:00
Russell Johnson
70d5a422f7 Path: Correct comment spelling 2022-03-16 11:40:24 -05:00
Russell Johnson
e4286139db Path: Extend Job integrity check to GUI side, issue #6207 [Bug] 
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel.  If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.

Add check for existence of `SetupSheet` property of empty Job object.

These changes improve upon fixes in PR #5008 and related bug fixes.
 2022-03-16 11:40:23 -05:00
sliptonic
de94520d9b [Path] Warn user if enabling legacy tools 
Warn user if opening job that contains legacy tools
 2022-03-15 11:05:20 -05:00
sliptonic
b640a1d106 Merge pull request #6577 from Russ4262/fix/millface_removalshapes 
Path: Fix `self.removalshapes` declaration [Bug]
 2022-03-15 09:26:39 -05:00
sliptonic
a70adce220 Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup 
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
 2022-03-15 09:25:43 -05:00
sliptonic
75fee12d7b Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value 
Path: Fix inconsistent float type usage, issue #6170 [Bug]
 2022-03-14 09:26:24 -05:00
Russell Johnson
ac4c7bb954 Path: Fix self.removalshapes declaration [Bug] 
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty.  This moves the declaration up in scope to the method level.
 2022-03-12 22:34:03 -06:00