Commit Graph

108 Commits

Author SHA1 Message Date
sliptonic
06bea999d4 Fixes #6367
Use correct startpoint.
2022-02-15 09:48:16 -06:00
sliptonic
fee8660bcf Drilling translation cleanup 2022-01-22 13:11:46 -06:00
sliptonic
4d91ea271d rename function.
'job' has a meaning in Path.  sort_jobs doesn't sort jobs, it sorts hole locations.
2022-01-16 12:57:49 -06:00
sliptonic
8300c07767 Removed F words.
Various fixes from code review
2022-01-16 09:50:06 -06:00
sliptonic
fc2d6c172b Make CircularHoleBase use drillableLib
debugs

remove deprecated PathUtils.isDrillable

drillableLib cmake

make PathProfile use new drillableLib
2022-01-15 15:34:17 -06:00
sliptonic
5b23af3d4b Refactor PathDrilling to user generator
Uses the drill generator.
centralizes feed rate assignment
Tracks current machine position with MachineState
2022-01-15 15:27:53 -06:00
Russell Johnson
cfca2a790a Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
Russell Johnson
16015f66e3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
Daniel Wood
1bed2fff86 Use defaults for retract height
Use the StartDepth + SafeHeightOffset to calculate the retract height in relation to the hole start height.
2021-05-06 08:09:43 +01:00
Daniel Wood
e9de8d4e98 use correct feedrate for rapid moves 2021-05-05 20:33:26 +01:00
Daniel Wood
dc3e121580 Rapid to safe height above the hole 2021-05-04 14:06:30 +01:00
Daniel Wood
02e26061e3 fixes for drilling operation start depth 2021-05-04 13:41:50 +01:00
Russell Johnson
d52a96f2b5 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
43cd864f8f Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
luz paz
b75cd3dd52 Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
sliptonic
0ae842586e Merge pull request #3192 from Schildkroet/4th-axis-improve
[Path] 4th axis improve
2020-03-18 23:48:22 -05:00
Patrick Felixberger
3d1bd5f095 Code clean up 2020-03-16 18:30:30 +01:00
Russell Johnson
022c14d75b 4th-axis fixes and improvements
Fix rotational orientation of pockets.  Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
2020-03-14 11:36:21 -05:00
Patrick Felixberger
32231e4042 Merge branch 'millface-drilling-improvements' of https://github.com/Schildkroet/FreeCAD into millface-drilling-improvements 2020-03-12 00:01:20 +01:00
Patrick Felixberger
d4ba61bf77 Changed property names 2020-03-12 00:00:44 +01:00
Patrick Felixberger
fa58336c7c Clean up 2020-03-11 22:49:28 +01:00
Patrick Felixberger
c094889aac Fixed broken final depth calculation for rotational axis in pocket, profile and drill; Added EnableRotation to GUI; Fix some weird gcode generation 2020-03-11 21:16:21 +01:00
Schildkroet
9cf6c99951 Fixed wrong property name; Set default value 2020-03-11 07:45:02 +01:00
Patrick Felixberger
16c33fdb97 Removed 'Use Tip Length' and added 'Extra Offset' in Drilling OP 2020-03-09 22:34:41 +01:00
Patrick Felixberger
4545cf34b2 Added coolant support to grbl_post
Improved canned cycles

Added/translated comments
2020-03-03 21:27:31 +01:00
Markus Lampert
81f809cfcf Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Daniel Wood
bdcccc08b1 Add coolant feature to Ops 2019-08-28 19:40:08 +01:00
IMback
4f8af51864 Restore R parameter behavior 2019-08-08 19:29:26 +02:00
IMback
c8fda889a2 Peck retract height default changed from 10mm to opStartDepth+1
Peck depth default changed to tool dia*0.75
Fields changed to QuanitiySpinBoxes
Insure travel between regions is always performed at safe height
Make Peck and Dwell exclusive in GUI
Restore name of RetractHeight
Use SetupSheet for all numerical properties
2019-08-08 10:38:30 +02:00
Russell Johnson
4fc39dfb36 PathDrilling 4th-axis integration
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
sliptonic
b55c210f39 remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
sliptonic
4a984de243 Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
Russell Johnson
2e0861babc proxy to obj.Proxy partial conversion 2019-06-20 00:02:13 -05:00
luz.paz
aedb888ae3 Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Markus Lampert
ea84b18aee Operation settings support for Drilling. 2018-09-02 00:32:22 -07:00
Markus Lampert
ebe76319b8 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
070d17e4e4 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
04ea26a66a Fix for missing base class initialisation during creation. 2017-12-02 11:06:45 -08:00
Markus Lampert
a84a0ce431 Abort OP creation transaction if TC selection is aborted with cancel, #3274 2017-11-28 12:39:02 -02:00
pekkaroi
df1011d94f Path: Allow removing of all base objects in Circular hole tools 2017-11-21 17:19:57 -03:00
Markus Lampert
11db427b2e Fixed drilling depths and circular hole remove logic. 2017-09-28 11:27:47 -07:00
Markus Lampert
9f0ba77a54 Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
2642e668c5 Added location points for drilling to base framework. 2017-08-22 10:16:58 -03:00
Markus Lampert
d9272777a0 Fixed drilling tip length issue. 2017-08-22 10:16:58 -03:00
Markus Lampert
21f98304be Rebased Helix op on PathOp framework, also it's UI. 2017-08-22 10:16:58 -03:00
Markus Lampert
bddcb28424 Split base hole processing into separate class. 2017-08-22 10:16:58 -03:00
Markus Lampert
26b9c67da6 Split DrillingGui into its own file and base it off of PathOpGui. 2017-08-22 10:16:58 -03:00
Markus Lampert
f0c69cce02 Refactored PathDrilling operation using PathOp. 2017-08-22 10:16:58 -03:00
Markus Lampert
19f4e8a562 Fixed Apply button misbehaviour for drilling. 2017-08-22 10:16:58 -03:00
Markus Lampert
1c4dd19590 Removed Names and added support for ArchPanels again. 2017-08-22 10:16:58 -03:00