Commit Graph

58 Commits

Author SHA1 Message Date
Karliss
42790475d6 Add missing parent for messagebox and other popups
Unparented popups can easily get lost in backround, but they still block top level event loop when run with ::exec() thus preventing interactions with main window.  This mainly happens on wayland. Setting the parent ensures they are always kept on top and reasonably positioned.
2025-03-16 16:02:36 -05:00
Kacper Donat
13fbab9e42 Base: Move App::Color to Base
Every basic data type is stored in Base module, color is standing out as
one that does not. Moving it to Base opens possibilities to integrate it
better with the rest of FreeCAD.
2025-02-17 21:10:26 +01:00
Benjamin Bræstrup Sayoc
9a8bdbaf9f TechDraw: Use QStringLiteral 2025-02-10 18:32:44 +01:00
tritao
551c2e48fb Gui: Reorganize the selection files into a top Selection folder. 2025-02-03 17:56:57 +01:00
Benjamin Nauck
6f535f19fb Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
WandererFan
50f970efd7 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
PaddleStroke
cc393632e1 Techdraw: Smart Dimension: Fixes and simplifies code 2024-05-13 15:03:37 +02:00
PaddleStroke
41650a78d4 TechDraw: Implement 'Area' dimension. 2024-05-06 18:42:28 +02:00
PaddleStroke
8c5cfd23ec TechDraw: Improve Arc Length dimension tool so that it can do any edge length: arc of ellipse, bspline. 2024-05-06 18:40:46 +02:00
PaddleStroke
e3a5ef3504 TechDraw: Smart Dimension tool : Integrate chain and coord dimensions. 2024-05-06 18:40:46 +02:00
PaddleStroke
57bc4babea TechDraw: Implement smart dimension tool. 2024-05-06 18:40:46 +02:00
pavltom
966f584644 [TechDraw] Add new Insert Repetition Count command 2024-02-26 16:40:25 -05:00
wandererfan
de320363c9 [TD]use standard lines & LineFormat in extensions 2023-12-27 19:46:34 -05:00
wandererfan
023dd8ed8a [TD]fix location of CV on rotated views 2023-12-24 12:27:25 -05:00
Tomas Pavlicek
95fad03ee2 [TechDraw] Tree view update refactoring (#11815) 2023-12-23 08:06:58 -05:00
wandererfan
d836baacc2 [TD]fix missing translations 2023-07-02 09:18:06 -04:00
Chris Hennes
acf4cf2446 TechDraw: Translate some window titles 2023-06-04 09:59:53 -04:00
wandererfan
3a2b02ba58 [TD]fix fail on bad selection (#9598) 2023-05-19 19:07:48 -04:00
edi271
c9d9284fb1 Move getTrianglePoint to DrawUtil 2023-04-05 08:23:47 -04:00
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
Ajinkya Dahale
024114cb40 [TD] Explicitly call std::signbit
Snaps are failing because `signbit` isn't declared. Probably because of
42136ff0c48ae54edc48d1eff0cc9438f21e6786.
2022-10-11 11:56:40 +05:30
Uwe
a722122807 [TD] Gui, A*-C*: remove unused includes
- also sort includes
- also an addition to precompiled header
- TaskCenterLine: remove unused code that interferes with used code with the same name
2022-10-09 03:34:53 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
c5910c1530 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Uwe
7b4e5d7522 [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
0bf342b1d8 [TechDraw] Improve readability of commands 2022-07-09 13:07:30 -04:00
Wanderer Fan
031bca185d [TD]fix dimension special characters 2022-05-11 14:16:56 -04:00
Wanderer Fan
b9969abc70 [TD]add blank space for legibility 2022-05-11 14:16:56 -04:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
883012e4b0 TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
ae79d2155f [TD]update menu text and tip to std 2022-03-05 14:30:14 -05:00
Uwe
98692e4b63 [TD] CommandExtensionDims: remove unused includes 2022-02-28 01:42:39 +01:00
edi271
3b16914a9c Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
7efa2d69d5 Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
2a30032c7d New extension tool: cutomize format 2022-02-17 10:05:56 -05:00
edi271
4744ec5103 Force tree update 2022-02-17 10:05:56 -05:00
luz paz
6718d8797e Fix some typos and whitespace 2022-02-12 19:33:28 +01:00
edi271
5279eddc33 Issue Y-position of dim labels 2022-02-02 08:35:34 -05:00
edi271
d5177b09cc New tool remove prefix characters 2022-02-02 08:35:34 -05:00
Roy-043
af7d7f6b40 Update CommandExtensionDims.cpp
Modifications as suggested by Edi.
2022-01-26 08:48:42 -05:00
Roy
b974da4ea6 TechDraw: Ext. Tools: Improve menu texts and tooltips 2022-01-26 08:48:42 -05:00
edi271
d7357410a2 [TD] add right/left baseline in Parallel Dimension tools 2022-01-21 11:22:40 -05:00
luz paz
b686a51bc3 TD: fix 'praefix' typo in source and source comments 2022-01-12 14:50:39 -06:00
luz paz
6394fed4e6 Fix various typos
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2022-01-12 14:50:39 -06:00
Uwe
2db409659e [TD] coding style fixes for new extensions
all done by MSVC

I do this since on one hand the readability is in this case really improved and because whenever I made a change, MSVC tries to fix the style and then the diffs are unnecessarily large. Also the MSVC style is almost what we use as the "standard" coding style.
2022-01-07 21:35:46 +01:00