Commit Graph

87 Commits

Author SHA1 Message Date
Roy-043
42a74daa19 Arch: improve context menus (rebase) 2023-01-12 22:54:09 +01:00
ebrahimraeyat
c3e724d78d Removing Unnecessary if conditional check 2022-08-15 07:15:05 +04:30
luzpaz
d35400aae3 Arch: Fix 'testing inequality to None' syntax (#7274)
* Arch: Fix 'testing inequality to None' syntax 

- Substitute `is not None` for `!= None`
-Trim trailing whitespace on touched files
2022-07-30 00:28:20 +02:00
Roy-043
bafe141745 Arch: Housekeeping: import translate from correct file 2022-07-21 10:17:03 +02:00
Yorik van Havre
651f6d871f Arch: Fixed IFC import of Rebars 2022-04-05 16:06:22 +02:00
Yorik van Havre
b704454e33 Arch: Fixed placement of rebars in IFC export 2022-03-25 13:41:45 +01:00
Yorik van Havre
8cd345186a Arch: Misc bullet-proofing 2022-03-24 09:39:43 +01:00
Yorik van Havre
21b3a862f0 Arch: Fixed export of rebars without host to IFC 2022-03-22 11:59:28 +01:00
Yorik van Havre
95e1c97bb1 Arch: Fixed IFC export of rebars 2022-03-21 14:06:19 +01:00
Amritpal Singh
70ff9afa9d Arch: allow Rebar OffsetStart and OffsetEnd in negative also 2021-05-03 23:06:05 +05:30
Alex Young
79449b8ce9 Arch: removes unused imports
Removes unused imports as reported by LGTM.

There are exceptions: `import Arch_rc` is shown as an alert, but has side effects.  It's not clear what the best thing to do in those cases is, so I've left them for now.
2021-02-14 16:27:06 +00:00
luz paz
67381e9579 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
SurajDadral
03d273c656 Calculate length of rebar derived from Part::Helix 2020-09-08 15:50:23 +02:00
SurajDadral
1f15f04b17 Initialize mark and add compatibility for rebar.RebarShape
- Initialize rebar mark with rebar label
- Add compatibility for attribute rebar.RebarShape to work with changes
  done in this PR:
  https://github.com/amrit3701/FreeCAD-Reinforcement/pull/65/commits
2020-09-03 12:20:51 +02:00
SurajDadral
75ba0b8a77 Add Mark property to ArchRebar object
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=23&t=44580&p=418377#p418630
And required for reinforcement drawing/dimensioning.
2020-07-24 13:50:29 +02:00
Bernd Hahnebach
ff9c3be72b Arch: rebar, fix code error 2020-04-08 21:02:03 +02:00
Bernd Hahnebach
cf474f60ed Arch: rebar, allow to make rebars from an edge too 2020-04-08 14:38:17 +02:00
Bernd Hahnebach
7d8ab175a6 Arch: rebar, add error prints 2020-04-07 21:12:33 +02:00
luz.paz
8fb5c65736 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
a3e88a399f Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
vocx-fc
d506192b15 Arch: test for viewprovider before modifying rebar
Test for the existence of the ViewObject
before calculating interval and placement.

This allows running the TestArch from the command line
without error if there is no interface, that is,
```
freecadcmd -t TestArch
```
2019-11-17 12:57:41 -03:00
SurajDadral
c331ce29f1 Fix editing of OffsetStart of rebar object
Problem:
Unable to set OffsetStart value to greater than (size of structure
object along direction of expansion of rebars)/2 for rebar object

Solution:
Drop check if(OffsetStart + OffsetEnd > size)
2019-10-21 15:57:19 -03:00
SurajDadral
544e85ff3f Fix editing of single rebar object
Problem:
Unable to set OffsetStart value to greater than (size of structure
object along direction of expansion of rebars)/2 for single rebar object

Solution:
Drop check if(OffsetStart + OffsetEnd > size), when there is only one
rebar object.
2019-10-21 15:57:19 -03:00
Suraj Dadral
a6e410dae6 Set placement of bottom Stirrup
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=8&t=35077&start=100#p310036

<q>
While creating stirrups, if we set offset of tie to zero, then the
bottom stirrup will go out of column as in below image:
https://forum.freecadweb.org/download/file.php?id=84300

After modification, with same data, the stirrup in column looks
like:
https://forum.freecadweb.org/download/file.php?id=84301
</q>
2019-05-29 19:39:33 -03:00
luz.paz
0238906d38 Misc. typo and whitespace fixes
Found via `codespell`
2019-04-30 10:15:59 -03:00
Yorik van Havre
7c263899e5 Arch: Allow to make a rebar without host object from the GUI 2019-04-29 13:08:01 -03:00
Bernd Hahnebach
962e04b090 Arch: rebar, make it possible to create a rebar without existence of a Structure 2019-04-29 12:13:00 -03:00
Yorik van Havre
624e20e9a2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
Yorik van Havre
b533c64361 Arch: Fixed IFC export of rebars 2019-03-19 19:54:51 -03:00
Amritpal Singh
7cf8dc254e Fixed minor bug in Rebar object. 2018-09-11 14:34:59 +02:00
Amritpal Singh
dda6672d48 Fixed minor bug of custom spacing in Rebar object. 2018-09-03 11:08:53 -03:00
Yorik van Havre
5f63a7764b Arch: using basic object names for all arch objects 2018-07-07 14:40:10 -03:00
Yorik van Havre
e49a5af3ae Arch: separate properties creation in own methods and check properties at file load 2018-06-01 19:36:35 -03:00
Yorik van Havre
30476e951d Arch: Renamed Role property to IfcRole 2018-05-11 12:01:55 -03:00
Yorik van Havre
b5ffabace2 Arch: All Arch objects can now have any IFC type(role) 2018-05-10 10:42:06 -03:00
Yorik van Havre
c360263582 Arch/Draft: Make sure an active doc exists before creating objects 2018-05-08 16:07:55 -03:00
luz.paz
505488c4f9 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
looooo
7da2d6ebbc py3: rebar-fix 2018-04-22 07:53:20 +02:00
Yorik van Havre
7101d9a89d Arch: small bugfix in Rebar 2018-04-10 14:39:53 -03:00
luz.paz
6b04f8961e Arch: removing \n from translated strings
ref: https://crowdin.com/translate/freecad/548/en-hu#6501126
2018-02-07 09:42:13 +01:00
Amritpal Singh
c46893d537 Added TotalLength property in rebar object 2017-11-14 10:06:39 -02:00
Amritpal Singh
9017f18523 Added Length property in Rebar object 2017-11-14 10:06:39 -02:00
wmayer
85d0369c0a ArchCommands.fixDAG has been removed in the past and now fails the unit tests 2017-10-19 14:13:36 +02:00
luzpaz
409f5186ca Arch: typo fix
continuation of #953
found today in https://crowdin.com/translate/freecad/6766/en-ja#6499525
2017-08-28 17:31:18 -04:00
Yorik van Havre
0942c150e9 Arch: Renamed Rebar -> Custom Rebar 2017-08-18 20:57:43 -03:00
Yorik van Havre
6c4bdf24df Arch: Better tangent calculation fo rebar profile 2017-08-09 14:59:21 -03:00
Yorik van Havre
54a8b922b7 Arch: Added Centerline display mode to rebars 2017-07-24 17:54:21 -03:00
Yorik van Havre
ebb8fc5364 Arch: Store rebar base wires 2017-07-21 10:56:55 -03:00
Amritpal Singh
4e145b23b9 FIXES: minor bug in custom spacing of rebar object 2017-07-20 16:19:56 -03:00
Amritpal Singh
3aab7ffce5 Introduced custom spacing property in the Rebar object 2017-07-07 13:23:55 -03:00