Commit Graph

28604 Commits

Author SHA1 Message Date
Chris Hennes
0740d9a006 Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
Adrián Insaurralde Avalos
7502f1f96d PD: improve hole dialog layout (#14031) 2024-06-24 10:44:13 -05:00
mosfet80
5f38b52114 [MOD:PART] removed unused parameter (#14252)
d variable are never used

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-06-24 10:41:39 -05:00
Chris Hennes
3bf4f00092 Merge pull request #14079 from Ondsel-Development/sk_bspline_ovp
Sketcher: BSpline DSH: implement OVP/widget
2024-06-24 10:38:15 -05:00
CalligaroV
b8cf43424e Sketcher: fix external edges selection
* fix selection from Sketcher Task Panel
 * fix selection from 3D View
 * Synchronize selection between Task Panel and 3D View

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-06-24 10:35:54 -05:00
Roy-043
00fc3ec96a BIM: fix BIM_Setup unit system issue
Fixes #14675.

Note that I would prefer to use the FEM unit system (always mm). BIM_Setup does not support that, and this PR does not change that.
2024-06-24 15:42:27 +02:00
Yorik van Havre
2d231469ce BIM: Simplificed BimViews.getTreeViewItem - fixes #14321 2024-06-24 15:38:34 +02:00
Roy-043
f235513a49 BIM: fix SwitchWB preference by switching to BIM WB
Fixes #14680.
2024-06-24 10:43:08 +02:00
Roy-043
ee2652b550 Draft: remove code related to obsolete Std_MeasureDistance objects
The Draft_Dimension command could convert Std_MeasureDistance objects. These have recently become obsolete. This PR removes the related code.
2024-06-24 10:31:03 +02:00
Roy-043
e07c914f44 Draft: Remove Draft_Fillet chamfer recalculation
If two straight edges were selected the chamfer distance would be recalculated so that the length of the straight segment would be equal to `r` (the radius entered by the user). But this was, and is, not done if one or both edges are arcs.

By removing the recalculation code the endpoints of the straight chamfer edge now always match the endpoints of the fillet arc that would be created for the same radius. This also matches the fillet/chamfer behavior in for example Part and Sketcher.
2024-06-24 10:08:45 +02:00
Max Wilfinger
ce181eb15c Rename OVP preference options 2024-06-23 12:29:19 -05:00
wandererfan
55515b1e7f [TD]allow template fields to re-apply autofill 2024-06-23 09:48:25 -04:00
wandererfan
cb2573844f [TD]allow manual update of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
668a6ea010 [TD]correct source of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
1bc72ce3bb [TD]clean up editable field length and click area 2024-06-23 09:48:25 -04:00
wandererfan
1b669ee7b5 [TD]fix wrong xml namespace in some templates 2024-06-23 09:48:25 -04:00
bgbsww
8675aa87b4 Toponaming: Check for selection mapped element name 2024-06-22 17:10:54 -05:00
Chris Hennes
8432c65e21 Merge pull request #14771 from marioalexis84/fem-python_base_class
Fem: Create own base class for Python objects - fixes #14637
2024-06-22 13:13:14 -05:00
jffmichi
1c9d71502a Path: replace import of PySide2 with PySide 2024-06-22 08:17:16 -05:00
sliptonic
2c9b7db705 fix regression with adding TC to job 2024-06-22 08:16:33 -05:00
sliptonic
cb23383526 Fixing 'red ink' bugs in CAM
fixes:  https://github.com/Ondsel-Development/FreeCAD/issues/93
fixes https://github.com/Ondsel-Development/FreeCAD/issues/87
fixes https://github.com/Ondsel-Development/FreeCAD/issues/88


fix threadmilling error if not proper tool
fix vcarve error if no proper tool
fix probe error if no proper tool
fix deburr error if no base geometry
Fix adaptive op error if no base geometry
2024-06-22 08:16:33 -05:00
sliptonic
c9db224412 fixes #14765 (#14814) 2024-06-22 08:15:25 -05:00
marioalexis
863668ecd4 Fem: Remove selection observer - fixes #14001 2024-06-21 19:28:12 -05:00
marioalexis
3a08324f92 Fem: Create own base class for Python Material objects 2024-06-21 19:26:18 -05:00
marioalexis
449f9b9be8 Fem: Create own base class for Python Mesh objects 2024-06-21 19:26:18 -05:00
marioalexis
2bb2160fa2 Fem: Create own base class for Python Element objects 2024-06-21 19:26:18 -05:00
marioalexis
b485c3fcd6 Fem: Avoid unnecessary method overriding 2024-06-21 19:26:18 -05:00
Chris Hennes
bac074e37d Addon Manager: Remember scroll position on Back (#14753)
* Addon Manager: Remember scroll position on Back

* Addon Manager: Linter cleanup
2024-06-21 14:53:56 -05:00
PaddleStroke
eb90d295aa Assembly: Remove unecessary import that was breaking ubuntu CI. 2024-06-21 10:18:19 -05:00
wmayer
1a84404515 MSVC: Fix compiler warnings
* avoid redefines in Assembly
* explicit cast from size_t to int
* remove unused variables
* avoid implicit cast from double to float
* in test cases replace EXPECT_FLOAT_EQ with EXPECT_DOUBLE_EQ or EXPECT_NEAR when doubles are used
2024-06-20 15:42:16 -05:00
wandererfan
24c1aaf148 [TD]fix weld symbol position 2024-06-20 09:08:32 -04:00
Yorik van Havre
e556bccf52 BIM: Added square and rectangular profiles to pipes 2024-06-20 14:09:06 +02:00
Yorik van Havre
9c2a63e518 BIM: IFC: Export non-solids as Breps 2024-06-20 14:06:22 +02:00
Yorik van Havre
8b55579995 BIM: Fix Copy tool stealing copy mode 2024-06-20 14:06:01 +02:00
Roy-043
4699f6546d Draft: Add type check to Draft_Join
Add a type check for the selected objects. All must be Draft Wires.

Fixes #14727.
2024-06-20 14:05:21 +02:00
Lukas Schattenhofer
6783a270b4 BIM: ArchComponent Only counts planar surfaces as vertical areas 2024-06-20 14:03:23 +02:00
Roy-043
e34385cb33 Draft: Fix 2 issues to make Draft_Fillet handle arcs properly
Fixes #11435

Draft_Fillet could already handle arcs, provided they were not Draft_Arcs. The `_extract_edge` function in make_fillet.py had a strange logic, and could also return a wire which would result in problems later.

Another issue was that the `fillet` function in fillets.py did not handle the order of the edges correctly if one of the edges was an arc and the other a straight edge. The arch had to be selected first to prevent this error.
2024-06-20 14:00:42 +02:00
Roy-043
a835c64805 BIM: Fix base edge direction for Arch_Stairs
Fixes #14377

If the base edge of a stairs has a delta Z, the start point must have lowest Z. The `makeStraightStairsWithLanding` code fails otherwise.

Using `edge = Part.LineSegment().toShape()` is not the most efficient, but matches the pattern used elsewhere in the code.
2024-06-20 13:57:19 +02:00
Roy-043
b9b517316c Draft: Fix onChanged in view_point.py
Fixes #14804

Added (also don't make sense for a point object):
* AngularDeflection
* DrawStyle
* Pattern
* PatternSize

Removed:
* DiffuseColor (property no longer exists)
* LineMaterial (already hidden by default)
2024-06-20 13:46:00 +02:00
wmayer
127f935711 Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
1af1fc6b27 Merge pull request #14773 from wwmayer/fix_fem
FEM: Fix linking errors & clean-up code
2024-06-18 18:41:01 -05:00
wmayer
d1e2d15b37 Fem: Clean-up code 2024-06-18 19:58:16 +02:00
wmayer
301b239767 Fem: Refactor DefineNodesCallback and DefineElementsCallback
Refactor the two methods to reduce code duplication.
2024-06-18 18:48:14 +02:00
wmayer
a2939767ce FEM: Fix linking errors
The static members of FemSetElementNodesObject are not defined in Fem but FemGui which the MSVC compiler doesn't like.
Furthermore it's a code smell to make them public and static and they are not even used by the class itself.
2024-06-18 18:14:10 +02:00
wmayer
b8905ff87e Fem: Fix copyright notices
Do not clutter copyright notices with changes made to a file. That's the task of the VCS
2024-06-18 18:01:22 +02:00
wmayer
b56e896f5d PD: Fix crash in ViewProviderBody::unifyVisualProperty
Make sure that the view provider of a body feature provides the requested property
2024-06-18 10:41:41 -05:00
Chris Hennes
c601438b71 Fem/Sketcher: Fix missing PreCompiled.h files 2024-06-18 08:05:32 -05:00
wandererfan
9334092c9f [TD]fix scene and tree selection sync 2024-06-17 19:31:56 -04:00
wmayer
31725303fe FEM: Fix several issues
* Move global (non-static) variables into anonymous namespace to avoid possible linking issues that may cause UB
* Fix compiler warnings
* Do not reinvent the wheel and use boost::to_upper_copy instead of own implementation
2024-06-17 19:57:04 +02:00
PaddleStroke
2b3215eeb5 Assembly: InsertLink: Use doc.Label instead of doc.Name because of bug of doc.Name not updating when file is saved. 2024-06-17 11:33:28 -05:00