Commit Graph

20266 Commits

Author SHA1 Message Date
wmayer
f384202b93 Part: [skip ci] make arguments const references 2020-11-03 13:12:23 +01:00
Abdullah Tahiri
916526b866 Sketcher: Documentation editorial change 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
947cd64b8b Sketcher: Improve documentation of SketchGeometryFacade and ExternalGeometryFacade 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
fb5e76992f Sketcher: Restrict ability to create empty GeometryFacade and ExternalGeometryFacade objects to Python 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
e9e8724cb1 Sketcher: Facade for geometry and external geometry extension 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
36e58956c3 Sketcher: Change GeometryFacadePy representation 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
868c2ada73 Sketcher: Separate ExternalGeometryExtension interface from class 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
74ff589fd0 Sketcher: Utility functions to simplify common operations with GeometryFacade 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
063e0a6767 Sketcher: Extend SketchObject Python Interface to get/set SketchGeometryExtension GeometryId (convenience interface) 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
d994e2fe3b Sketcher: Geometry Facade interface for Geometry and SketchGeometryExtension 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
e4f7d0f068 Sketcher: SketchGeometryExtension separation to interface 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
88e542b345 Part: Geometry extensions constness correction 2020-11-03 12:01:22 +01:00
Abdullah Tahiri
5c492f727c Part: Geometry - refactor py functions into class for code reuse 2020-11-03 12:01:22 +01:00
wmayer
2b50e59d48 Mesh: [skip ci] improve reading OFF mesh format 2020-11-03 11:15:37 +01:00
wmayer
53e440497c Mesh: [skip ci] improve reading OFF mesh format 2020-11-02 16:36:07 +01:00
alafr
5bf974a0e8 Draft: Conform to vocx-fc's review
- check for Part.Shape as it was before, to avoid any risk of breaking other tools
- change the order of Draft tests
2020-10-31 14:17:21 +01:00
alafr
6a299ac3f6 DraftGeomUtils: formatting
Restore a change from commit #97235de that i accidentally deleted during conflict resolution
2020-10-31 14:17:16 +01:00
alafr
e66ec4b659 DraftGeomUtils: import FreeCAD as App 2020-10-31 14:17:13 +01:00
alafr
163e2460b0 Fix missing import 2020-10-31 14:17:10 +01:00
alafr
3186ddd029 DraftGeomUtils: Doctstring formatting
Adress vocx-fc's review
2020-10-31 14:17:07 +01:00
alafr
2ae2129383 Draft: test for DraftGeomUtils.get_extended_wire 2020-10-31 14:17:05 +01:00
alafr
0feb039deb Arch Structure: multiple structures command icon 2020-10-31 14:17:02 +01:00
alafr
3f72d434c5 Arch structure : workflow with master sketch
* Add a command that creates multiple Arch Structure objects from a selected base, using each selected edge as an extrusion path. It creates one Arch Structure object from each edge. Therefore, the Arch Structure objects can then be individually edited if needed.
* Split the command Arch Structural System from Arch Structure. For backwards compatibility, the command Arch Structure will run the command Arch Structural System when the requirements for the Arch Structural System (Structure + Axis) are met.
2020-10-31 14:17:01 +01:00
alafr
fda4198ef0 Arch Structure: fix extrusion orientation 2020-10-31 14:16:59 +01:00
alafr
856063090d Arch Structure: fix the nodes default placement. 2020-10-31 14:16:58 +01:00
alafr
7f83d8f0b0 Arch Structure : use Edges as a Tool, add options
* New widget for Tool selection: this enables the use of some Edges and not only entire Shapes - it makes possible to build Structures from a master Sketch.
* Add option BasePerpendicularToTool : option to create multiple Structures with a single Base (profile), along different Tools (paths). A copy of the profile is created and aligned perpendicular to the path at it start point.
This can already be done with multiple Draft Clones attached using the "NormalToEdge" mode, but this new option will make it more straightforward and with less objects in the document.
* Group properties related to the Tool in a group "Extrusion Path"
* Add a readonly property ComputedLength (it will be needed in BIM schedules)
2020-10-31 14:16:56 +01:00
alafr
bac868a298 Draft: Add geometry functions for Arch Structure
* get_referenced_edges(property_value): returns the Edges referenced by the value of a App:PropertyLink, App::PropertyLinkSub or App::PropertyLinkSubList property.
* get_placement_perpendicular_to_wire(wire): returns the placement whose base is the wire's first vertex and it's z axis aligned to the wire's tangent.
* get_extended_wire(wire, offset_start, offset_end): returns a wire trimmed (negative offset) or extended (positive offset) at its first vertex, last vertex or both ends. For example:
            get_extended_wire(wire, -100.0, 0.0) -> returns a copy of the wire with its first 100 mm removed
            get_extended_wire(wire, 0.0, 100.0) -> returns a copy of the wire extended by 100 mm after it's last vertex
2020-10-31 14:16:50 +01:00
alafr
80736caa34 Arch Structure: fix multiple extrusions along path
Fix the exception when trying to copy a wire with FreeCAD.Vector constructor
2020-10-31 14:12:12 +01:00
alafr
f87ae4de08 Arch Structure: Refactor getExtrusionData
- group all `base, placement = self.rebase(baseface)` in one place
- group all normal calculations in one place
- fix placement of tool (bug introduced by my previous PR)
- allow multiple faces when face is created by FaceMaker
- remove unused code: if `len(obj.Base.Shape.Edges) == 1` is true, then there is a Wire and `obj.Base.Shape.Wires` should be also truthy
2020-10-31 14:12:10 +01:00
wmayer
c9c9ab9a6b PartDesign: [skip ci] minor cosmetic changes 2020-10-31 13:32:18 +01:00
M G Berberich
7f328ac376 [PartDesign] Dynamic hole cut-types
‣ Make countersink and counterbore on metric holes freely definable by user.

‣ Fixed the Naming of M1.6, M2, M2.5 and M3.5

‣ Added constructor for custom enums from Enums to PropertyEnumeration

‣ Put definitions of cut-types (counterbore/countersink) for
  screwtypes into json-files for easy modification.

‣ Allow users to put its own definitions in json-files in
  [UserDir]/Mod/PartDesign/Resources/Hole

‣ Contains several examples of cut-type definition json-files that are
  propably not production-ready.

This uses a local copy of nlohmann::json¹ to read json-files.

__________
¹ This is a very nice,header-only C++ library under the MIT License
  (https://github.com/nlohmann/json). I copied the single-file-version
  and the forward-declaration-header into …/PartDesign/App/ so no new
  dependencies arise.
2020-10-31 12:49:00 +01:00
M G Berberich
c66a6be944 [PartDesign] Hole countersink for metric
fix a problem with counterbore and countersink in PartDesign Hole feature.

It was not possible to custom define counterbores or countersinks if a
metric thread hole was selected.

Handle the cut-types None, Counterbore and Countersink euqal
regardless of type of thread and let the user customize:
None:        none
Counterbore: diameter and depth
Countersink: diameter and angle
2020-10-31 12:49:00 +01:00
sliptonic
8e4bc39194 Merge pull request #4006 from dubstar-04/TurningPartOperation
[Path] Add selection gate and set default turning diameter
2020-10-30 09:44:54 -05:00
wmayer
eefa7dd798 Part: [skip ci] After removing a knot check if the B-spline is still valid 2020-10-30 13:55:31 +01:00
wmayer
50b38cca84 Sketcher: [skip ci] avoid possible memory leak 2020-10-30 13:21:51 +01:00
wmayer
e425a6bfe5 Part: [skip ci] handle OCCT exception in GeomBSplineCurve::copy() 2020-10-30 10:54:25 +01:00
Daniel Wood
6be4352ea7 [Path] Tidy imports 2020-10-29 21:35:24 +00:00
Daniel Wood
e22de3bde1 [Path] PEP8 whitespace fixes 2020-10-29 21:29:25 +00:00
Daniel Wood
eb3fbc0f94 [Path] set the default max diameter 2020-10-29 21:27:32 +00:00
Daniel Wood
4ea4ad84ce [Path] PEP8 Formatting fixes 2020-10-29 19:55:45 +00:00
Daniel Wood
8418c014f5 [Path] Add TurnPart selection 2020-10-29 19:55:05 +00:00
Roy-043
bbddf0501c Draft: Draft_Dimension_linked_geometry_fix
Linked geometry was not handled if the selected edge started or ended at vertex zero.
2020-10-29 19:26:55 +01:00
Yorik van Havre
687f55e94f Arch: Added Text settings to SectionPlanes 2020-10-29 18:28:35 +01:00
Daniel Wood
13e76e32e0 Merge branch 'master' into feature/jobsetupplane 2020-10-28 17:19:10 +00:00
Daniel Wood
91f5f470f4 Reorder imports to match PEP8 guidance 2020-10-28 17:10:51 +00:00
Daniel Wood
766bfe9398 silence lgtm warnings 2020-10-28 17:09:49 +00:00
PRDC
cc0f147362 Update ClipPlane.py 2020-10-28 17:12:21 +01:00
Yorik van Havre
43596a68af Merged crowdin translations 2020-10-28 12:04:37 +01:00
Yorik van Havre
57fbb63b8d Updated ts files 2020-10-28 10:46:51 +01:00
Daniel Wood
532c05eeea PEP8 whitespace fixes 2020-10-28 06:50:04 +00:00