Commit Graph

2348 Commits

Author SHA1 Message Date
Markus Lampert
07f3e6c521 Added callback to colorExterior to also color 'interior' 2020-09-28 14:58:08 -05:00
Markus Lampert
952c94cb50 Added colorColinear and resetColor algorithms 2020-09-28 14:58:08 -05:00
Markus Lampert
f860339658 Added optional scaling factor to Voronoi construction. 2020-09-28 14:58:08 -05:00
Markus Lampert
94a44bcbfe Added scaling to micro meters 2020-09-28 14:58:08 -05:00
Markus Lampert
38ff7fcdae Added support for distances of edge end points. 2020-09-28 14:58:08 -05:00
Markus Lampert
926d254849 Added api calls for coloring all twins and coloring exterior edges and vertices. 2020-09-28 14:58:08 -05:00
Markus Lampert
5ad3bb17fd Added toGeom for curved edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
10e5fce11c Added geometries for vertices and linear edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
9ba8817382 Added support for voronoi cells 2020-09-28 14:58:08 -05:00
Markus Lampert
6fc2af2adc Added support for voronoi edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
27238c3813 Added python bindings for voronoi diagram construction and accessing the resulting vertices. 2020-09-28 14:58:08 -05:00
sliptonic
2921a0c64b Merge pull request #3861 from Russ4262/profile_reset_fix
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
2020-09-15 14:12:01 -05:00
sliptonic
6ab2b2e088 Merge pull request #3862 from Russ4262/pocketshape_fix
[Path] PocketShape - fix improper path generation
2020-09-15 14:09:57 -05:00
sliptonic
aa9bde8066 Merge pull request #3813 from xform3/feature/base_geometry_multi_object_select
[Path] Enable for selection of multiple objects in Base Geometry list
2020-09-15 13:54:54 -05:00
sliptonic
a723fd7cbe Merge pull request #3849 from Schildkroet/deburr+dressup
[Path] Fixed DeburrOp not moving to safe height
2020-09-15 12:48:33 -05:00
vocx-fc
b0f6920b4e Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
vocx-fc
645336ffd4 Path: add missing postprocessor to CMakeLists 2020-09-14 22:18:00 -05:00
wmayer
c3d35c65fe dxf: [skip ci] Coverity: Buffer not null terminated 2020-09-14 14:37:20 +02:00
Russell Johnson
fd3efcdbd7 [Path] PocketShape - fix improper path generation
Forum identification and discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49513.
2020-09-12 09:35:34 -05:00
Russell Johnson
47b27edd6d [Path] Fixes #4433 - Cut Side reset with certain Base Geometry changes
`Cut Side` value was hard-coded to reset when Base Geometry was empty.  This disallowed retention of the current value with changes to selected Base Geometry involving the clearing thereof.
Also restored fixed visibility to `Cut Side` option in Task panel editor per forum mention.
2020-09-12 00:24:25 -05:00
Patrick F
fb0ecda0e1 Fixed DeburrOp not moving to safe height 2020-09-07 01:30:32 +02:00
luz paz
5cd408687b Fix typos in various files [skip-ci]
Found via `codespell 2.0.dev0`  
```
codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-09-04 10:10:31 +02:00
luz paz
4344f6bc08 Fix typos in source comments
Found via `codespell`
2020-08-29 19:14:13 +02:00
Misha G
155e3c17c3 Enable for selection of multiple objects in Base Geometry list 2020-08-21 16:56:14 -04:00
luz paz
59e3ea096e Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
sliptonic
e813c5adfd Merge pull request #3763 from Russ4262/PocketShape_fix_t4411
Path: PocketShape - Fixes ticket #4411
2020-08-04 10:40:53 -05:00
sliptonic
5c67c40dbd Merge pull request #3751 from J-Dunn/master
Path: prevent added paths creating tool crash: fixed #4260
2020-08-04 10:40:13 -05:00
sliptonic
bfa8cbf8a6 Merge pull request #3706 from etrombly/emptyPath
[PATH] don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same.
2020-08-04 10:20:13 -05:00
Russell Johnson
c7d34929ad Path: Fix reference to undefined ns, and adjust comments
This `ns` fix might need further attention after testing.  The section to which it pertains deals with optimizing rotations between ops with similar rotational axes.
2020-08-02 13:27:32 -05:00
Russell Johnson
2528898cb5 Path: Fix the rotational LimitDepthToFace feature 2020-08-02 13:27:32 -05:00
Russell Johnson
986775ec1a Path: Fix InverseAngle feature
The `ReverseDirection` property is now hidden by default.  It should not be necessary due to recent implementation of `isFaceUp()` method.
2020-08-02 13:27:32 -05:00
Russell Johnson
0697686695 Path: PocketShape - Fixes ticket #4411
Existing code to determine if shape volume indeed existed, failed.
Added additional pre-check for existing edges in shape to determine if shape geometry indeed exists.
In forum:
[Ticket #4411 - Can only generate pocket once for this shape, then it fails.](https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49035).
2020-08-02 13:27:32 -05:00
sliptonic
4bfa602368 Merge pull request #3700 from etrombly/deletedFaces
[Path] handle makeOffset2D exception in path pocket operation
2020-07-28 11:50:27 -05:00
sliptonic
ed9c94d9b6 Merge pull request #3585 from gwicke/unified_region_experiments
Path: Area based unified projection implementation
2020-07-28 11:48:56 -05:00
J-Dunn
0c3006e77c prevent added paths creating tool crash #4260 #3028
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
2020-07-28 14:12:11 +01:00
sliptonic
c10275b439 Merge pull request #3689 from etrombly/edgesMatchShape
[PATH] fix pocket attribute error if edge cannot be flipped
2020-07-27 12:53:37 -05:00
wmayer
4dd32ce143 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
wmayer
47d570716c LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
d5d7d65bfc LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
Mark Ganson TheMarkster
0491fa4ab9 coverity issue cid 305102 2020-07-23 13:55:32 +02:00
Gabriel Wicke
5c6de6dd14 Path: Area based unified projection implementation
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
2020-07-21 18:34:09 -07:00
sliptonic
7202749809 Merge pull request #3709 from etrombly/3dSurface
[Path] fix two never ending while loops in PathSurfaceSupport
2020-07-21 10:58:48 -05:00
wmayer
433ec2d6e4 Coverity: Copied into fixed size buffer 2020-07-20 17:34:25 +02:00
wmayer
5919874437 Coverity: Invalid printf format string 2020-07-20 17:34:23 +02:00
wmayer
cbb5f99ade PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
Eric Trombly
fa8f3c2461 fix two never ending while loops in PathSurfaceSupport 2020-07-17 13:59:10 -05:00
Eric Trombly
8ab962ad85 handle offset error in PathPocketShapeGui 2020-07-15 21:31:34 -05:00
Eric Trombly
66b941b5fa handle makeOffset2D exception 2020-07-15 21:31:34 -05:00
Eric Trombly
465de60007 don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same. 2020-07-15 19:35:18 -05:00