Commit Graph

56 Commits

Author SHA1 Message Date
jonzirk76
025155fbe7 TechDraw: remove double type checking
Fixes #20131
2025-03-30 10:42:08 -05:00
Benjamin Nauck
45c997f40a Manual changes to improve isDerivedFrom usage 2025-01-27 16:08:19 +01:00
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
WandererFan
abb50a4daa [TD]Long and link dim refs (fix #13375) (#18641)
* [Meas]Changes for TD dimension refs for links

* [TD]App changes for dim refs to links

* [TD]Gui changes for dim refs to links

* [TD]fix 2 lint messages

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-23 17:36:22 -05:00
PaddleStroke
e657ce9473 TechDraw: Assembly exploded views : revert #17726 2024-12-16 11:22:26 -06:00
wandererfan
8f8bdd5c93 [TD]add shape validation tool for debugging 2024-12-09 17:37:33 +01:00
Benjamin Bræstrup Sayoc
cdb92768fe [TechDraw] Return logic simplification (#16504)
* [TechDraw] AppTechDrawPy.cpp return logic simplification

* [TechDraw] CosmeticExtension.cpp return logic simplification

* [TechDraw] DrawBrokenView.cpp return logic simplification

* [TechDraw] HatchLine.cpp return logic simplification

* [TechDraw] LineGenerator.cpp return logic simplification

* [TechDraw] Preferences.cpp return logic simplification

* [TechDraw] ShapeExtractor.cpp return logic simplification

* [TechDraw] MDIViewPage.cpp return logic simplification

* [TechDraw] QGILeaderLine.cpp return logic simplification

* [TechDraw] QGIRichAnno.cpp return logic simplification

* [TechDraw] QGTracker.cpp return logic simplification
2024-11-18 16:14:47 -03:00
PaddleStroke
d9ec45b2f6 Techdraw: Fix assembly exploded view (#17726) 2024-11-11 17:53:34 +01:00
Eric Price
cf8ad66373 Fix boolean operations (#17119)
* add BRepAlgoAPI wrapper files to CMakeList

* introduce wrapper for BRepAlgoAPI_BooleanOperation and derivatives, set sensible default Fuzzyness for boolean operations

* allow default fuzzyness to be set in settings - including off

* backwards compatibility with OCCT 7.3.3 - removed newer paramateres from wrapper

* added missing header

* reverted src/Mod/Part/App/OpenCascadeAll.h to original state

* implement some changes suggested by @wwmayer

* removed unneeded destructor definitions

* moved getDefaultFuzzyValue into its own helper class

* removed unneeded references to base class default constructor

* default to SetRunParallel(Standard_True) as suggested by @FlachyJoe

* fixed license header as requested

* Added new method to autocalculate fuzzyness to BooleanOperation base class and use it for those parts that do not call the obsolete constructor but also do not set precision

* implemented static variable solution as suggested by @wwmayer

* added helix for test case

* Refactoring FCRepAlgoAPI to FCBRepAlgoAPI

* Added Test Case (fuse cylinder with helix with different working and non-working Fuzzy values)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* increased default value of FuzzyBoolean and made tests more robust for compatibility with OCCT 7.3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes for FREECAD_USE_PCH - allow testing of FREECAD_USE_PCH on linux with cmake switch (default OFF)

* removed surplus line - wasn't needed after all

* included precompiled as instructed

* set anti-corruption flag in boolean operations, ensures source shape is not damaged in OCCT 7.1 and higher

* fix #17085

* disable subtests that were too specific for now

* fixed all CLI tests - see comments in Pull Request https://github.com/FreeCAD/FreeCAD/pull/17119#issuecomment-2420772452

* Update src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* remove surplus tests from github suggestion interface bug

* hide the BooleanFuzzy variable - can now be only set by manually editing the config file
i
in FCParamGroup "Boolean"
<FCFloat Name="BooleanFuzzy" Value="10.000000000000"/>

* Suggestion by @FlachyJoe - add validity checks to the base and tool shape in any direct boolean op

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
2024-10-21 18:38:51 +02:00
bgbsww
8c08549f5a Update to Toposhape versions and fix shapebinder references with test (#16036)
* Update to Toposhape versions and fix shapebinder references with test

* Update src/Mod/PartDesign/PartDesignTests/TestShapeBinder.py

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-08-26 10:50:18 -05:00
luzpaz
9c6e78b5cb TD: Trim trailing newlines 2024-07-14 09:25:46 +02:00
PaddleStroke
ffa62cd52e TechDraw: Add support for Assembly Exploded Views 2024-05-06 18:32:00 +02:00
wandererfan
33a3c84d92 [TD]implement BrokenView 2024-04-06 15:25:23 -04:00
wandererfan
158ef7ee8f [TD]Revert detail to piecewise algo 2024-01-11 18:24:51 -05:00
wandererfan
18e62a731c [TD]prevent gp_GTrsf::Trsf() - non-orthogonal GTrsf 2023-12-21 17:32:16 -05:00
wandererfan
2a51d79afd [TD]fix double transform for linked objects 2023-12-21 09:46:09 -05:00
wandererfan
f9ea3bc072 [TD]fix Landmark dim with datum points 2023-12-20 19:33:00 -05:00
wandererfan
9cb4745f38 [TD]handle loose geometry via HLR 2023-12-03 08:55:59 -05:00
wandererfan
ca90c73811 [TD]trap null 2d shape in ShapeExtractor 2023-11-26 16:42:06 -05:00
wandererfan
69761e72d2 [TD]fix regression on Links with scale 2023-11-13 12:21:10 -05:00
Florian Foinant-Willig
24352a7f4c TechDraw: modernize type checking 2023-10-23 18:08:59 +02:00
wandererfan
ed72c03df3 [TD]fix sketch location in view 2023-10-03 13:35:36 -04:00
wandererfan
b45cb18ce1 [TD]fix inverted detail of body 2023-09-15 13:53:54 -04:00
wandererfan
a51e46775f [TD]fix 10013 detail of sketch 2023-08-20 12:25:12 -04:00
wandererfan
766a04e26e [TD]cleanup debug messages 2023-05-19 19:07:48 -04:00
wandererfan
176cdd45fe [TD]fix rotation of App::Link 2023-05-04 13:16:09 -04:00
wandererfan
0146d070e2 [TD]fix ShapeExtractor error
- recent changes caused ShapeExtractor to return only the
  first source shape encountered instead of gathering all
  source shapes.
2023-04-11 22:40:29 -04:00
wandererfan
84aa21329e [TD]clean up from recent preferences/return PRs 2023-04-11 22:40:29 -04:00
Benjamin Bræstrup Sayoc
3f81006ac4 [TechDraw] Simplify return logic
Normal warmup
2023-04-11 13:49:57 -04:00
Benjamin Bræstrup Sayoc
ef5fc4f237 [TechDraw] Simplify return logic 2023-04-10 23:34:05 -04:00
Benjamin Bræstrup Sayoc
15fe52a04b [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wandererfan
f5a7b499ce [TD]fix fail on transform of infinite shape
- passing an infinite shape to TopoShape::transformGeometry
  throws exception GeoConvert::Surface2BSpline() - infinite surface
2023-04-07 17:15:43 -04:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
5eae33e4e8 [TD] ShapeExtractor.cpp: fix whitespace 2022-10-06 02:45:00 +02:00
Uwe
a6c6344c6b [TD] P* - T*: remove unused includes
- also sort includes
- also additions to precompiled header
2022-10-06 02:36:48 +02:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
8304a0942e [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Uwe
93796e2d92 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Wanderer Fan
5abbfd7087 [TD]fix crash on body with no shape 2022-07-13 14:31:16 -04:00
Uwe
c5ed57c405 [TD] ShapeExtractor.cpp: add missing include 2022-07-03 21:54:39 +02:00
wmayer
23eb600774 TD: fixes warning: local variable will be copied despite being returned by name [-Wreturn-std-move] 2022-04-17 17:21:37 +02:00
Wanderer Fan
7c24e54704 [TD]skip LCS infinite shapes 2022-03-29 08:21:36 -04:00
Wanderer Fan
484ff4fafb [TD]fix handling of composite shapes 2022-02-12 08:12:50 -05:00
Aapo
9318c4c1f2 [TD] ShapeExtractor.cpp: Fix linked View source bug, link targets were translated but not scaled in TD. 2021-02-05 22:41:09 +01:00
Aapo
07211b0fb1 [TD] ShapeExtractor.cpp: Avoid processing infinite-sized shapes (Datum objects etc). 2020-12-22 17:46:19 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
45b755a596 Coverity: Unchecked dynamic_cast 2020-07-20 17:34:28 +02:00
wmayer
e9bc970c28 PVS: V522 There might be dereferencing of a potential null pointer 2020-07-18 10:59:27 +02:00
wandererfan
e537972ef9 [TD]GlobalPlacement for loose 2D objects 2020-04-13 09:43:21 -04:00