Commit Graph

2430 Commits

Author SHA1 Message Date
Syres916
08ee9fa728 Part/Toponaming: makeElementWires
* Added tests developed by Syres916
2024-06-26 10:46:36 -05:00
Chris Hennes
9d506e3bfc Merge pull request #14898 from bgbsww/bgbsww-toponamingSaveRestoreElementMaps
Toponaming: Fix save and restore of elementmaps
2024-06-25 09:58:59 -05:00
Syres916
c06cbce42c [PartDesign] Fix thread depth level not enabled unless clicked 3 times 2024-06-24 11:19:06 -05:00
Adrián Insaurralde Avalos
7502f1f96d PD: improve hole dialog layout (#14031) 2024-06-24 10:44:13 -05:00
mosfet80
5f38b52114 [MOD:PART] removed unused parameter (#14252)
d variable are never used

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-06-24 10:41:39 -05:00
bgbsww
aa66518568 Toponaming: Fix save and restore of elementmaps 2024-06-23 23:33:12 -04:00
bgbsww
8675aa87b4 Toponaming: Check for selection mapped element name 2024-06-22 17:10:54 -05:00
wmayer
b56e896f5d PD: Fix crash in ViewProviderBody::unifyVisualProperty
Make sure that the view provider of a body feature provides the requested property
2024-06-18 10:41:41 -05:00
xtemp09
2248fc7adb Fix crash described in 14370 (issue comment)
The crash occurs because
PartDesignGui::TaskDressUpParameters::setSelection was invoked with
nullptr.
2024-06-17 11:27:07 -05:00
wmayer
36b8639059 PD: Fixes issue #14598: FreeCAD crashes on Undo 2024-06-17 11:11:12 -05:00
Chris Hennes
101118fdde Merge branch 'main' into vp_texture_ext 2024-06-17 10:48:45 -05:00
wmayer
2b8cf894f7 PD: Fix Qt warning at runtime
QListWidget::item is not declared as Q_SIGNALS and thus cannot be used as sender in QObject::connect()
2024-06-16 22:21:01 -05:00
wmayer
636fa43c99 MSVC: Fix warnings and build failure 2024-06-12 10:36:58 -05:00
wmayer
3fd2f64639 Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
d88253c2a1 Fix several compiler warnings
* variable 'xAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'yAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'zAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* unused variable 'base' [-Werror,-Wunused-variable]
* unused variable 'extrude' [-Werror,-Wunused-variable]
2024-06-11 11:42:12 +02:00
Kacper Donat
86e07e9181 Gui: Fix use of no longer existing DiffuseColor property 2024-06-10 19:40:48 -05:00
Florian Foinant-Willig
b9dfc493b8 Fix can't pad a sketch on datum plane (#14397)
* Fix can't pad a sketch on datum plane

* Add a unit test for Pad a sketch on datum plane
2024-06-10 11:21:32 -05:00
Kacper Donat
988d31bed8 GUI: Add UI for Up To Shape feature
Add UI for Up To Shape feature and overall refactor of Pad / Pocket.
2024-06-10 18:05:21 +02:00
Kacper Donat
83cf2a17cd Gui: Refactor DressUp VP to use setHighlighted*
This refactors DressUp VP a bit so it does no longer store original copy
of original faces colors to properly support selection, but uses
highlight methods provided by the base class. It simplfies code a bit
and ensures coherent behavior.
2024-06-10 18:05:21 +02:00
wmayer
707b0e6264 Fix compiler warnings 2024-06-04 20:23:19 +02:00
Chris Hennes
7abadaf7f3 Merge pull request #14485 from bgbsww/bgbsww-toponamingFixDressUpShadowSubs
Toponaming fix dress up shadow subs
2024-06-03 21:01:22 -05:00
bgbsww
617e63bc23 Toponaming: reformat code 2024-06-03 19:29:01 -04:00
Florian Foinant-Willig
7ffddb6f7d PD Extrude up to multiple faces or shape 2024-06-03 11:26:19 -05:00
Chris Hennes
6404de9c21 Update translations 2024-06-03 11:04:42 -05:00
Chris Hennes
5f601eb6c7 Merge pull request #12589 from NomAnor/pd-trans-body
Add a new mode to PD patterns that will transform the base feature's shape instead of the tool shapes
2024-06-03 10:46:33 -05:00
Chris Hennes
f331c91b89 Merge pull request #13317 from Ondsel-Development/add-prop-varset
Core: Add properties to variable sets
2024-06-03 10:34:57 -05:00
Zheng, Lei
a926cd41b3 Toponaming: update TaskDressUp addAllEdges 2024-06-03 11:22:55 -04:00
bgbsww
a495280693 Toponaming: fix bug with points in sketches 2024-06-01 22:57:31 -05:00
David Carter
5feb963f9d Material: Appearance Updates 2
Improves the use of the ShapeAppearance property for the Part workbench.

    removes DiffuseColor property
        adds Python compatibility using custom attributes
        transitions DiffuseColor to ShapeAppearance on open
    Improved UI elements for setting object appearance, and appearance per face
    Lays the foundation for future texture support
2024-06-01 19:57:16 -05:00
bgbsww
c4d0f3ed97 Toponaming: Restore use of AttachmentSupport 2024-06-01 11:49:58 -05:00
wmayer
3e23bd759b Mod: Fix several compiler warnings 2024-05-30 08:55:11 +02:00
wmayer
560cab6f31 clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
André Althaus
cd3bda3845 Fix signal for Qt < 5.15 2024-05-28 13:48:48 +02:00
André Althaus
b42d56bb3b Replace combobox with radio buttons 2024-05-28 09:34:08 +02:00
Max Wilfinger
03cab3d1fc Revert UI command change in Sketcher and PartDesign 2024-05-27 11:51:02 -05:00
Max Wilfinger
a6e8fa4bb1 Adjust shaft wizard icon to match other Part Design icons 2024-05-27 11:24:21 -05:00
Chris Hennes
063499a9d4 Merge pull request #14202 from bgbsww/bgbsww-toponamingFixSubShapeBinder
Toponaming fix sub shape binder and restore multishape tests
2024-05-27 11:19:31 -05:00
Chris Hennes
764dc4cc31 Merge pull request #13968 from marcuspollio/UI-TaskPanels-cleanup-1
UI : Task panels cleanup - Sketcher and Part Design headers
2024-05-27 10:56:07 -05:00
David Carter
a0fdc86948 Material: Appearance and Material inspectors
Dialogs to view the Appearance and Material properties of an object

These inspectors are intended to be used when debugging Appearance and
Material issues in a model.

The Appearance inspector displays the appearance properties of an
object. This will be more useful once PR 13792 is merged which migrates
parts to use ShapeAppearance instead of DiffuseColor. This shows each
of the appearance properties per face for the object.

The Material inspector shows the material, models, and properties
assigned to a model. It displays useful debugging information such as
the UUID and file paths associated with eacch of the items. This is
useful when finding and resolving model conflicts.

The material inspector now gives the option of copying the information
to the clipboard.
2024-05-27 10:50:35 -05:00
Chris Hennes
73ae4102e6 Update translations
Arch->BIM is a WIP
2024-05-25 19:11:51 -05:00
Zheng, Lei
3c112b466d Toponaming: Missing code for shapebinder 2024-05-23 09:47:25 -04:00
André Althaus
099e33a77f Remove feature selection dialog for transformed features
The dialog is no longer necessary because without a selection the
transformed features default to "Transform body".
2024-05-23 12:40:41 +02:00
André Althaus
40a1487cb5 Set TransformMode to "Transform body" if no features are selected on creation of transform features 2024-05-23 12:23:32 +02:00
André Althaus
ebad053c70 Change MultiTransform child detection to the previous method
isMultiTransformChild() tried to do a better job by checking
for a parent MultiTransform in the dependency list, but this
is unusable during initialization, when these dependencies are
not established.

The method is changed back to the previous one which only checks for
default property values. This will give false results during
initialization but not cause problems.
2024-05-23 12:23:32 +02:00
André Althaus
f4aa5879cc Fix solid feature detection for "Transform Body" mode
Because the Origins property is empty in "Transform Body" mode, the
features are detected as not solid.
This messes with the feature order on insertions and moves.

This is fixed by calling the isMultitransformChild() method of the
Transformed features instead of checking the Origins property in the
Body code.
2024-05-23 12:23:32 +02:00
André Althaus
f021ea6c7f Fix ambiguous setValue() call 2024-05-23 12:23:32 +02:00
André Althaus
f2c3ade1f5 Remove unused function 2024-05-23 12:23:32 +02:00
André Althaus
5c0aaa40d9 Modernize code 2024-05-23 12:23:32 +02:00
André Althaus
75bba376c4 Format code with clang-format 2024-05-23 12:23:28 +02:00
André Althaus
98d46c41be Add a combo box to the transform featues UI for the TransformMode 2024-05-23 12:22:26 +02:00