kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
37,918 Commits 41 Branches 6 Tags
08ee9fa72814ee7fd3019ee69a53e9018e2f009c
Commit Graph

914 Commits

Author SHA1 Message Date
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
5fa05ab83d Mod: Redundant_string_initialization 2022-08-08 16:52:42 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
47ac049e14 Mod: use emplace_back 2022-08-05 10:36:16 +02:00
wmayer
a93082bc06 PD: [skip ci] Fix several clazy issues: 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
 2022-07-25 13:40:19 +02:00
adrianinsaval
76f5c32574 [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode (#7216) 
* [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode
 2022-07-20 03:13:01 +02:00
Uwe
aca9973791 [PD] [skip CI] FeatureExtrude.cpp: fix a comment 2022-07-19 03:30:48 +02:00
Uwe
24468b59ad re-add some nullptr 
to be safe since their removal within assert() or bools might have some impact I don't know
 2022-07-18 02:32:36 +02:00
Uwe
dfecb337e7 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
b16f03ec02 [PD] add parameter enabling logic for pad/pocket 
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
 2022-07-18 00:26:15 +02:00
Uwe
ac6235c577 [PD] App: remove superfluous nullptr checks 
- also Body: get rid of some nasty single-letter variables
 2022-07-17 18:07:00 +02:00
wmayer
da70aa2dc6 PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
wmayer
423aaccd3f PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
wmayer
b6494085b4 Part: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:31:10 +02:00
Uwe
596877584d [PD] FeatureDressUp.cpp: add missing include 2022-07-03 21:20:01 +02:00
Uwe
61edc1c0d8 [PD] Hole initialization bugfix 
- by default there is no hole head cut and therefore its parameter must be initialized as read-only (will be enably when user sets a head cut)

- also fix a typo

- also fix a UI file issue (automatically done by Qt Designer)
 2022-06-25 16:36:50 +02:00
andrea
c66aadeb60 removed references to OCC<7 2022-06-25 14:29:24 +02:00
wmayer
3e6d0e775f PD: allow to clear the shape when nullifying the Support property 2022-06-12 14:01:19 +02:00
wmayer
d92c018eb6 PD: fixes #6451: Face color of PartDesign Body not exported to STEP 2022-05-24 16:42:27 +02:00
Ajinkya Dahale
ed370b5fe6 [PD] Do both fuse and cut in FeatureTransformed if applicable 2022-04-23 17:55:18 +02:00
Ajinkya Dahale
cad2d2c95b [PD] Delete "Overlap" property for FeatureTransformed 
This property became redundant after 9b17ab4a58476f46802179de037a627974cb892b.
 2022-04-21 01:21:59 +02:00
wmayer
d4aed4c6bd PD: issue #6641: polar pattern fails 2022-04-12 16:32:54 +02:00
Uwe
153fa35bdb [PD] shape binder: code style improvements 
all done by MSVC
 2022-03-27 21:48:09 +02:00
Uwe
8a8fe98454 fix some occurrences where size() is misused as Boolean 
- as suggested by @wwmayer: 70714eedc9 (r69648152)
 2022-03-27 21:38:15 +02:00
wmayer
de2d55cacb PD: include header with export macros 2022-03-24 21:09:19 +01:00
wmayer
d21a60b294 All: modernize C++11 
* replace deprecated headers
 2022-03-23 22:44:18 +01:00
Uwe
f6cb87f8c4 [PD] fix #6482 
The idea with the large factor, introduced in #5363 fixed real bugs, so it should not be reverted.
However we must compensate the factor at the path position movement. Otherwise we get wrong helix positions when the angle is negative.

The PR was tested with the files in the bug reports:
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136
https://forum.freecadweb.org/viewtopic.php?p=572618#p572618
 2022-03-23 19:29:02 +01:00
wmayer
d1d4b996e7 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
Uwe
644d3920d3 [PD] remove unused Xerces 2022-03-20 20:43:02 +01:00
wmayer
585bcb8708 lgtm: [skip ci] FIXME comment 
Change FIXME or remove it
 2022-03-20 16:51:23 +01:00
Uwe
3d26a81b36 [PD] remove Python.h from headers 
seems not to be necessary anymore
 2022-03-20 14:16:41 +01:00
wmayer
0f9768fb33 Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
wmayer
09259451d2 PD: Fix coverity issue: 
* CID 350645: Uncaught exception
 2022-03-13 17:24:07 +01:00
wmayer
afabaea5cb PD: Fix several coverity issues: 
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
 2022-03-13 12:10:01 +01:00
mwganson
eaf36231eb PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Zheng, Lei
2a28ad5cef PD: add SubShapeBinder 'Refine' property 
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
 2022-03-12 02:45:13 +01:00
Zheng, Lei
8d6b06bc86 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
53ab49b1fd [PD] Boolean: re-add necessary include 2022-03-02 02:50:46 +01:00
Uwe
e587beb02b [PD] Boolean: remove unused include 2022-03-02 02:30:28 +01:00
mosfet80
c181da4461 PD: remove duplicate verifications 2022-03-01 17:41:09 +01:00
wmayer
d42b9a2fe1 PD: fix const correctness in ProfileBased 2022-02-28 18:10:58 +01:00
wmayer
59886896dc PD: [skip ci] refactor Hole feature 2022-02-26 17:06:38 +01:00
wmayer
aeba940cf0 PD: [skip ci] refactor Hole feature 2022-02-26 16:48:37 +01:00
wmayer
52b936539f PD: [skip ci] fix const correctness in Hole feature 2022-02-26 16:34:44 +01:00
wmayer
2e16f6a7e1 PD: [skip ci] refactor Hole feature 2022-02-26 16:18:20 +01:00
wmayer
08a3b60031 PD: fix error 'gp_Dir::Crossed() - result vector has zero norm' 
As reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=65826
 2022-02-26 16:07:35 +01:00
Uwe
da9c18374b [PD] final work to remove unused includes 2022-02-22 02:18:49 +01:00
Uwe
7b7a0aa4bf [PD] remove some more unused includes 2022-02-21 15:13:54 +01:00
Uwe
1d58c674a2 [PD] some more work to remove unused includes 2022-02-21 02:50:16 +01:00