Commit Graph

36 Commits

Author SHA1 Message Date
wmayer
622e46771e PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
dfecb337e7 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
wmayer
d1d4b996e7 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
7acdcbd031 PD: Fix several coverity issues:
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
2022-03-13 16:32:19 +01:00
Uwe
037b2796b3 [PD] Hole, Pipe and Revolution: remove unused includes 2022-02-19 18:47:26 +01:00
wmayer
8db8126dd5 PD: move ReferenceHighlighter to Part module 2022-01-18 18:24:02 +01:00
wmayer
b2b86477a5 PD: use class ReferenceHighlighter inside ViewProviderPipe 2021-12-13 15:58:55 +01:00
wmayer
d360917583 PD: 0004742: Editing features by context menu may not be undoable 2021-12-06 14:11:10 +01:00
0penBrain
ffa6b3ce5e [PartDesign] Remove useless function overriding
Double-click is already handled by PartDesign::ViewProvider::doubleClicked()
 Overridings in Loft & Pipe brings no specific behavior
 By removing overridings, behavioral consistency is improved both in ...
 ... undo commands & body activation management when PartDesign items ...
 ... are double-clicked
2021-10-29 17:30:06 +02:00
David Osterberg
ec51691a43 PartDesign: Fix broken outdated icon filenames
This fixes some cases that were missed in commit 1814270d53afd1c51c
2021-02-12 17:46:27 +01:00
Abdullah Tahiri
4facab0936 Gui: Colorful/Greyable overlay status in icons
===============================================

Before this implementation, specific status via former mergeOverlayIcon() was greyed out
with the visibility.

With this commit, the developer has two options:

a) override mergeGreyableOverlayIcons, in which case the overlay will
be greyed out when the item is greyed out as per former mergeOverlayIcon()

b) override mergeColorfulOverlayIcons, in which case the overlay will
be superimposed after the icon is greyed out as it is the case for stardard
error and recompute flags.
2021-01-06 13:54:00 +01:00
wmayer
423c374258 PD: [skip ci] fix msvc warning 2020-09-21 13:28:56 +02:00
wmayer
c69612c748 PD: improve reference highlighting of a pipe
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
Zheng, Lei
cd2b7e297c PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
Abdullah Tahiri
813e9040ac PartDesign: Refactor set/remove tip in the new Gui::ViewProvider mechanism 2019-06-23 01:03:35 +02:00
Abdullah Tahiri
07dacdba36 PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
Abdullah Tahiri
81255b859c fixes #3724 2018-12-14 19:26:30 +01:00
wmayer
1b7708a391 fixes 0003148: PartDesign does not allow colouring of single faces for non-primitives 2018-09-24 19:30:36 +02:00
wmayer
14f6de974b fix typos 2017-09-25 22:36:31 +02:00
Kurt Kremitzki
a5c3558384 PDN: Fix Pipe claimChildren to only grab sketches 2017-08-12 14:48:14 +02:00
Kurt Kremitzki
94ab6b159c PDN: Make Loft and Pipe claim children correctly 2017-07-26 23:16:12 +02:00
Ajinkya Dahale
4ae32c8851 Minor bug in PartDesignGui::ViewProviderPipe
Assert excludes any "Edge1"
2017-02-01 09:08:05 +05:30
Stefan Tröger
42cb9ee8cd PartDesign: Fix pipe preview display
When a base feature was available the preview mode did not show the pipe and also set the visibility of the pipe to false
2016-05-18 23:53:49 +02:00
Mateusz Skowroński
a8d37dabbe QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1().
This change is Qt4/Qt5 neutral.
2016-04-15 11:55:12 +02:00
Stefan Tröger
8cbf27dbd6 PartDesign: Fix context menus 2016-04-12 18:12:23 +02:00
Stefan Tröger
e64569aa2c PartDesign: prevent claiming features 2016-04-12 18:12:23 +02:00
Stefan Tröger
ae9dac71d7 PartDesign: Modeling features work with faces
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
2016-04-12 18:12:22 +02:00
Alexander Golubev
27667cf5e6 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
Alexander Golubev
9347f66a9e PartDesign/Gui: Move various utility stuff from Workbench to a separate file
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Stefan Tröger
aaad6cb644 add missing return value 2016-04-12 18:12:09 +02:00
Stefan Tröger
b425c028ee Update pipe icon and add it to the taskwatcher 2016-04-12 18:12:09 +02:00
Stefan Tröger
f199c844e6 add two scaling modes 2016-04-12 18:12:09 +02:00
Stefan Tröger
7fc0111944 better pipe view handling 2016-04-12 18:12:09 +02:00
Stefan Tröger
254e2226ba generalize preview mode 2016-04-12 18:12:09 +02:00
Stefan Tröger
835085bc7c add basic part design pipe infrastructure 2016-04-12 18:12:09 +02:00