kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
40,409 Commits 41 Branches 6 Tags
0921ed29698355f557612ff4372b8cf2e0cc1d37
Commit Graph

3453 Commits

Author SHA1 Message Date
Andrew Shkolik
0921ed2969 fix #19831 Sketcher: Create external Intersection geometry not working with complex surfaces 
Co-authored-by: Zheng Lei <realthunder.dev@gmail.com>
 2025-02-25 01:36:25 -06:00
Max Wilfinger
b07caa732e Remove hack around geometry visibility in active sketch. 
Revert #14386 and #16378
 2025-02-24 22:09:37 +00:00
Joao Matos
cc6ffb44de Core: Move PyCXX library to src/3rdParty. 2025-02-24 16:36:06 +00:00
Chris Hennes
2780c9b13e Merge pull request #19397 from kadet1090/three-point-lighting 
Add three-point lighting
 2025-02-24 16:22:34 +00:00
Andrew
0aed23ca81 fixes #19582 Sketcher - cannot project BSpline from another sketch (#19700) 
Also fixes some other types of external geo

---------

Co-authored-by: Andrew Shkolik <andrew.shkolik@selerix.com>
Co-authored-by: realthunder <realthunder.dev@gmail.com>
 2025-02-24 10:17:24 -06:00
Chris Hennes
2c485cf998 Merge pull request #19253 from Jonezzzzz/SketcherGroupCommandsFix 
Sketcher: Fixed Inconsistency between button tooltips and labeling for shortcuts.
 2025-02-23 22:20:07 +00:00
Kacper Donat
7f984811e8 Gui: Add 3 point lighting 2025-02-23 22:51:13 +01:00
Kacper Donat
12a69fe296 Base: Add isNullOrEmpty string helper 
This adds isNullOrEmpty string helper that cheks if string is... well
null or empty. It is done to improve readability of the code and better
express intent.
 2025-02-21 15:04:43 +01:00
Joao Matos
27ebc68a11 CMake: Modernize build files using outdated Python variables. 2025-02-16 10:21:26 -06:00
Andrea
de9bd5e1ce change MIN_boost_version 
ubuntu version 20.04 is no longer supported.
The minimum boost version used for freecad is now 1.74 (ubuntu 22.04) https://launchpad.net/ubuntu/jammy/+package/libboost-system-dev
 2025-02-15 13:33:32 -06:00
tritao
9636068460 Base: Move zipios library to 3rdParty folder. 2025-02-14 13:08:28 -06:00
Ian Hunter
67f8852697 Fix bug preventing filtering named constraints (#19339) 
* Fix bug preventing filtering named constraints

There was a bug (see issue #11843) that displayed a filter for Named
constraints in the Sketcher Workbench whose toggling did not affect the
UI in any way. This enables this feature by checking if a given
constraint has a custom name or not and then appropriately toggling its
visibility.

* Use `std::string::empty()` per reviewer suggestion

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
 2025-02-11 11:03:04 -06:00
Chris Hennes
a4901e2ccb Merge pull request #19142 from hyarion/refactor/add-template-addobject 
Add new addObject<T>() function
 2025-02-11 09:42:47 -06:00
Benjamin Nauck
8cc98b9a88 Mod: Use new addObject<T>(...) that requires additional changes 2025-02-10 18:35:38 +01:00
Benjamin Bræstrup Sayoc
c0c6df10ec Sketcher: Use QStringLiteral 2025-02-10 18:32:45 +01:00
mosfet80
cf5d66d201 clean SketchObject.cpp (#15728) 
* clean SketchObject.cpp

Code clean 
small optimization

* Restore comment

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2025-02-10 11:04:26 -06:00
Chris Hennes
86e2ae8a6b Merge pull request #18916 from AjinkyaDahale/sk-refactor-stage-3 
[Sketcher] Round 3 of refactors
 2025-02-10 11:01:55 -06:00
tritao
10513144d9 Base: Standardize on Py::Long type for Python bindings. 2025-02-08 13:14:22 +00:00
Chris Hennes
e10d34ada5 Merge pull request #16995 from benj5378/axisColors 
[Gui] Axis colors changeable
 2025-02-03 18:11:46 +01:00
tritao
65466d580b Gui: Reorganize the selection files into a top Selection folder. 2025-02-03 17:56:57 +01:00
Ajinkya Dahale
80fa694270 [Sketcher] Incorporate suggestions by hyarion from #18916 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
9238a7c1fd [Sketcher] More refactor of delConstraintOnPoint 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
0358ff7ce2 [Sketcher] Refactor SketchObject::delConstraintOnPoint() 
Note that for distance constraints we remove even if the constraint is not on the point.
 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
ab2e4adb31 [Sketcher] Refactor deleteUnusedInternalGeometryWhenBSpline 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
502b7b9a3f [Sketcher] Fix some issues in trim 
1. Don't bother deleting internal geometry first.
2. Don't assume all new constraints are well formed.
 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
909e5bfafb [Sketcher] Use replaceGeometries() in trim 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
c8c8c2c208 [Sketcher] Move trim sub-steps to different functions 2025-01-30 09:34:03 +01:00
Ajinkya Dahale
77bb7ab2d4 [Sketcher] Move internal functions out of trim 
Towards making it a function class or similar.
 2025-01-30 09:34:03 +01:00
Benjamin Nauck
45c997f40a Manual changes to improve isDerivedFrom usage 2025-01-27 16:08:19 +01:00
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's 
Regex based changes, manually verified
 2025-01-27 16:08:18 +01:00
Benjamin Nauck
ae15d98fd3 Use is<T>() when possible 2025-01-27 16:08:18 +01:00
Joona
855bce62cd Initialize sketcher group command shortcuts 
Set the first subcommand's shortcut as the group command's shortcut for all sketcher group commands.
 2025-01-26 15:49:24 +02:00
Joona
d18a48ddb1 Updated tools to use group command class. 
Updated rectangle, polygon and spline group commands to use group command class.
Added separator comments with tool names for better code organization.
 2025-01-26 15:18:38 +02:00
jffmichi
ab311f1f9b Sketcher: fix seg-fault on loading sketch with redundant constraints 2025-01-26 06:46:34 -06:00
Joona
f9d6609687 Rearranged file for better logical grouping 
Reorganized the functions in the file to improve logical grouping and readability.
No actual code changes were made—only the order of functions was adjusted.
 2025-01-26 13:15:54 +02:00
tritao
8aa50c4380 Gui: Reorganize the dialog files into a top Dialogs folder. 2025-01-24 16:28:02 -06:00
pre-commit-ci[bot]
09bd285c1d [pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
 2025-01-24 15:45:43 +01:00
Benjamin Bræstrup Sayoc
38e4e5a62e [Sketcher] Make axis colors changeable 2025-01-24 15:45:43 +01:00
Ulices
ee2f327a96 Add units to some spinboxes on preferences pages (#19143) 
* Add units to some spinboxes on preferences pages
* Ensure units have a space, ex: " px"
* FEM: Don't mark units for translation
 2025-01-22 09:05:49 -06:00
Beep6581
a1f5d36584 Auto scroll to constraint on click (#18859) 
* Auto scroll to constraint on click

When clicking on a contrasint in Sketcher, that constraint is now
automatically scrolled to in the Constraints listview. If selecting
multiple constraints, the last one is scrolled to.
Closes #17361

* Check model() for nullptr

* scrollTo only on select, not de-select #18859
 2025-01-21 11:33:51 -06:00
Chris Hennes
666ede9019 Sketcher: Refactor C++20 code 2025-01-20 20:57:34 -06:00
Vincent Belpois
f3efb5a7e8 Fix missing constrain type in type2str 2025-01-20 12:17:25 -05:00
Joona Okkonen
17c3286e52 Sketcher: Fixed mapping error when attempting to create a sketch inside a group. (#18971) 
* Sketcher mapping error fix

Fixed an issue in the Sketcher where attempting to create a sketch while a group is selected caused a mapping error. Now, when a sketch is created with a group selected, the sketch will be placed inside the group.

* Update to use new templated countObjectsOfType

This commit updates the code to use the new templated version of countObjectsOfType, aligning with recent changes in the main branch.

---------

Co-authored-by: Joona <jookkone@edu.lapinamk.fi>
 2025-01-20 11:11:09 -06:00
Kacper Donat
738a044f3c Gui: Add Show Plane utility to 2D Objects 2025-01-19 15:27:15 -05:00
Ajinkya Dahale
51cf34a596 [Sketcher] Refactor and fix an issue in transferConstraints 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
73253bd2d4 [Sketcher] Fix issues in knot operations 
For some reason this is not caught in the tests.
 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
b2e414c407 [Sketcher] Make replaceGeometries protected 
This should be a `protected` or `private` operation since it doesn't handle
constraints. However, this is intended to be used by external classes that
modify a `SketchObject` (instead of these modifications like `split`, `trim`,
`join` etc. being methods of `SketchObject`). In that case, it may be best to
use the `friend` keyword.
 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
aa1122c774 [Sketcher] Fix "used" B-spline poles being deleted 2025-01-16 15:56:22 +05:30
Ajinkya Dahale
821bc2ecdf [Sketcher] Incorporate review of #18665 by kadet 
1. Replace `find_if` with `any_of` when the iterator is not used.
2. Use PascalCase for templated class.
 2025-01-16 15:56:19 +05:30
Ajinkya Dahale
c6f5739763 [Sketcher] Refactor SketchObject::split 
1. Now uses `Part::Geometry::createArc`.
2. Removed type-specific codes. It can be generalized now.
 2025-01-16 15:55:14 +05:30