Commit Graph

20589 Commits

Author SHA1 Message Date
Uwe
0995c81240 [PD] add feature to set direction for pockets
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
2021-11-11 15:55:42 -06:00
wmayer
126fadd2d6 PD: make sure to switch off Profile and Section highlighting when closing sweep dialog 2021-11-11 20:33:27 +01:00
wmayer
fb9a3eecff PD: change visibility handling of sweep to support undo/redo 2021-11-11 20:21:47 +01:00
Chris Hennes
c62239d0ba Merge pull request #4626 from pavltom/GUI_TreeView_Item_Ordering
[Gui] Issue #3923 - Add arbitrary Tree View item ordering
2021-11-10 23:35:05 -06:00
Chris Hennes
bef1df4d40 Merge pull request #5163 from donovaly/PD-sweep-section-visibility2
[PD] fix sweep visibility bug
2021-11-10 22:43:49 -06:00
Uwe
969556573b [PD] code improvement for FeaturePad
as noted by @chennes in PR #5164, we should follow the C++ style guidelines:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-if
2021-11-11 02:26:42 +01:00
Uwe
8173f79dc7 [PD] code improvements for TaskPadParameters
as requested by @chennes in PR #5164, the code can be simplified:

- remove a redundant type cast, a redundant qualifier and an inconsistent and unnecessary check
2021-11-11 02:08:57 +01:00
Uwe
cc242aae7d [PD] handle changed property for loft and pipe
- this was missing in PR #5155
2021-11-11 01:24:53 +01:00
Ajinkya Dahale
a4fa45b589 [PD] Check if property is named before strcmp 2021-11-11 01:13:17 +01:00
Uwe
6069d48b6d [PD] fix sweep visibility bug
Currently:

    only sweep path is toggled correctly in its visibility, the profile is never shown
    the sections are always shown

This PR fixes this inconsistency reported here: https://forum.freecadweb.org/viewtopic.php?f=19&t=63544
2021-11-11 00:00:58 +01:00
Ajinkya Dahale
37df050d59 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Bernd Hahnebach
62ad96508a Arch: export IFC, make compatible with ifcopenshell 0.7 2021-11-10 15:59:30 +01:00
Chris Hennes
b660ed815c Merge pull request #5152 from Roy-043/Draft-fix-getTeighaConverter
Draft: fix getTeighaConverter
2021-11-09 23:05:03 -06:00
Uwe
e06034e772 [PD] fix a typo
- also some sorting
2021-11-10 03:26:23 +01:00
luz paz
96bbb4ba21 TechDraw: Renames submenu command + exposes to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/82  
The dropdown `TechDraw > Extensions: centerlines and threading` (submenu) is too long and superfluous. Renamed to: `Extensions: Centerlines/Threading`. Also exposed to translation.
2021-11-10 01:11:39 +01:00
Ajinkya Dahale
314ff0053c [PD] Fixed loft and sweep breaking on section deletion
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
2021-11-09 23:05:29 +01:00
Ajinkya Dahale
03a8ff7841 [PD] Support adding solid faces for loft and pipe sections
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
2021-11-09 23:05:29 +01:00
wmayer
5c77af421d PD: [skip ci] fix crash in ReferenceSelection::allow 2021-11-09 18:37:54 +01:00
luz paz
d63dab54cb TechDraw: Fix typo in Tool Attributes command + expose to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/85
2021-11-09 07:23:11 -05:00
Chris Hennes
9e4ea890e8 Merge pull request #5149 from donovaly/PD-loft-visibility-fix
[PD] fixes loft visibility on creation and modification
2021-11-08 15:57:17 -06:00
Roy-043
15c495a5bd Draft: fix getTeighaConverter
The getTeighaConverter function did not work on Windows. We don't deal with the actual TeighaFileConverter anymore so there is no need to check for that file. Although the name of the function and the name of the parameter have been kept.
2021-11-08 15:31:49 +01:00
Yorik van Havre
25d0e63e0c Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-11-08 10:51:28 +01:00
Yorik van Havre
0b4e1ea556 Draft: Fixed DWG import's QCAD config 2021-11-08 10:51:10 +01:00
Chris Hennes
02c1277a1d OpenSCAD: Minor cleanup of import code 2021-11-07 21:50:48 -06:00
Chris Hennes
058962362d OpenSCAD: Refactor tests to all use the same code path for tempdir generation 2021-11-07 17:13:51 -06:00
Uwe
0b77c2b2b5 [PD] fixes loft visibility on creation and modification
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
2021-11-07 21:57:00 +01:00
Uwe
0b4405e935 [PD] simplify Loft code
- also two automatic style fixes made by MSVC
2021-11-07 19:04:38 +01:00
wmayer
84274f5c80 PD: [skip ci] fix ambiguous shortcut overload in TaskDlgPipeParameters 2021-11-07 08:27:33 +01:00
wmayer
4f56ee263d Sketcher: fix some memory leaks 2021-11-06 17:48:35 +01:00
luzpaz
4543c98267 MeshPart: fix header uniformity + remove superfluous whitespace (#5135)
* MeshPart: fix header uniformity + remove superfluous whitespace
2021-11-06 00:15:00 +01:00
Ajinkya Dahale
e30efba754 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
wmayer
549e5b5650 Tux: support of OpenSCAD and TinkerCAD in navigation indicator 2021-11-05 23:49:14 +01:00
0penBrain
7cd3930dd8 [Sketcher] Removed lines that was introduced to workaround grid visibility management issues 2021-11-05 03:18:08 +01:00
0penBrain
76130c85ce [ViewProvider2DObject=>Sketcher] Fix grid visibility management
Error in grid visibility equation that makes grid to disappear when saving document in Edit mode
2021-11-05 03:18:08 +01:00
0penBrain
648c55c8a0 [ViewProvider2DObject] Fix typo 2021-11-05 03:18:08 +01:00
luz paz
fdcdaebc9b Fix typos in source comments [skip ci]
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2021-11-05 02:35:17 +01:00
wmayer
8366028e6f PD: [skip ci] open a transaction when creating a new body with DlgActiveBody 2021-11-04 23:21:14 +01:00
0penBrain
b22f2c6562 [Sketcher] Add tooltips in Validate Sketch task UI 2021-11-04 18:40:26 +01:00
0penBrain
eac21354fa [Sketcher] Refactor Validate Sketch task UI to decrease confusion 2021-11-04 18:40:26 +01:00
wmayer
09da245af9 App: harmonize API of App::Application
* make getHomePath() static and return a std::string
* make getExecutableName() static and return a std::string
2021-11-04 10:50:09 +01:00
Chris Hennes
bcab6b5a31 Spreadsheet: Prevent marking a cell dirty when the content didn't change 2021-11-03 19:16:31 -05:00
Uwe
e43189fc48 Merge pull request #5141 from luzpaz/mesh-qrc
Mesh: separating translation section in Mesh.qrc
2021-11-04 00:55:17 +01:00
Uwe
1e49e20232 Merge branch 'pr/5140' 2021-11-04 00:49:36 +01:00
Chris Hennes
b8ad042986 Spreadsheet: Fix copy of empty but used cell 2021-11-03 14:31:11 -05:00
luz paz
e8016bdb82 Mesh: separating translation section in Mesh.qrc 2021-11-03 11:17:05 -04:00
luz paz
9a9267f922 Mesh: Convert comments from DE->EN
Bringing uniformity to documenting FreeCAD
2021-11-03 11:13:16 -04:00
Chris Hennes
56d900c669 Spreadsheet: Display new value, or pending, when dirty
If recomputes are turned off, the old behavior was that a cell would
display its old property value in the SheetView. The new behavior is
that we check to see if the value is actually something that gets
computed: if so, show "#PENDING". If not, display the new value, but
format it specially to indicate that it's been changed and that
a recompute is (eventually) needed.
2021-11-03 09:23:43 -05:00
Chris Hennes
123b5b5da1 Spreadsheet: Remove double-set of value on enter 2021-11-02 23:12:31 -05:00
Bernd Hahnebach
7542673b00 FEM: command module, fix regression in the regard of translation added with 5b52840ca5 2021-11-02 17:43:41 +01:00
Chris Hennes
0d511a6dd2 Spreadsheet: Fix bug in content and alias lineedits
The two line edit widgets above the spreadsheet, one for exiting the
cell contents and one for editing the alias, were set to use the same
editing widget as the individual spreadsheet cells. Once that widget was
refactored to handle tab/enter behavior it was no longer the correct
widget for those elements. This commit changes them to
Gui::ExpressionLineEdit widgets instead, so that the Enter key works
correctly for them again.
2021-11-02 10:15:19 -05:00