Commit Graph

3211 Commits

Author SHA1 Message Date
Yorik van Havre
0a69f0d7c2 Updated ts files 2024-07-11 14:56:33 +02:00
bgbsww
af1f7385d4 Toponaming: Comment out console warnings triggered by external geometry 2024-07-09 08:55:21 -05:00
pre-commit-ci[bot]
b571f09c1c [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2024-07-09 08:52:17 -05:00
Yorik van Havre
32c9ed5493 Merged crowdin translations 2024-07-09 08:52:17 -05:00
Max Wilfinger
7d21d9edb8 Fix source string typos mentioned on Crowdin (#15261) 2024-07-08 17:18:31 -05:00
wmayer
8668d48b2d Sketch: Fix compiler warnings 2024-07-08 19:27:39 +02:00
PaddleStroke
5e4ab51c02 Sketcher: Bspline: Fix degree visibility, default value and combobox not updating with methode change. 2024-07-08 11:27:46 -05:00
Chris Hennes
fe007b205b Merge pull request #14979 from Ondsel-Development/sk_ovp_switching
Sketcher: Dimension: Fix 2 bugs.
2024-07-08 11:26:39 -05:00
wmayer
fadb607054 Tests: Make PD and Sketcher tests independent of user settings
The Refine property must be explicitly set as otherwise some tests will break because of different user settings
2024-07-08 11:19:36 -05:00
PaddleStroke
b7c6ffe785 Sketcher: scale/translate: fix OVP warning if disabled 2024-07-08 11:13:29 -05:00
FEA-eng
e09d8c58f7 Sketcher: Increase default width of dashed lines (#15075)
* Sketcher: Update SketcherSettingsAppearance.ui

* Sketcher: Update EditModeCoinManager.cpp
2024-07-08 11:06:55 -05:00
Chris Hennes
4eb57fb50d Sketcher: Resolve unsafe combination of bool and int in | 2024-07-08 11:02:49 -05:00
ppphp
51c6dbd3e3 fix unique ptr usage in sketch (#15008)
* fix unique ptr usage in sketch

* [pre-commit.ci] auto fixes from pre-commit.com hooks
2024-07-08 10:53:49 -05:00
Chris Hennes
24c7d3ef25 Sketcher: Switch SnapManager from Win-1252 to UTF-8 2024-07-08 17:51:33 +02:00
PaddleStroke
cef87b5642 Sketcher: BSpline DSH: Fix crash: If you create new sketch, start bspline tool and change mode, it would crash. It's because it was doing a abortCommand before the command was opened. So it cancelled the create sketch command. 2024-07-08 10:50:33 -05:00
PaddleStroke
6a309e889e Sketcher: BSpline: Fix crash when cancelled while only one point with autoconstraint. 2024-07-08 10:41:11 -05:00
wmayer
1eaf89b485 Sketcher: Handle PyException in createGeneratedAutoConstraints
Command::doCommand may throw an exception that isn't handled by the active sketch handler. This may leave it in an inconsistent state and can cause a crash later.

See #14945
2024-07-08 10:40:04 -05:00
wmayer
561e521817 MSVC: Fix warning C4005: 'NOMINMAX': macro redefinition 2024-07-05 17:04:43 +02:00
wmayer
858e59fabf Sketcher: Fix format string in ExternalGeometryFacade::initExtensions()
The format string of the warnings were incorrect and caused an fmt::format_error exception
2024-07-04 22:05:22 +02:00
PaddleStroke
d92742f9c6 Sketcher: Dimension: Prevent the use of Undo from crashing. 2024-07-02 15:48:47 +02:00
Yorik van Havre
2a009589f9 Translations (#15107)
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-07-02 12:21:53 +02:00
PaddleStroke
fa0fdf22cf Sketcher: Dimension: Fix constraint switching. Refactor a little bit by adding finishDimensionCreation to reduce code copies. 2024-07-02 09:49:47 +02:00
Chris Hennes
2411f9f3b3 Merge pull request #14461 from AjinkyaDahale/sk-fix-12592-bsp-by-knot-trim
[Part][Sketcher] Fix some B-spline trimming issues
2024-07-01 11:28:50 -05:00
FEA-eng
2abe477651 Sketcher: New carbon copy icons (#15074)
* Sketcher: Delete src/Mod/Sketcher/Gui/Resources/icons/geometry/Sketcher_CarbonCopy.svg

* Sketcher: Delete src/Mod/Sketcher/Gui/Resources/icons/geometry/Sketcher_CarbonCopy_Constr.svg

* Add new carbon copy icon

* Add new carbon copy constr icon
2024-07-01 11:00:07 -05:00
Max Wilfinger
e490531510 Activate Part/Part Design check and refine preferences by default (#14406)
* Activate Part/Part Design check and refine preferences by default

* added bool in .ui

* Update tests

* Fix Sketcher tests
2024-07-01 10:50:42 -05:00
bgbsww
d65ee84ff2 Cleanup 2024-06-28 22:24:30 -04:00
pre-commit-ci[bot]
54920e6611 Review cleanups 2024-06-28 11:57:43 -05:00
bgbsww
a674729dd3 Toponaming: Cleanups 2024-06-28 11:57:43 -05:00
Zheng, Lei
7a4bc95d47 Toponaming: Transfer in missing Code for BaseFeatures and Sketches 2024-06-28 11:57:43 -05:00
Ajinkya Dahale
333ca836c0 [Sketcher] Delete point-on-object on trimmed portion
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
de61b9dc9f [Sketcher] Fix some issues with trimming splines
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
7c15affce6 [Sketcher] Rearrange directives to appease syntax highlight
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
Syres916
8bf54ad82f [Sketcher] Correct default OVP and Geometry Creation colors... (#14763)
* [Sketcher] Correct default OVP and Geometry Creation colors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-24 11:08:28 -05:00
Chris Hennes
e60d43fcdc Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
Chris Hennes
926fd370b1 Merge pull request #14079 from Ondsel-Development/sk_bspline_ovp
Sketcher: BSpline DSH: implement OVP/widget
2024-06-24 10:38:15 -05:00
CalligaroV
4a486b21ed Sketcher: fix external edges selection
* fix selection from Sketcher Task Panel
 * fix selection from 3D View
 * Synchronize selection between Task Panel and 3D View

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-06-24 10:35:54 -05:00
Max Wilfinger
d2491541e1 Rename OVP preference options 2024-06-23 12:29:19 -05:00
wmayer
f6e67a009d Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
a36a60d29d Fem/Sketcher: Fix missing PreCompiled.h files 2024-06-18 08:05:32 -05:00
bgbsww
2d22e7a21a Toponaming: Fix crash with invalid external geometry 2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
77eedb84f8 Fix importing arcs and elliptical arcs as external geometry.
Fix importing elliptical arcs issue #8700.
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
Alexandre Prokoudine
a98d7eb288 Adjust names of two Sketcher tools to make their functions discoverable
Users report that they have a hard time figuring out that 'Array transform' does
movement/translations, and 'Polar transform' does rotation. Hence this
adjustment of their user-visible names.
2024-06-17 10:57:10 -05:00
PaddleStroke
177673a056 Sketcher: BSpline DSH: implement OVP/widget 2024-06-17 16:52:24 +02:00
PaddleStroke
4d15b8f66a Sketcher: Fix circle diameter OVP 2024-06-13 14:51:48 -05:00
PaddleStroke
22a98d81f0 Sketcher: - Give focus to the MDI so that keyboard events are caught after starting edit. Else pressing ESC right after starting edit will not be caught to exit edit mode.
- After tool handler is purged, give back focus to MDI to make sure VPSketch receive the keyboard event. Else if user start a tool, dismiss it with ESC, then press ESC again to exit edit mode it won't be detected.
2024-06-13 14:44:30 -05:00
PaddleStroke
e6b18dc381 Sketcher: polygone DSH, typo fix 2024-06-12 10:57:43 +02:00
bgbsww
d467236564 Guard all uses of basic_random_generator for thread safety 2024-06-10 11:10:57 -05:00
PaddleStroke
833e9cc8ab Sketcher: Fix default value of dimConstrDeactivatedColor 2024-06-10 11:09:36 -05:00
mosfet80
62279d083d [mod] clean (#14378)
* [mod] clean

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
Emmanuel Obrien
a7e1760bfb Speedup sketcher item selection
Selecting lots of elements in the sketcher slows down quadratically because we were redrawing the entire element list widget for each element.
2024-06-10 10:35:32 -05:00