Commit Graph

68 Commits

Author SHA1 Message Date
Roy-043
7e0550a7c8 Arch: Housekeeping: import translate from correct file 2022-07-21 10:17:03 +02:00
Yorik van Havre
dccad1d247 Merge branch 'master' into Arch_Roof_fix_for_adjust_list_len 2021-03-26 11:23:56 +01:00
Yorik van Havre
4c1635706e Merge pull request #4453 from regularfry/lgtm-arch-unused-imports
Arch: removes unused imports
2021-03-26 11:22:11 +01:00
Roy-043
99af124f80 [ARCH] Arch_Roof fix for adjust_list_len function
LGTM code analysis did not like that the adjust_list_len function would mutate default list values. De function now always clones the list.
See: https://forum.freecadweb.org/viewtopic.php?f=23&t=55943
2021-02-23 19:58:39 +01:00
Roy-043
fbe7178cdb [Arch] ArchRoof: Improved compatibility fix
The check if a relative profile in turn references a relative profile has been improved. Added: run or angle of profilRel must be zero.
2021-02-17 21:35:51 +01:00
Alex Young
80dbfd5814 Arch: removes unused imports
Removes unused imports as reported by LGTM.

There are exceptions: `import Arch_rc` is shown as an alert, but has side effects.  It's not clear what the best thing to do in those cases is, so I've left them for now.
2021-02-14 16:27:06 +00:00
Chris Hennes
9d1958475e [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Roy-043
b31667dbc7 Update ArchRoof.py
A relative profile can now be used if it references itself. This fixes a compatibility issue with the V0.18 version of ArchRoof, where the first profile initially always references itself.
2021-01-20 19:17:30 +01:00
luz paz
ccf30d98d2 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Roy-043
9292bb60b0 Update ArchRoof.py
The processSubShapes function was wrongly called without providing the placement argument.
2020-11-15 12:02:02 +01:00
Roy-043
b7125d0162 Arch: ArchRoof bug fix
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
luz.paz
8af8689d73 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
ef5acc5023 Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
Yorik van Havre
c24b9fb68a Arch: Fixed error in roof - Fixes #3864 2019-05-07 22:47:15 -03:00
Yorik van Havre
506cfd9bd2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
Yorik van Havre
163232f623 Arch: misc improvements to IFC importer
* Fixed progress bar
* Import can now be aborted by pressing ESC
* No intermediary Extrusion object is created for Walls and Structures
* When a base profile has only linear edges, create a draft wire instead of face
* Fixed placement bug in shared profiles
2018-07-19 17:04:19 -03:00
Yorik van Havre
0bae245b26 Arch: separate properties creation in own methods and check properties at file load 2018-06-01 19:36:35 -03:00
Yorik van Havre
63794fcefd Arch: Renamed Role property to IfcRole 2018-05-11 12:01:55 -03:00
Yorik van Havre
34ba3d8f3c Arch: All Arch objects can now have any IFC type(role) 2018-05-10 10:42:06 -03:00
Yorik van Havre
d49a194279 Arch/Draft: Make sure an active doc exists before creating objects 2018-05-08 16:07:55 -03:00
luz.paz
ccb2fc6387 Arch: removing \n from translated strings
ref: https://crowdin.com/translate/freecad/548/en-hu#6501126
2018-02-07 09:42:13 +01:00
Yorik van Havre
4fc53e1bd2 Arch Added a Flip property to roofs to fix inverted direction 2017-07-26 13:29:34 -03:00
Yorik van Havre
009859ddf3 Draft: AutoGroup system 2017-01-25 14:55:14 -02:00
Yorik van Havre
876b3595dc py3: open function is in module 'io' in py3 instead of __builtin__ 2017-01-17 09:24:59 +01:00
wmayer
50dc459d42 remove UnicodeUTF8 2016-12-27 19:31:25 +01:00
Yorik van Havre
bf0d37bf28 Doc: Fixes in doxygen docs for Draft,Arch, FEM 2016-11-17 17:04:09 -02:00
Yorik van Havre
f84d0fe1b4 Arch: Added wave properties to panels 2016-10-14 15:55:09 -03:00
Yorik van Havre
210455d7db Made Arch objects properties translatable - issue #2524 2016-10-07 21:37:15 -03:00
Yorik van Havre
16db08de2d Arch: Removed trailing spaces 2016-09-06 13:05:07 -03:00
Yorik van Havre
2300840671 Arch: Added border & ridge length properties to Roofs - fixes #2636 2016-09-06 13:04:23 -03:00
Yorik van Havre
f40758eba9 removed translation from property descriptions (wrong to do it there anyway) - issue #2524 2016-05-18 16:59:15 -03:00
Jonathan Wiedemann
75c71d654f Arch Roof : Fix BOPCheck failed
cf http://forum.freecadweb.org/viewtopic.php?f=23&t=14711
2016-03-17 23:24:17 +01:00
Jonathan Wiedemann
e761af45b7 Arch Roof : improvement and clean up
change default value
handle shape based object
better getsubvolume method
2016-03-03 10:45:32 +01:00
Jonathan Wiedemann
3b304202dd Arch Roof : improvement and clean up
change default value
handle shape based object
better getsubvolume method
2016-03-01 09:45:11 +01:00
Jonathan Wiedemann
99a0d60805 Arch Change default value
Comment some print
2016-02-19 16:20:57 +01:00
Yorik van Havre
4a08b71ac4 Arch: Fixed imports in ArchRoof 2015-09-07 15:10:29 -03:00
Yorik van Havre
f8571fb2a4 Changed all references to DraftGeomUtils.sortEdges to Part.__sortEdges__ 2015-09-04 11:54:57 -03:00
Yorik van Havre
86cf572f34 Arch: Misc improvements for IFC workflow
* Added utility to make non-parametric Arch component
* Ability for all Arch components to be a clone of another Arch component of same type
* Modified the Draft Clone tool to produce Arch Clones if applicable
* Fixed Arch Roofs so they can be based on a solid shape like other Arch objects
* Ability to change the Root element to be imported in IFC preferences
* Ability to import IFC files also as compounds, Part shapes or non-parametric Arch objects
* Added an "only" parameter to importIFC.open() to import only a certain object ID.
* Ability to read colors (IfcSurfaceStyle) from IFC objects
2015-04-08 12:34:48 -03:00
Yorik van Havre
f13efd03bd Arch: removed old debug message 2015-02-25 18:44:45 -03:00
Yorik van Havre
ef315f91ca Arch: misc bugfixes in IFC export 2015-02-23 19:34:29 -03:00
Yorik van Havre
c023355fcb Arch: Adapted IFC importer for new IfcOpenShell6
Squashed following commits:
* Arch: Adapted IFC importer for IfcOpenShell6
* Arch: further fixes for ifcopenshell6 compatibility
* Arch: IFC importer now converts to/from  meters for better compatibility with IfcOpenShell
* Arch: further fixes with ifcopenshell6
* Arch: precision adjustments in IFC exporter
* Arch: small fix in makeRoof
2015-02-13 16:41:34 -02:00
Yorik van Havre
a0be92bd70 Arch: Corrected some texts 2015-01-23 12:45:11 -02:00
wood-galaxy
8b558be0b2 + fixes #0001923: Fix typo for a string within the Arch wokbench 2015-01-17 11:41:22 +01:00
wood-galaxy
8147078dc5 Arch Roof : Improvement on gable case 2015-01-15 10:26:43 -02:00
wood-galaxy
a6a2c6508a Arch Roof : Add units in column header. 2015-01-15 10:26:43 -02:00
wood galaxy
496ec111fd Arch : Internal object name are in English.
Arch objets Label could be translated.
2015-01-05 13:13:45 -02:00
wood galaxy
e37eb3c4bc Ready for merge : fix issues #1618 and #1607
Implement getSubVolume to cut wall with roof.
Now Roof is not hidden when removing it to a wall.
2014-12-08 12:23:01 -02:00
wood galaxy
76880a1082 Implement Overhang 2014-12-08 12:23:01 -02:00
wood galaxy
5c58965f8f Fix bug if user enter thickness = 0 2014-12-08 12:23:01 -02:00
wood galaxy
ca0a73cf82 Add a new Arch Roof Builder 2014-12-08 12:23:01 -02:00