Commit Graph

5676 Commits

Author SHA1 Message Date
Chris Hennes
0d293e0655 Merge pull request #15987 from obelisk79/classicfix
Fix FreeCAD Classic cfg file to explicitly reassign theme defaults.
2024-08-26 11:18:21 -05:00
wmayer
c30d42c441 Core: Rename ViewProviderPythonFeature to ViewProviderFeaturePython
Fixes #15888
2024-08-26 18:14:22 +02:00
Kacper Donat
e2b9c82c11 Gui: Ensure minimum size of preferences dialog (#16019)
* Gui: Ensure minimum size of preferences dialog

This will ensure that the width of preferences dialog is resized to fit
all pages properly but not take more than 80% of screen.

* Gui: Use consts for resizing preferences dialog
2024-08-26 10:48:49 -05:00
MisterMaker
64c2dbc804 Overlay blur fix + slightly less white background (#15886)
* remove bluw changed the white background to 2 steps below white

* Delete CMakeSettings.json

* Revert "remove bluw changed the white background to 2 steps below white"

This reverts commit a8cab51f0eb6fc5eb6cb3644d1d13f9421a9b05d.
2024-08-26 10:48:00 -05:00
wmayer
18cd67c64f Linux: Fix regression with mask of cursors if platform name is 'xcb' 2024-08-26 10:35:53 -05:00
Hannu Koivisto
f155d2e272 Fix crash when using box selection with Arch Survey
doSelect() loops over document's object vector.  It can happen that, within
the loop, Gui::Selection().addSelection() gets called and that ends up
calling App::Document::addObject() which pushes an object to the vector that
the loop is traversing.  If the vector is full, its storage is reallocated
and this means that later iterations of the loop are using invalid iterators.
Thus, one ends up with a bogus obj pointer and there will be a crash within
getGroupOfObject().  The problem was observed when using Arch Survey.
2024-08-26 17:33:55 +02:00
obelisk79
fba9a9a0a3 add missing start WB values 2024-08-25 23:11:29 -04:00
obelisk79
dffa1bb350 Resolving discrepancies. 2024-08-25 23:08:28 -04:00
Kacper Donat
953bed50d2 Gui: Fix issue with missing icons in sketcher
This boiled down to conflict of using `data` attribute of the QAction in
ActionGroup and ToolBarManager. I reworked ActionGroup here to not use
the data attribute but this is not a proper solution - but it should be
working well enough.

Proper solution would be to leave the data for the specific usecases (like index)
and store the command name in some other place. It would however require
us to subclass the QAction which is not something that should be done so
late in the release cycle.
2024-08-25 19:40:25 -05:00
Chris Hennes
c536d613b0 Gui: Workaround for #14350 2024-08-24 20:40:33 -05:00
xtemp09
3ec31ef59b Reimplementation of Light source dialog (#15877)
* Reimplementation of Light source dialog

Closes #15793.

* Gui: Remove redundant void arguments

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-08-22 18:58:14 -05:00
obelisk79
e34b8c80e4 Fix FreeCAD Classic cfg file to explicitly reassign theme defaults. 2024-08-21 07:31:00 -04:00
Chris Hennes
fe27127662 Gui: Correct repeated extension
Fixes #15908
2024-08-19 12:30:52 -04:00
Nino Annighoefer
aa40f00f2f Use portable text to set shortcut
At least on macOS, it seems that setting nontrivial shortcuts only works
when the shortcut is converted to `PortableText`, rather than
`NativeText`.

Before, it was impossible to map, eg, the backspace key or CMD-T to an
action. Now this appears to work.
2024-08-18 14:14:35 -05:00
Chris Hennes
5addf9d91b MacOS: Modify OS detection macro (#15924)
* Fixes #15904
* MacOS: Always use Q_OS_MACOS to detect MacOS because the Conda builds do not define Q_OS_APPLE
2024-08-18 08:29:40 -05:00
MisterMaker
7b20b9f3a1 Stylesheet fixes-part VI: The return of the comma (#15806)
This should fix a bunch of issues, like the white arrows the blue select background. @maxwxyz
2024-08-12 11:58:19 -04:00
Pieter Hijma
da75676ce8 Gui: Fix #15203 filename extension export 2024-08-12 11:52:48 -04:00
Pieter Hijma
065d43f71b Core: Fix adding VarSet props with existing prefix 2024-08-12 11:44:24 -04:00
Syres916
0c9c015182 [Gui] Remove the disabling of CornerCoordinateSystem 2024-08-12 11:42:51 -04:00
Syres916
991258559a [Gui] Ensure FreeCAD Classic theme is properly reset...
... but doesn't click Done and so when Preferences>General is opened the Theme displayed in the combobox is always FreeCAD Classic
2024-08-12 11:42:51 -04:00
Max
b256c457e9 Change default to not include the icon file to the file thumbnail on save.
Windows renders the application image on top so it appears twice.
Update example file thumbnails on start page to have a consistent background (classic theme) and remove the old FreeCAD logos.
2024-08-12 11:37:38 -04:00
Syres916
2bd630d362 [Gui] Overlay hide mode improve contrast in both themes... 2024-08-12 11:37:06 -04:00
Chris Hennes
ea9f0c7a67 GUI: Update MacOS detection macros
For GUI-specific things use Q_OS_MACOS, and for other things use
Q_OS_APPLE.
2024-08-12 11:34:39 -04:00
luzpaz
0a9a7bd24e Fix various typos 2024-08-11 12:09:27 -04:00
Chris Hennes
b4abe0b3d3 Gui: Fix crash in DlgSettingsLightSources
Fixes #13357
2024-08-08 21:34:28 -04:00
MisterMaker
401642b355 Stylesheet-fixes V: The final frontier (#15742) 2024-08-05 11:07:49 -05:00
bgbsww
2cd760ac40 Add a command line option to keep application open after running tests 2024-08-05 10:47:59 -05:00
xtemp09
a721dae67a Fix the crash involving context menu
Closes #13637.
2024-08-05 11:43:56 -04:00
Yorik van Havre
23a9f47780 Translations (#15689)
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-08-05 10:42:18 -05:00
Chris Hennes
30863382de Merge pull request #15588 from cjmayo/ThemeSearchPaths
Remove icon ThemeSearchPaths option on Linux
2024-08-05 10:41:41 -05:00
MisterMaker
e6863d0d15 Stylesheet fixes part IV - A new hope (to be done for 1.0) (#15586)
* Qcolor dialog fixes

* Fix for white hoover on tabbar

* Changes active color and selected feature color

* update same colors in cfg

* fix for tab pan in material editor

* some fixes

mostly theme accent colors fixes.

* fixed text edit being cut off

https://github.com/FreeCAD/FreeCAD/issues/15603

* extend arrow fix

https://github.com/FreeCAD/FreeCAD/issues/15616

* checkboxes links qpushbuttons etc.

Fixed https://github.com/FreeCAD/FreeCAD/issues/15610#event-13642470770
and hopefully also
https://github.com/FreeCAD/FreeCAD/issues/15136#issuecomment-2254156398

* fixed selection-text color in the preference menu also White is white.

* forgot checkbox spacing for light

* colors update

fix for https://github.com/FreeCAD/FreeCAD/issues/15660#event-13670498420
and
https://github.com/FreeCAD/FreeCAD/issues/15620#issuecomment-2251144435

* Delete CMakeSettings.json

* get out of here

* title a tat higher

* change rubberband from white to blue to make it work with white background.

* setting the colors.

* tree colors
2024-07-29 17:31:17 -05:00
Chris Hennes
369a2f7654 Merge pull request #15652 from kadet1090/ui-fixes
Gui: Cosmetic Fixes
2024-07-29 11:26:58 -05:00
wmayer
f0a1f60aad Gui: Fix Gui.Control.showModelView() 2024-07-29 11:06:42 -05:00
David Carter
40f23a27fb Materials: Reset per face when using property editor
In v0.21 changin the color using the propert editor reset the per face
colors. This recreates that behavior when settin the appearance.

fixes #15170
2024-07-29 10:56:29 -05:00
Chris Hennes
2e9e5c0c01 Merge pull request #15622 from Syres916/Fix_Display_UI_File
[Gui] Syncronise preferences page Display > UI with default settings
2024-07-29 10:55:01 -05:00
Ladislav Michl
46cce4bc98 Gui: Buggy Wayland custom cursors workaround
Until Qt v6.6 displaying custom cursors on Wayland is broken,
so add a workaround. See also QTBUG-95434.
2024-07-29 10:51:46 -05:00
Chris Hennes
828e85963e Merge pull request #15451 from Ondsel-Development/fix-single-instance-windows
Core: Fix single instance windows
2024-07-29 10:42:47 -05:00
Kacper Donat
484199dbce Gui: Remove unnecessary minimumSizes from Preferences
QT treats setting minimum size very seriously - it applies even if
the size required by the control is smaller than specified resulting in
rendering too small controls.
2024-07-28 00:00:09 +02:00
Kacper Donat
065295de43 Gui: Remove unnecessary scrollbars from Preferences 2024-07-28 00:00:03 +02:00
Kacper Donat
4aabd47dcd Gui: Trim tree view column only if one column 2024-07-27 20:29:42 +02:00
Kacper Donat
9f1fd5a2b4 Gui: Fix minor preference pages issues 2024-07-27 20:29:38 +02:00
Chris Mayo
53e613fe46 Copy current icon theme name to the fallback on startup 2024-07-25 19:21:25 +01:00
wmayer
dca41751f7 Qt6: Fix MinGW build 2024-07-25 20:09:06 +02:00
Syres916
be3dc20075 [Gui] Add missing checked property 2024-07-25 18:50:46 +01:00
Syres916
f5d46d6eee [Gui] Correct checkbox checked states 2024-07-25 15:04:04 +01:00
Chris Mayo
969e5c2f3c Remove icon ThemeSearchPaths option on Linux
ThemeSearchPaths option was originally introduced in:
f640562b98 ("Option to opt-out from using a Linux desktop icon theme.", 2020-01-26)

It was set on by default in:
f45a4de3ee ("Gui: Use FreeCAD supplied icons on Linux by default", 2024-06-26)

The key effect of the option is to select the FreeCAD-default icon theme.
The code also unnecessarily resets QIcon::themeSearchPaths,
":\icons" is always included in the default search paths [1],
when when using QAdwaitaDecorations causes window frame control icons
not to be displayed:

  (qt.qpa.qadwaitadecorations) Failed to find an svg icon for  "window-close-symbolic.svg"
  (qt.qpa.qadwaitadecorations) Failed to find an svg icon for  "window-minimize-symbolic.svg"
  (qt.qpa.qadwaitadecorations) Failed to find an svg icon for  "window-maximize-symbolic.svg"
  (qt.qpa.qadwaitadecorations) Failed to find an svg icon for  "window-restore-symbolic.svg"

A different default icon theme can still be chosen with the Name option.

[1] https://doc.qt.io/qt-6/qicon.html#themeSearchPaths
2024-07-23 19:26:14 +01:00
luzpaz
bc150dc73c Fix trailing newlines and minor typo fixes 2024-07-23 16:16:30 +02:00
Syres916
72829d07b4 [Gui] Overlay set hide in non 3D view to be true/checked 2024-07-22 11:13:11 -05:00
MisterMaker
1058e67422 Stylesheet fixes part trois. (#15471)
* fixes Qtoolbox for Freecad CAM

https://github.com/FreeCAD/FreeCAD/issues/14745#issuecomment-2231031485

* Removed offset because of Linux issues.

* fix for to dark cells in propetties panel

* fixed constrain colors in sketcher and arros tabbar.

* tabbar fixes

* This fixes the checkered scrollbar issue

* This fixes the spinbox arrow which had a gap.

* misses somethings in the overlay stylesheets.

* typos

* fixed some overlay issues

* update sketch uncontrained colors

* trying to fix the arrow size

* fixes for treeview

* Update Light Theme + Dark Background.qss

fix for edit text field

* updated checkmarks names and scaled them down.

* Update FreeCAD Dark.qss

oopsie wrong color

* Update icons classic.svg

icons files for the icons

* fix for table edit
2024-07-22 11:12:21 -05:00
wmayer
8a4aa75dec PD: Fix crash when pressing ESC on chamfer/fillet dialog 2024-07-22 10:53:31 -05:00