Commit Graph

39 Commits

Author SHA1 Message Date
Chris Hennes
6a458b5ed0 TD: Fix capitalization of Console calls 2025-05-08 21:08:45 +02:00
bofdahof
ba2c2ca5ad Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
jonzirk76
35bae9a3ff Moved DrawUtil.cpp member functions to DrawViewPart.cpp
Updated ownership of member functions & updated headers

Removed redundant ownership lines

Removed reference to removed ownership line

Removed owner from function head

static reference removed from header file, function heads updated

attempt to fix CosmeticExtension.cpp

attempt to fix CosmeticExtension.cpp #2

attempt to fix CosmeticExtension.cpp #3

CosmeticExtension.cpp refactored based on DrawUtil member functions move
2025-04-07 11:07:52 +02:00
j-hap
80b0c72829 TechDraw: Fix double free when resetting line formats 2025-03-04 18:41:29 +01:00
Benjamin Bræstrup Sayoc
97b34f9c57 Remove magic number and hard type enums in Geometry.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
Benjamin Bræstrup Sayoc
52fe0eec53 [TechDraw] Return logic simplification (#16504)
* [TechDraw] AppTechDrawPy.cpp return logic simplification

* [TechDraw] CosmeticExtension.cpp return logic simplification

* [TechDraw] DrawBrokenView.cpp return logic simplification

* [TechDraw] HatchLine.cpp return logic simplification

* [TechDraw] LineGenerator.cpp return logic simplification

* [TechDraw] Preferences.cpp return logic simplification

* [TechDraw] ShapeExtractor.cpp return logic simplification

* [TechDraw] MDIViewPage.cpp return logic simplification

* [TechDraw] QGILeaderLine.cpp return logic simplification

* [TechDraw] QGIRichAnno.cpp return logic simplification

* [TechDraw] QGTracker.cpp return logic simplification
2024-11-18 16:14:47 -03:00
luzpaz
a633be7342 Fix various typos
Found via codespell.
2024-11-15 20:18:46 +01:00
WandererFan
50f970efd7 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
wandererfan
f530f1a5c8 [TD]fix fail on undo of cosmetic delete 2024-03-27 13:23:45 -04:00
wandererfan
a48490f518 [TD]fix centerline rotation 2023-09-27 12:24:21 -04:00
wandererfan
9084bfd81a [TD]Rotate CosmeticEdge with View 2023-08-19 17:18:42 -04:00
wandererfan
6eae743361 [TD]rotate CosmeticVertex with View 2023-08-19 17:18:42 -04:00
wandererfan
a94e5b0235 [TD]resolve merge conflicts 2023-08-19 13:28:53 -04:00
Benjamin Bræstrup Sayoc
7c7823dd9b [TechDraw] Improve CosmeticExtension.cpp typing
Make type safe by using const keywords when appropriate and improve memory handling by using references when appropriate.
2023-08-19 13:28:53 -04:00
wandererfan
b1e03c2292 [TD]fix #9265 - memory leak in cosmetic features 2023-08-18 15:18:42 -04:00
wandererfan
6565732207 [TD]move dvp cosmetic functions to extension 2023-08-10 10:17:22 -04:00
Benjamin Bræstrup Sayoc
a93060c6b9 [TechDraw] Simplify return logic
Normal warmup
2023-04-11 13:49:57 -04:00
Benjamin Bræstrup Sayoc
6df0a20214 [TechDraw] Simplify return logic
Easy warmup
2023-04-11 13:00:45 -04:00
Benjamin Bræstrup Sayoc
0bfae905d9 [TechDraw] Move CenterLine into own file 2023-04-06 13:51:35 -04:00
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
Uwe
01c7df9f4f [TD] A* - C*: remove unused includes
- also sort includes
- also sort PreCompiled.h
2022-10-03 23:05:36 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Benjamin Bræstrup Sayoc
bbbc044934 [TechDraw] Remove deprecated replaceGeomFormat 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
ac8099d1f6 [TechDraw] Remove deprecated replaceCenterLine 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
b36d6b53cd [TechDraw] Remove deprecated replaceCosmeticEdge 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
a017cb41bc [TechDraw] Remove deprecated replaceCosmeticVertex 2022-08-02 16:09:54 -04:00
Uwe
b2bb479788 [TD] last part of removal of superfluous nullptr checks 2022-07-20 12:17:16 +02:00
Uwe
b81d7e4864 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Wanderer Fan
1c97b3d5df [TD]fix ExtendShorten handling of CenterLine 2022-04-23 18:43:27 -04:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
3fa4a321d3 TD: replace usage of raw pointers of Vertex and Face with shared pointers.
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
wandererfan
6734bffcc6 [TD]Eliminate replace fcns for Cosmetic objs 2020-05-16 07:42:45 -04:00
wandererfan
eaf2f0e8a4 [TD]Simplify Cosmetic List & PyObject handling 2020-05-16 07:42:45 -04:00
wandererfan
8cbcd243e6 [TD]Py routines for CenterLines 2019-12-16 20:36:10 -05:00
wandererfan
b54212f82c [TD]Python routines and extension for line formating 2019-12-16 20:36:10 -05:00
wandererfan
a71bc8f734 [TD]Python routines and extension for Cosmetic Edges 2019-12-16 20:36:10 -05:00
wandererfan
f63cd9255a [TD]Python routines & extension for CosmeticVertex 2019-12-16 20:36:10 -05:00