Commit Graph

106 Commits

Author SHA1 Message Date
donovaly
9213dace6b [TD] fix unit conversion for dimensions
as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473
my commit 957ce2f38787 introduced a regression because now units are no longer converted when the unit is displayed.

This PR fixes this.
2020-12-21 01:27:41 +01:00
Aapo
2077709329 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
donovaly
36686f78b1 [TD] treat dimensions the same way, no matter if with unit or not
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=52545&start=40#p454483
2020-12-05 03:58:39 +01:00
Mark O'Donovan
e88dff8902 Remove unused variable in DrawViewDimension.cpp 2020-12-04 17:13:56 +01:00
donovaly
7f856a251f tolerances can be negative, thus the decimal precision check must be adapted 2020-12-03 15:50:06 +01:00
donovaly
a2b523fb39 [TD] fix unit mismatch bug
- also make global decimal option italic since it only affects new dimensions
- also fix a typo in UnitsApi.h
2020-12-03 15:50:06 +01:00
wmayer
d284a343a8 [TD] add an enum to avoid to work with plain numbers 2020-12-02 16:42:21 +01:00
wmayer
2c599495a9 [TD] use PropertyQuantity for OverTolerance and UnderTolerance and add backward compatibility 2020-12-02 16:42:10 +01:00
aapo-aapo
3935ef8b8f @aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review.
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2020-12-02 16:38:21 +01:00
Aapo
40bd4b806f [TD] Add tolerance format specifiers and arbitrary tolerances. 2020-12-02 16:38:21 +01:00
Aapo
eb22a14a3b [TD] Make tolerance labels use the same formatValue() conversion as dimension labels. Support MultiValueSchemas for tolerances, too. 2020-12-02 16:38:21 +01:00
Aapo
e7b4d9ed99 [TD] Refactor DrawViewDimension getFormatedValue() into two functions. 2020-12-02 16:38:21 +01:00
Aapo
5ed116283c Refactor code in DrawViewDimension::getRefType() shorter and simpler. No functional change except subelement sizes > 3 are supported, even though they are not supposed to happen. 2020-11-19 13:40:42 +01:00
Aapo
deab8fc965 [TD]fix V2E DistanceX,Y to always use the closest point of edge to the vertex. 2020-11-18 14:54:44 +01:00
wandererfan
247a74d73d [TD]fix V2E DistanceX,Y 2020-08-30 18:59:11 -04:00
wmayer
8ceac9cf55 PVS: V523 The 'then' statement is equivalent to the 'else' statement 2020-07-18 10:59:27 +02:00
wandererfan
de93a81768 [TD]Treat Imperial1/USCustomary as single value schema 2020-06-15 13:57:55 -04:00
wandererfan
0e4d893651 [TD]missing prefix/suffix for compound schema 2020-06-15 13:57:55 -04:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
7100eb4ba3 [TD]synchronize defaults in code and prefs 2020-03-16 08:57:08 -04:00
Tobias Ellinghaus
ccabe852b3 TD: Fix decimal separator of dimensions
When the system separator isn't '.' we want to make sure to use it.
2020-03-14 08:04:49 -04:00
wandererfan
fd9183727e [TD]fix crash on RenderMode = NONE 2020-03-11 18:17:46 -04:00
wandererfan
db97daf0e0 [TD]expose dimension arrow position to Python 2020-03-02 08:37:19 -05:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wandererfan
6886621008 [TD]fix potential nullptr while restoring 2019-12-30 18:20:48 -05:00
wandererfan
9be2af54d3 [TD]improve presentation of tolerance text 2019-12-18 07:01:46 -05:00
wandererfan
ed6adae509 [TD]fix dim text for multi value schemas 2019-12-05 07:10:08 -05:00
wandererfan
e64929de14 [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
cc1392ed73 [TD]Always show degree symbol 2019-11-07 16:59:10 -05:00
wandererfan
b34eb9de77 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
251e16b6f1 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
wandererfan
4b55f53334 [TD]Fix Dimension prefix/suffix 2019-10-20 15:36:59 -04:00
wandererfan
b1e61bcae7 [TD]Improve tolerance formatting 2019-10-11 09:16:41 -04:00
Tomas Pavlicek
39518f8dff Complete remake of drawing dimensions 2019-09-25 15:20:14 +02:00
wandererfan
9828655f48 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
5d601c1cdd [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
fd3d6d8091 Hide Caption property where not applicable 2019-06-01 15:59:26 -04:00
wandererfan
af0271691c Improve radius/diameter dims for ellipse,spline 2019-05-13 12:29:15 -04:00
wandererfan
c5ca7ad05e Fix Error messages for bad references 2019-04-26 06:36:56 -04:00
wandererfan
40c0347b25 Fix crash on Dimension with corrupted References 2019-04-24 19:52:39 -04:00
babaroga
5cb48e5360 FIX:TD-If "Show units" is off degree symbol is missing on angular dimensions
+ Remove space between dimension value and degree symbol
2019-04-21 19:51:57 -04:00
wandererfan
2d13b2d7cd Fix missing radius/dia on ft-in dimensions 2019-04-19 19:15:52 -04:00
babaroga
2cc85fed64 FIX: Prevent situation where default format entered in preferences, overwrites prefixes on eg. circular dimensions 2019-04-17 08:26:47 -04:00
wandererfan
11abf09299 Add Preference for Dimension Format 2019-03-28 10:44:33 -03:00
wandererfan
d10e06039d Display correct symbols for Minute/Second
- the ImperialCivil unit schema uses "M" for angular
  minutes and "S" for angular seconds. These must be
  replaced by ' and ".
2018-12-06 08:57:17 -03:00
wmayer
d7ec2b1368 Replace Base::Exception with appropriate subclass 2018-11-14 19:42:10 +01:00
wandererfan
2a85174148 Fix #3634 Lost formatSpec on save/restore 2018-10-13 02:10:53 +02:00
wandererfan
4bcfb4a1cd Fix #3623 Display of Ft/In Dimensions 2018-10-11 21:59:20 +02:00
wandererfan
8f35f4c956 Add 3Point Angle Dimension 2018-10-02 09:42:16 -03:00