kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
23,972 Commits 41 Branches 6 Tags
1087d90f07d5b80cf6074b8d954babc74aec33ec
Commit Graph

18748 Commits

Author SHA1 Message Date
Markus Lampert
1087d90f07 import DraftTools if Snapper isn't loaded yet (before using it) 2021-02-07 12:39:21 -08:00
David Osterberg
b0486c4808 FEM: Fix svg icons that causes warning messages 
I opened the icons in InkScape, converted the text to a path, and saved.
 2021-02-07 19:07:39 +01:00
Zheng, Lei
0dd091e8c4 Part: allow TaskAttachmentEditor to install attacher extension on demand 2021-02-07 15:39:12 +01:00
luz paz
9b440f9b26 LGTM: remove redundant variable assignment 
ref: ddeaa48851/files/src/Mod/Spreadsheet/App/Spreadsheet_legacy.py (x687bc63f783c60bd):1
 2021-02-07 13:42:55 +01:00
wmayer
18dc155b3f Mesh: [skip ci] fix MeshPy::trim 2021-02-07 13:12:23 +01:00
Zheng, Lei
97a5a2f2af Mesh: minor change to exporter based on suggestion 2021-02-06 17:13:36 +01:00
Zheng, Lei
a01e2aaf8f Mesh: refactor mesh exporter for better support of Link 2021-02-06 17:13:36 +01:00
wmayer
0d5b38385c [skip ci] Do not throw plain C string as exception 2021-02-06 15:52:21 +01:00
David Osterberg
bad8257370 PartDesign: Fix sign error in Helix 2021-02-06 08:22:37 +01:00
Abdullah Tahiri
cc75dc2ab0 Sketcher: Fix wrong diameter reference constraint value when blocked 
====================================================================

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=474276#p474276
 2021-02-06 06:22:30 +01:00
Aapo
f0992574bd [TD] ShapeExtractor.cpp: Fix linked View source bug, link targets were translated but not scaled in TD. 2021-02-05 22:41:09 +01:00
David Osterberg
a819a89ede PartDesign: fix regression in Helix 2021-02-05 20:55:34 +01:00
Aapo
462dc33d48 [TD] Fix XSource handling of sub-objects of links to another document(s) in TD Views. 2021-02-05 19:19:24 +01:00
David Osterberg
a45e6038b7 PartDesign: [Helix] Fix helix starting point bug 2021-02-05 19:17:00 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
sliptonic
cd2005adee Merge pull request #4333 from Russ4262/remove_feature_expand_profile 
[Path] Remove `Expand Profile` feature from Profile op
 2021-02-05 10:47:43 -06:00
wmayer
9572ceab3e Part: [skip ci] fix -Wreorder 2021-02-05 17:26:47 +01:00
donovaly
09fd3dbffa [Part] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for Part

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Part dialogs that don't already use a unique_ptr.
 2021-02-05 17:16:20 +01:00
donovaly
ade2857ba3 [Sketcher] make more pointers to the UI std::unique_ptr 
addendum to PR #4362

(Same as PR #4293, just for Sketcher

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Sketcher dialogs that don't already use a unique_ptr.)
 2021-02-05 17:14:24 +01:00
wmayer
bd587a8a45 Surface: re-implement closed() in TaskFilling 2021-02-05 16:37:00 +01:00
Yorik van Havre
321fd7c840 Merge pull request #4215 from hyarion/feature-spreadsheet-equal-prefix-for-expressions 
[Spreadsheet] Only evaluate cell values when prefixed with '='
 2021-02-05 13:29:57 +01:00
donovaly
6f25fa6bb8 [TD] make more pointers to the UI std::unique_ptr 
addendum to PR #4293

(as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for remaining TD dialogs that don't already use a unique_ptr.)
 2021-02-05 13:24:21 +01:00
Yorik van Havre
ff8e751f42 Merge pull request #4356 from luzpaz/LGTM-ArchPanel 
[0.19][ARCH] Arch: Fix LGTM warning of missing param for translate() in ArchPanel.py
 2021-02-05 13:19:00 +01:00
Amritpal Singh
7d5ce50fdd Draft: Fix bug in getCubicDimensions function 2021-02-04 22:57:31 +05:30
wmayer
4c7395cabc Qt4: [skip ci] fix build failure 2021-02-04 15:31:06 +01:00
wmayer
d48718fd0d FEM: add basic support of Nastran-95 2021-02-04 13:56:15 +01:00
ceanwang
f34eff7946 Changed comment for free format CTETRA element 2021-02-04 13:25:13 +01:00
ceanwang
1549ccc2a0 Added readNastran95() 2021-02-04 13:25:13 +01:00
ceanwang
0166fcd535 Added readNastran95() 2021-02-04 13:25:13 +01:00
David Osterberg
cb2da22e86 PartDesign: New features AdditiveHelix and SubtractiveHelix 
These features, based on the code for the Pipe class, allow the user
to simply create a helical sweep within PartDesign workbench.

Sample application is threads, springs, coils, augers, etc.

Also, remove needless requirement for positive cone angle on helixes.

Thanks to @bitacovir for helping with the icons
Thanks to @chennes for review
Thanks to @vosk for review
Thanks to @wwmayer for review

Enforce that links stay within scope for ProfileBased features
This also ensures that the Body itself is not used for creating features within
the body, causing a "Graph not a DAG" error.
 2021-02-04 13:01:12 +01:00
Pierre LeMoine
67aee7cd21 Transform patterns can be created from multiple base features 
The infrastructure/piping seems to have been in place for a long while.
Not tested for all variations of pattern transforms.
The major enabler was removing the `break`.
Some extra piping added to let the code at call-site decide if to select multiple features or not.
 2021-02-04 11:58:47 +01:00
Greg V
3991a93d5a Sketcher: [skip ci] fix computing of hotspot of sketcher icons on Wayland 
Restrict the hotspot multiplication on unix platforms to X11 (xcb platform)
 2021-02-04 10:45:33 +01:00
donovaly
c88bee029b [Sketcher] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for Sketcher

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Sketcher dialogs that don't already use a unique_ptr.
 2021-02-04 10:37:44 +01:00
j
140dcc3134 Sketcher: Group tests in different directories 2021-02-04 08:10:28 +01:00
j
c8d0ee8e54 Sketcher: new fillet UI command 2021-02-04 08:10:28 +01:00
j
038d5560a7 Sketcher: new Fillet - icon 2021-02-04 08:10:28 +01:00
j
92041a7376 Sketch: new fillet Python support 2021-02-04 08:10:28 +01:00
j
91881c8f89 Sketcher: Constraint documentation 2021-02-04 08:10:28 +01:00
j
7413a8a717 Sketcher: Preserve corner and constraints for sketch fillets 
Currently the sketch fillet tool deletes any constraints associated with
the two lines to be filleted. By leaving a vertex at the intersection,
we can instead preserve most constraints in reasonable ways.

Sketch fillet horizontal and vertical point-to-point constraint support
Also better future compatibility for point constraints, and some minor tweaks.
 2021-02-04 08:10:28 +01:00
sliptonic
fde9048778 Merge pull request #4262 from Schildkroet/adaptive_improve 
[PATH] Adaptive improve helix entry
 2021-02-03 19:02:38 -06:00
luz paz
19d0e1123f Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts 
https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
 2021-02-03 21:58:47 +01:00
David Osterberg
c19341b866 PartDesign: Allow selection of sketch plane by double click in picker dialog 
Thanks to @0penBrain for solving a tricky segmentation fault
 2021-02-03 16:46:47 +01:00
luz paz
058e54a5b7 Arch: Fix LGTM warning of missing param for translate() in ArchPanel.py 
Even though this is ignored per the docs[1], LGTM complains[2] about it. This commit adds the superfluous param. Note: there is precedent in ArchReference.py[3] and ArchWall.py[4].
 
 [1]https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Draft/draftutils/translate.py#L73-L78  
[2] 17db14c970/files/src/Mod/Arch/ArchPanel.py (L32)  
[3] 50f5c6ef9a/src/Mod/Arch/ArchReference.py (L39)  
[4] 50f5c6ef9a/src/Mod/Arch/ArchWall.py (L42)
 2021-02-03 10:28:21 -05:00
donovaly
09385d9d00 fix issue reported by @chennes 
also fix annoying variable naming - different variables representing different types should not have the same name

also update a comment according to depending PRs
 2021-02-03 16:24:01 +01:00
donovaly
2a6d30da27 [PD] hole fix custom cut handling 
This PR is based on PR #4344 and a spin-off of PR #4337. It fixes:

We have normed screw head cuts. These values can be overridden but we must store the info about the overriding. Why? - because when you have e.g. made a custom change to a normed countersink and then change to another countersink norm, you would either not get the values defined in the norm or you get these values but loose e.g. your depth settings
 2021-02-03 16:23:28 +01:00
donovaly
c5fe2589d5 [PD] fix UTS clearance holes 
This PR is based on PR #4343 and a spin-off of PR #4337. It fixes:

- the bug that we did not use the normed clearance hole diameters for UTS holes
- missing recompute when changing existing hole from Metric to UTS type
 2021-02-03 16:19:24 +01:00
donovaly
19605200a1 [PD] hole dialog UI fixes 
This PR is the first in a series of probably 3 PRs to fix known hole dialog bugs.

This one fixes:

- the .ui file issues
- readonly status issues of some widgets/properties (e.g. when the hole is through all, disable drill point settings)
- the bug that updateHoleCutParams() overwrote the previously correctly determined hole diameter
- just a trifle: change a function name to fit into the naming scheme
 2021-02-03 16:14:36 +01:00
wmayer
d65937d338 Part: [skip ci] rename methods in TopoShape that override non-virtual functions of base class 2021-02-03 16:10:38 +01:00
donovaly
69f2f3b9e1 [PD] fix typo in iso7046.json 
This mistake was introduced by me in commit 51c9640f
 2021-02-03 15:08:30 +01:00
donovaly
8a3cc86d0c [TD] fix color change for dimensions 
This PR fixes issue C reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=55008#p472939
- the changed color must also be applied to the dimension line and arrows
 2021-02-03 14:11:44 +01:00