Commit Graph

39339 Commits

Author SHA1 Message Date
tetektoza
10d476a35b BIM: Cache the tree elements beforehand and hide only necessary ones 2025-05-13 11:03:05 +02:00
tetektoza
8c3439e992 BIM: Hide all objects that aren't selected during Isolate
Currently if user selects an item and does `Isolate` operation on it in
BIM, everything is being hidden if the item was inside another container
(like Building).

This is because we are prioritizing on hiding parents of current object
if they are not the selected ones, which is causing the child of the
parent to be hidden as well (duh).

So, this patch fixes isolate method to hide all other parents and their
childs. If they are not a parent of our child under selection -> hide
them and proceed further. If we are processing parent of our selection,
just hide anything on current level that is not our selection while
leaving parent intact.
2025-05-13 11:03:05 +02:00
Slawomir Gonet
1b0a3639a0 CAM: Fix Existing Stock from resetting
Due to a Qt signal setup, the clone object for Existing Stock stock type
was recreated every time the Job properties dialog was opened (during the
stock candidates list population).

This fix blocks the Qt signal from being emitted during the dropdown
population.
2025-05-13 09:35:04 +02:00
tarman3
dc9644d6e4 CAM: Simulator - Improve camera limits 2025-05-13 08:43:59 +02:00
Chris Hennes
cfb6368026 Gui: Eliminate double->float truncations
Our GUI code uses a mix of floats and doubles to represent floating
point numbers, and in a few places interchanges them in a way that
causes an invisible loss of precision. Change the double precision
"default" values to float defaults, and use the appropriate value for
pi.
2025-05-13 08:37:06 +02:00
Furgo
808773b15e BIM: change Snapping menu order for workplane commands 2025-05-12 22:32:26 +02:00
Furgo
79cb161537 Draft: add more context to select plane command message 2025-05-12 21:27:30 +02:00
Furgo
a5848ef578 BIM: Add working plane selection command 2025-05-12 21:27:30 +02:00
Chris Hennes
63de22e622 Gui: Manually specify correct QVariant conversion
There are multiple possible conversion paths for a QPixmap to QVariant,
which results in a compiler warning. Explicitly specify the path we
intend to silence the warning.
2025-05-12 18:17:48 +02:00
Chris Hennes
0b0f3aaa1e Gui: Make variable more local
Eliminate a compiler warning about an unused variable by making the
variable more local to the point-of-use.
2025-05-12 18:16:56 +02:00
Chris Hennes
c0ddaf4820 Gui: Remove default init of shared_ptr
`std::shared_ptr` default-initializes to `nullptr`, so there is no need
to do it manually, and in the current code the initialization is in the
wrong order (so generates a compiler warning).
2025-05-12 18:16:32 +02:00
Chris Hennes
f9dbaac7aa TD: Fix hatch size constraint
Commit 1155f0d7 changed `UnitsApi::getDecimals()` from `int` to
`size_t`, which changes the meaning of the negation since it is now
unsigned. Cast it to an integer before the negation to restore the old
behavior.
2025-05-12 18:11:15 +02:00
FEA-eng
ff4620ace2 FEM: Update DlgSettingsFemCcx.ui 2025-05-12 11:09:59 -05:00
sliptonic
349b879979 Merge pull request #21193 from davidgilkaufman/adaptive_helix_fixes
[CAM] Adaptive helix fixes
2025-05-12 11:09:16 -05:00
tetektoza
03f41eb11f BIM: Update tooltip for Activate button 2025-05-12 18:00:52 +02:00
tetektoza
3dfa5926d2 BIM: Introduce Activate for BIM Views
Currently there's no option for selecting active working plane other
than selecting `DoubleClickActivates` property on a BIM Level.

So, this patch adds an additional button for the submenu that BIM Views
provides - to activate working plane of the selected item.
2025-05-12 18:00:52 +02:00
tetektoza
e13d0787d3 BIM: Fix missing IFC attributes for certain BIM objects
Some of the objects, like Column, or Beam do not contain `IFC
Attributes` if they are initially created.

As it turns out, they are not being created as we are checking for
`onDocRestoredDone` attribute, which is assigned in `onDocumentRestored`
function. Since users can usually just not restore a document, but just
play on a newly created document, this attribute won't be available,
thus we won't be going through whole `onChanged` logic which populates
`IFC Attributes`.

To preserve current functionality of this additional parameter and not
cause the previous errors to happen, this patch just changes from the
custom flag to globally available `Restoring` flag which tracks document
being restored more reliably.
2025-05-12 17:50:11 +02:00
Roy-043
63c81c2146 BIM: close BIM_Library task panel on doc close
Fixes #21179.

This PR uses the built-in solution to close the task panel.

I was not aware of this feature before. My 2 previous PRs related to the closing of task panels, #20719 and #21073, will (largely) have to be reverted/redone in favor of this solution.
2025-05-12 17:48:39 +02:00
Roy-043
fcf5f8a089 Draft: aux.fake_function should not overwrite functions
The `aux.fake_function` is used in the Draft unit tests as a substitute for functions that, in most cases, do not yet exist. But in test_modification.py it would overwrite Draft.extrude leading to issues with BIM unit tests.

See:
https://github.com/FreeCAD/FreeCAD/pull/21134#issuecomment-2869178563
2025-05-12 10:45:45 -05:00
mosfet80
8ba6d38bdd [Mod] Drawing remove (#20419)
* [Mod] Draw remove

removed deprecated drawing module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-12 17:43:25 +02:00
sliptonic
e699fe37d8 Merge pull request #20873 from tarman3/startpoint
CAM: Fixes PickStartPoint
2025-05-12 10:40:57 -05:00
marcuspollio
33c7efae85 BIM: fix some imports and cleanup miscellaneous (#20914) 2025-05-12 17:40:12 +02:00
Chris Hennes
952485dcbb Merge pull request #19907 from benj5378/getAttribute
Base: make getAttribute template
2025-05-12 10:39:55 -05:00
Furgo
68987874b3 BIM: set DoubleClickActivates property true by default 2025-05-12 17:36:29 +02:00
sliptonic
51cbbf37db Merge pull request #21265 from LarryWoestman/refactor
CAM:  updated opensbp post to work with current Processor.py
2025-05-12 09:32:43 -05:00
sliptonic
3b3d41d114 Merge pull request #20828 from tarman3/DressupPathBoundary-KeepToolDown
CAM: Keep tool down in DressupPathBoundary
2025-05-12 09:07:44 -05:00
tarman3
1648ee6cdc CAM: PickStartPoint fixes 2025-05-12 16:57:32 +03:00
tarman3
c76357c148 CAM: Simulator - Decrease speed button (#21222)
* CAM: Simulator - Decrease speed button

* CAM: Simulator - Move slider upper

* CAM: Simulator - Changed speed icons
2025-05-12 08:57:30 -05:00
Kacper Donat
cf4357ed38 Gui: Fix handling - character in OVP 2025-05-12 08:55:09 -05:00
sliptonic
87de9cda77 Merge pull request #21177 from dbtayl/fix_adaptive_repeated_cuts
CAM: Fix adaptive repeating cuts excessively at various depths
2025-05-12 08:15:55 -05:00
sliptonic
1f0b47f79e Merge pull request #21128 from jffmichi/fix_array_dressup
CAM: bring Array dressup in line with existing dressups
2025-05-12 08:10:31 -05:00
tarman3
43bcc5820e CAM: Simulator - Add document name to title 2025-05-12 08:22:44 +02:00
Lawrence Woestman
7b882c394c CAM: updated opensbp post to work with current Processor.py 2025-05-11 15:39:49 -07:00
tarman3
c2df7a83db Macro: Button to open folder with macros 2025-05-11 21:54:07 +02:00
Benjamin Bræstrup Sayoc
2b6e73c29d Everywhere: clean up getAttribute conversions 2025-05-09 15:54:57 +02:00
Benjamin Bræstrup Sayoc
2b1aec0041 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
pre-commit-ci[bot]
cd3d03c419 CAM: clean up code 2025-05-09 09:53:34 -04:00
David Kaufman
9723d95d4c CAM: add spiral-out to full radius at the bottom of the cone helix 2025-05-09 09:53:34 -04:00
David Kaufman
31baab0870 CAM: delete dedicated cone helix implementation, merge into standard implementation 2025-05-09 09:53:34 -04:00
David Kaufman
d83730b3be CAM: Allow helix angles between 0 and 1 degree 2025-05-09 09:53:27 -04:00
tarman3
27f51b0b4c CAM: Simulator window title 2025-05-09 12:50:32 +02:00
Pieter Hijma
ca6fe75f43 Doc: Fix small doc warnings in ExtensionContainer 2025-05-08 17:52:33 -05:00
Pieter Hijma
fe4c79a046 Doc: Improve App::Extension documentation 2025-05-08 17:52:33 -05:00
Rayno Jiang
a5a6ed55e2 Sketcher: Scaling of a sketch containing BSplines doesn't work (#20943)
* [FreeCAD-20111] Sketcher: Scaling of a sketch containing BSplines doesn't work
When we executing Scale cmd we don't will lose knots information from shape geometry and it cause the scaled spline build with issue knots and it lead solver gets compute issue.
1. Add string format function PythonConverter::makeArryString(const std::stringstream& ss) for processing the control pnts string, mults string and knots string.
2. Add mults and knots information for python obj to make BSplineCurvePy::buildFromPolesMultsKnots(Args...) initialized Geom_BSplineCurve correctly.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. fix typo
2. Add wights info to keep spline shape after convert from python object

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. remove static function makeArrayString() from PythonConverter
1. Add template function makeSplineInfoArrayString() to generate string for cleaner code.
2. change python string format as review suggestion

* use fmt format

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fixes #20111

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-09 00:02:33 +02:00
xtemp09
30498b7b48 Gui: Add switching to the document when closing FreeCAD (#21135)
* Add switching to the document when closing FreeCAD

Closes #20997

* Some update of language

* camelCase every variable name used
2025-05-08 23:59:11 +02:00
Syres916
fcd454c1da [App] find Pyside and Shiboken versions whether it be Qt5 or Qt6 2025-05-08 23:39:51 +02:00
Stefan Tröger
97d8608557 FEM: Fix test if VTK or VTK python is not available (#21168)
* FEM: Fix test if VTK or VTK python is not available
* FEM: Make test work if vtk python not installed
2025-05-08 15:55:45 -05:00
Chris Hennes
6a458b5ed0 TD: Fix capitalization of Console calls 2025-05-08 21:08:45 +02:00
theo-vt
777d20b812 PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030)
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
2025-05-08 16:47:26 +00:00
WandererFan
3cabb3f7b8 [TD]Allow non-shape views to have children (#20768) (#21099)
* [TD]Allow non-shape views to have children (#20768)

* Update src/Mod/TechDraw/App/DrawView.cpp

Review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/App/DrawView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-08 09:18:09 -05:00