Commit Graph

30044 Commits

Author SHA1 Message Date
Paddle
17f4109358 Add preference for OVP visibility. 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5c2a55ade7 Sketcher: Update DSHs to set value via framework only when they are visible 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
0282d3844a Sketcher: DrawSketchController - Extend framework to support hiding OVPs via preference 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5873403254 Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
c09793e811 Sketcher Gui: DrawSketchController - lints 2023-11-08 15:20:13 +01:00
wmayer
a28b2dcf37 PD: fixes #11197: If bounding box of Body is activated it will be done for each sub-feature 2023-11-08 10:38:42 +01:00
Abdullah Tahiri
e235a1b795 Sketcher: Handling of right mouse button during handler execution
=================================================================

    Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
    delegates the action to DrawSketchHandler.

    DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

    DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
    in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Abdullah Tahiri
9cb6fa0df7 Sketcher: Handling of ESC keypress during handler execution
===========================================================

Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
delegates the action to DrawSketchHandler.

DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Paddle
fc472601e4 EditableDatumLabel : Fix issue where the spinbox would get in the way of the cursor for angle. For example line angle. 2023-11-07 15:36:21 +01:00
Paddle
029fd10bf1 Offset DSH : various fixes 2023-11-07 15:36:21 +01:00
Paddle
2aa67a0b38 Rectangle DSH : fix a bug when trying to make inward thickness. 2023-11-07 15:36:21 +01:00
Paddle
57524b24ef Rectangle DSH : Fixes #11287. Issue where the spinbox for frame thickness doesn't get focus. 2023-11-07 15:36:21 +01:00
Paddle
d272a55310 Rectangle DSH : Fixes #11285, for frames two parallels constraints were missing. 2023-11-07 15:36:21 +01:00
Paddle
0c9c550703 Rectangle DSH : change names or modes. 2023-11-07 15:36:21 +01:00
Paddle
870c358cee Fix focus passing between OnViewParameters with tab. 2023-11-07 15:36:21 +01:00
Paddle
1b55c56f3a Fix bug nParameter is not initialized based on construction methode.
Also fix bug construction methode combobox is not at correct index on tool start if not first methode.
2023-11-07 15:36:21 +01:00
mosfet80
834b2687b9 [planegcs] Removed unused code. (#10684)
* Revert cleanplanegcs: removed unused code, removed redefinition of pi
* Sketcher: Switch pi refs to double and constexpr
* Modify code to use the new pi constant immediately

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2023-11-06 14:35:59 -06:00
Paddle
a3568333a4 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
wmayer
944d5a1946 JT: clean-up module and move to PyCXX API 2023-11-06 20:07:06 +01:00
pavltom
f70454cc14 [TechDraw] - Fix issue #10094 2023-11-06 12:43:28 -05:00
Roy-043
592547fd60 Draft: renaming of anno style could fail
The error occurred if the style was in use.
2023-11-06 11:40:24 -06:00
Roy-043
1bc942d73a Draft: improved props_changed_placement_only function
There are more objects where `props_changed_placement_only` should always return `False`. The common denominator seems to be a non-empty OutList.

https://github.com/FreeCAD/FreeCAD/issues/8771
https://forum.freecad.org/viewtopic.php?t=82436
2023-11-06 18:33:13 +01:00
sliptonic
74a8820dfd Merge pull request #11248 from alromh87/WEDM
Added Path PostProcessor for old WEDM machines
2023-11-06 11:20:55 -06:00
sliptonic
d2be17c29f Merge pull request #11245 from LarryWoestman/staging
Path:  Added typing to the refactored postprocessors.
2023-11-06 11:19:34 -06:00
Chris Hennes
aaa0db3867 Merge pull request #11231 from DeflateAwning/http-cleanup
Find and replace http://freecad to https://freecad
2023-11-06 11:16:13 -06:00
Chris Hennes
cf84c171e6 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Roy-043
d72df2f3e2 Draft: PlaneGui: view observer to update the Tray
Related issue:
#5603.

The view observer starts/stops when the Draft workbench is activated/deactivated.

Additionally:
* Minor improvements to _update_grid and _update_gui.
2023-11-05 21:42:44 +01:00
Roy-043
51fcdc16f9 Arch: Fix issue with getSceneGraph
Same issue as in #8171
2023-11-05 20:48:43 +01:00
Adrian Insaurralde Avalos
9c093ba041 Sketcher: fix Line tool settings mode name 2023-11-05 07:36:22 +01:00
Abdullah Tahiri
1de8d9f10f Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
882262bfa8 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
LarryWoestman
2a2ff73c2c Path: Added typing to the refactored postprocessors. 2023-11-04 11:18:12 -07:00
Paddle
dc2da5aba1 Offset fix isActive function. 2023-11-04 08:58:50 +01:00
Paddle
b4a54abed5 Polygon DSH : Small syntax improvements. 2023-11-04 08:58:50 +01:00
Paddle
785ec817c8 Line DSH : syntax and remove potential issues. For example in width+length mode, if user input 0 and 0, instead of validating it will unset the spinboxes. Preventing creation of null lines. 2023-11-04 08:58:50 +01:00
Paddle
3242144128 Rectangle DSH : Fix a bug where 3p rectangle with radius, radius would not apply. Also fix various edge cases. Improve syntax. 2023-11-04 08:58:50 +01:00
Paddle
b72da63139 Offset DSH : Add pointer SVG. Some remove unecessary member initialization 2023-11-04 08:58:50 +01:00
Paddle
5fc39a5add DSDWC : typo 2023-11-04 08:58:50 +01:00
Paddle
aa4a158e0c Prevent passing the focus to a spinbox when it shouldn't.
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
336691cd5a Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key. 2023-11-04 08:58:50 +01:00
Paddle
8788bcc0f4 SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon. 2023-11-04 08:58:50 +01:00
wmayer
2645242bc7 Material: fix Python bindings
* fix reference counting of Python objects
* fix crashes in several methods
2023-11-03 16:41:11 +01:00
wmayer
6eb95ca73c Material: fix compiler warning with Qt6
QVariant::Type is deprecated since Qt 6.0 and shouldn't be used in new code
2023-11-03 16:41:11 +01:00
wmayer
b55aca0501 Material: fix compiler warnings
* unused parameter 'parent' [-Wunused-parameter]
* reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]
2023-11-03 16:41:11 +01:00
wmayer
d48ae99424 Material: fix 'explicitly defaulted copy constructor is implicitly deleted [-Wdefaulted-function-deleted]' 2023-11-03 16:41:11 +01:00
wmayer
015c84066d Material: single-argument constructors must be marked as explicit 2023-11-03 16:41:11 +01:00
wmayer
5accd11c62 Fem: remove re-inserted CMake definitions 2023-11-03 16:41:11 +01:00
wmayer
d8d6783152 Material: fix diagnostic errors with the clang code model 2023-11-03 16:41:11 +01:00
wmayer
2e017ac45a Material: remove several unreferenced variables 2023-11-03 16:41:11 +01:00
wmayer
0f31b1f29b Material: use get_filename_component() instead of cmake_path() to support older CMake versions 2023-11-03 16:41:11 +01:00