Commit Graph

206 Commits

Author SHA1 Message Date
paul lee
dc911dde55 [ArchWall] Fix MakeBlocks to work if Base is Sketch with 1 edge only
To be merged with #4955
2021-08-09 09:06:03 +08:00
Yorik van Havre
82dd05b53d Arch: Remember wall alignment when creating from existing wires 2021-08-03 16:45:07 +02:00
Roy-043
e80a21a26a Arch: Fix Arch_Wall: block joints where put on the wrong side of offset
In the execute method block joints were put on the wrong side of the offset which lead to the first block in each row being larger than intended.
2021-07-07 18:54:34 +02:00
Chris Hennes
9d1958475e [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Abdullah Tahiri
f84df4e944 Arch: Make ArchWall use Sketcher GeometryFacade 2020-12-13 15:36:59 +01:00
luz paz
ccf30d98d2 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Yorik van Havre
eacf3a6b98 Arch: Enabled ellipse-based walls - fixes #3859 2020-10-20 13:13:54 +02:00
Yorik van Havre
78ac2f7b27 Arch: Fixed translation of wall (better version) 2020-10-12 15:58:41 +02:00
Yorik van Havre
1252734a81 Arch: Fixed translation of wall 2020-10-12 15:57:15 +02:00
Roy-043
48218690ce Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
carlopav
41f81b2cff Draft: fixed obj.TypeId output after utils.get_type() change
.


.
2020-09-09 14:13:29 +02:00
Vanuan
874d7d55d1 Fix non-center aligned wall with multimaterial 2020-08-11 12:21:41 +02:00
paul lee
f8584455f8 [ArchWall] Failed if Sketch as Base has Point, now OK
FC Forum Discussion -
https://forum.freecadweb.org/viewtopic.php?f=23&t=48668&sid=ba6dd68ad32eefbad6ae95d8fadc30e6#p416779
2020-07-20 14:17:28 +02:00
paul lee
be46c0e25d [ArchWall] Fix #0004400 - Archwall creation from certain wire fails.
Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=47505
2020-07-16 13:53:11 +02:00
hlg
a2498e1fdc [Arch] ignore extrusion direction vector length 2020-07-13 14:39:28 +02:00
paul lee
6179f4b45a [ArchWall] Revert comments in getExtrusionData() 2020-06-24 11:29:07 +02:00
paul lee
999c3d8bf4 [ArchWall] ArchWall Offset should now works with Base as Sketch 2020-06-24 11:29:07 +02:00
paul lee
7f27ec750b [ArchWall] Fix Align Right with Multi-Material invalid case problem 2020-05-25 13:34:46 +02:00
Yorik van Havre
5aa6c4e1da Arch: Misc improvements to curtain wall
- Can be based on an edge like normal wall
- Now has a 'host' property to embed into another object (tree only)
- Mullions have different height and width properties
- Mullions or panels can be disabled
2020-05-19 13:58:46 +02:00
Yorik van Havre
b0775ee7ce Arch: Fixed regression in compound walls 2020-05-18 15:04:26 +02:00
Yorik van Havre
aa3afc1824 Arch: Removed wrong warning in walls 2020-05-18 13:28:55 +02:00
vocx-fc
32cf582e08 Arch: fix wall's addDefault call
A previous fix was in 8e458abf53, but some calls to `addDefault`
were not changed.
2020-05-04 10:55:56 +02:00
Yorik van Havre
d6f77bb23b Arch: Fixed regression in wall 2020-04-24 15:10:42 +02:00
David Daish
e46ca0b967 Rewrote the function and method docstrings in an imperative style. 2020-04-22 12:17:08 +02:00
David Daish
d7137fbb67 Moved __init__ docstrings into the class docstring 2020-04-22 12:17:08 +02:00
David Daish
9f4348e00a Removed incorrect apostrophies. 2020-04-22 12:17:08 +02:00
David Daish
390a093a67 Comparison with None is now using 'is' operator 2020-04-22 12:17:08 +02:00
David Daish
fa2e5fc837 Moved all module docstrings to the top of the file. 2020-04-22 12:17:08 +02:00
David Daish
87531f3560 Spellcheck 2020-04-22 12:17:08 +02:00
David Daish
1ae2c87914 Fixed docstrings straying too far right, after indentation was fixed. 2020-04-22 12:17:08 +02:00
David Daish
69311479e5 Added docstrings for arch project, and corrected some doc mistakes. 2020-04-22 12:17:08 +02:00
David Daish
71a75b09db Added docstrings for ArchFloor 2020-04-22 12:17:08 +02:00
David Daish
25e09f51d1 Added docstrings to _Wall, and remaining parts of ArchWall 2020-04-22 12:17:08 +02:00
David Daish
78ddda11a3 Fixed syntax error 2020-04-22 12:17:08 +02:00
David Daish
a1ae74a26b Made recommended formatting changes. 2020-04-22 12:17:08 +02:00
David Daish
7eefa1b095 Added docstrings to all of the Component class's methods. 2020-04-22 12:17:08 +02:00
luz.paz
8405e77945 [skip ci] Fix typos
Found via codespell v1.17.0.dev0
```
codespell -i 3 -w -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml ./src/Mod/Arch/
```
2020-04-22 12:17:08 +02:00
David Daish
56c01f17fa Best efforts on arch wall for now. 2020-04-22 12:17:08 +02:00
David Daish
753ddba191 Work on adding docstrings to ArchWall 2020-04-22 12:17:08 +02:00
vocx-fc
1fb5408694 Arch: use the new Draft trackers module
Previously it was `DraftTrackers.py`.
Now we import the trackers from `draftguitools/gui_trackers.py`.
2020-03-31 12:09:25 +02:00
Yorik van Havre
81e6454c61 Arch: Fixed regression in layers 2020-03-12 11:33:07 -03:00
paullee0
f77a6949c9 [ArchWall, DraftGeomUtils] fix bug: ArchWall with Offset Attribute set and based on Sketch fails at some cases
DraftGeomUtils.offsetWire() supports ArchWall Offset setting inherently now.

Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=42933
2020-02-10 11:19:47 +01:00
paullee0
c004b08c14 [ArchWall] Typo 2020-01-22 10:16:54 +01:00
paullee0
41b7b1790b [ArchWall] Use OverridenWidth/Align when ArchSketch getWidths/Aligns() not implemented 2020-01-22 10:16:54 +01:00
paullee0
72798ac39d [ArchWall] Remove remarks about Werner's earlier commit 2020-01-08 15:22:54 +01:00
paullee0
feaab20f43 [ArchWall] Write back Werner's code in commit cb21045 - check tex.image is not None 2020-01-08 15:22:54 +01:00
paullee0
bcb7f6c871 [ArchWall] - Add per edge Align feature, and other complementary enabling codes
Per Edge Align Feature
- add OverrideAlign attribute to wall
- to know exactly which Sketch edge sorted into final Wires, so as to know each edge's width / align / etc.
  > sort Sketch edges by sorting Sketch.Geometry instead of Sketch.Shape Edge
  > this ensure consistency in sorting result
- pass widths, align, normal info to revised DraftGeomUtils.py and revised routine to get 2 wires from a basewires

Enabling works
- enable base objects to provide width and align per edge information by getWdiths() and getAligns() methods
- this enable base objects e.g. Sketch, DWire (functions being added) to store per edge info e.g. align, widths etc
  (already can do in SketchObjectPython)
2020-01-08 15:22:54 +01:00
luz.paz
8af8689d73 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
wmayer
1051d5f665 pivy: avoid possible segfault when setting None to an SoSFImage field 2019-11-28 15:44:42 +01:00
Zheng, Lei
ef5acc5023 Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00