Commit Graph

2649 Commits

Author SHA1 Message Date
Chris Hennes
1761eb8ce0 Merge pull request #5046 from carlopav/Draft_fixSnapGrid
Draft: fix Snapper GridSnap not working over a face
2021-09-19 16:36:38 -05:00
Chris Hennes
68a027cf94 Draft: LGTM - don't catch BaseException 2021-09-19 14:36:38 -05:00
carlopav
31a8fc5c7d Draft: fix Snapper GridSnap not working over a face
ref. https://forum.freecadweb.org/viewtopic.php?f=23&t=62274&sid=4c9d07255e4f0db219b661c345768319

If the cursor is over a Face and no SnapCenter is active, the snapToObject method returns the current cursor point instead of None. Doing so the snap() method does not check for extension and grid snaps.
It seems this is a bug since the snap() already contains the deleted code.

One note: the no snaps case was moved before the lastObj setting, since if no snap point was found, it's not right to set it to a non snapped object.
2021-09-19 14:31:44 +02:00
wmayer
ce285ea265 Mod: fix warning [-Wmacro-redefined] 2021-09-14 22:57:17 +02:00
luz paz
391a9e8d23 Draft: whitespace tweak 2021-09-08 10:22:26 -04:00
luz paz
c03d4b1c10 Draft: fix comment typo 2021-09-08 10:22:26 -04:00
Yorik van Havre
d964653057 Merge pull request #5014 from marioalexis84/draft-gui_label
Draft: Prevent working plane from restoring after label command
2021-09-07 12:45:22 +02:00
Yorik van Havre
89e1a97d80 Merged crowdin translations 2021-09-07 11:26:48 +02:00
marioalexis
bdbe3105ff Draft: Prevent working plane from restoring after label command 2021-09-07 02:50:38 -03:00
Yorik van Havre
d14167a50d Updated ts files 2021-09-06 15:32:07 +02:00
Yorik van Havre
1c8b803f9e Draft: Introduced Hatch command + object 2021-09-06 15:27:52 +02:00
Yorik van Havre
cbde274c9a Merge branch 'master' into Draft_addgroup 2021-09-06 12:02:36 +02:00
Yorik van Havre
42a8389e40 Restored docstring 2021-09-06 11:55:42 +02:00
Yorik van Havre
5c0517e620 Changed M shortcut to M,G 2021-09-06 11:53:28 +02:00
marioalexis
813114cab5 Draft: Fix variable referenced before assignment 2021-09-06 01:14:14 -03:00
Yorik van Havre
c99ec69f9c Merge branch 'alafr-arch-structure' of https://github.com/alafr/FreeCAD 2021-09-02 14:36:43 +02:00
Yorik van Havre
8ed419cf6a Merge pull request #4882 from Roy-043/Draft_Fix_init_tools.py
Draft: Small cleanup of Utilities menu and utility toolbar
2021-09-02 11:45:35 +02:00
Yorik van Havre
3172bd1005 Merge pull request #4888 from Syres916/patch-21
[Draft] Airfoil Import - User feedback not shown..
2021-09-02 11:42:36 +02:00
Yorik van Havre
854fc52ff2 Merge pull request #4891 from Roy-043/Draft_Fix_Misplaced_Edit_Nodes_BezCurve_2
Draft: Fix misplaced Draft_Edit nodes for BezCurve 2nd version
2021-09-02 11:41:51 +02:00
Yorik van Havre
ab119685ff Merge pull request #4907 from Roy-043/Draft_fix_move_alt_copy_mode
Draft: Fix Draft_Move Alt copy mode
2021-09-02 11:41:07 +02:00
Yorik van Havre
62997b1bfa Merge pull request #4915 from carlopav/draft_snap_nodoc_fix
Draft: fixed Snap behaviour when no document is active.
2021-08-30 14:26:10 +02:00
carlopav
cd19082ac6 Update src/Mod/Draft/draftguitools/gui_snaps.py
Co-authored-by: Yorik van Havre <yorik.vanhavre@gmail.com>
2021-08-30 13:57:04 +02:00
Yorik van Havre
a09ec0b403 Draft: Use BuildingParts as group in Draft SVG projections 2021-08-26 14:54:33 +02:00
Yorik van Havre
49abe81271 Merged crowdin translations 2021-08-26 14:51:36 +02:00
Yorik van Havre
a8cb3ef1e3 Updated ts files 2021-08-26 14:50:54 +02:00
Yorik van Havre
c167955018 Merge pull request #4885 from Roy-043/Draft_Fix_Array_Count_Issues
Draft: Fix Draft_PointArray and Draft_TwistedArray Count problems
2021-08-17 15:19:57 +02:00
luzpaz
72411f83ad Draft: Fix LGTM 'test for equality' warning (#4969)
* Draft: Fix LGTM 'test for equality' warning

ref: https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090

* FEM: source comment typo fixes
2021-08-16 22:52:13 -05:00
Yorik van Havre
05c88d8ada Merge pull request #4905 from Roy-043/Draft_fix_trimex_wrong_units
Draft: Draft_Trimex: Fix wrong angle units in task panel
2021-08-16 16:22:47 +02:00
alafr
6e7bea99d0 Merge branch 'master' into alafr-arch-structure 2021-08-06 21:55:02 +02:00
Yorik van Havre
a74792e3f6 Draft: Allow to stretch more complex Arch objects 2021-08-03 16:45:43 +02:00
Yorik van Havre
15c04a30cf Merge pull request #4926 from Syres916/patch-24
[Draft] gui_utils Minor bugfix on change to...
2021-08-02 17:42:39 +02:00
Syres916
f76c9926da [Draft] gui_utils Added FIXME comment to assist..
... revisiting in future
2021-08-02 15:19:22 +01:00
Yorik van Havre
3b444b1cf3 Merge pull request #4927 from marioalexis84/draft-restore
Draft: Fix regression on WP and fixes #0004562
2021-08-02 15:52:42 +02:00
Yorik van Havre
bd0b5bbecd Merge pull request #4929 from marioalexis84/draft-multiselection
Draft: Enable multiple selection for dumb task dialog in Modification commands
2021-08-02 15:51:10 +02:00
Yorik van Havre
b2ebda4d98 Merge pull request #4930 from Kawashima-Azumi/shutil-no-which
Draft: Some shutil don't have the .which method.
2021-08-02 15:41:02 +02:00
Yorik van Havre
6a6fd946a5 Merge branch 'master' into Draft_Fix_Draft_SetStyle 2021-08-02 11:55:28 +02:00
Yorik van Havre
26ff21d93d Merge pull request #4879 from Roy-043/Draft_Fix_Layer_List_Issues
Draft: Fix 3 issues with the Draft Tray layer list
2021-08-02 11:54:11 +02:00
Roy-043
422bde4bf7 Draft: Fixed wrong cmd names in gui_planeproxy.py
Draft_SetWorkingPlaneProxy should be Draft_WorkingPlaneProxy
2021-08-01 13:14:30 +02:00
Roy-043
ad39e5fbdd Draft: Fixed units mismatch when moving Draft_Point objects
obj.X.Value instead of float(obj.X)
2021-08-01 13:13:35 +02:00
Roy-043
f47c33bd65 Draft: Fixed units mismatch when moving Draft_Point objects. 2021-08-01 13:13:35 +02:00
Roy-043
638976c409 Draft: Fix patharray edge sort issue
If the user selects edges for the path of a patharray the edges need to be sorted before creating a Part.Wire from them.
2021-08-01 13:12:44 +02:00
Roy-043
a03eb6b962 Draft: Fix wrong default value for defaultWP
The default value for defaultWP in DraftTools.py did not match the value in DraftGui.py and preferences-draft.ui.
See forum topic: https://forum.freecadweb.org/viewtopic.php?f=8&t=57909&p=513411#p513411
2021-07-31 09:57:59 +02:00
Roy-043
03a1b9b1c1 Draft: fix gui_offset.py wrong ghost if start angle of arc is larger
The ghost of an arc with a start angle that is larger than the end angle would be wrong.
2021-07-31 09:56:25 +02:00
Roy-043
ed94be6ab9 Draft: fix geometry.py findDistance function
The findDistance function did not work properly for arcs that crossed the 9 o'clock point.
2021-07-31 09:56:25 +02:00
Roy-043
5564b025fe Draft: Fix spelling gui_edit_draft_objects.py
"mset first angle" should be "set first angle".
2021-07-31 09:53:56 +02:00
GUAN Xin
75251151ff Some shutil don't have the .which method.
Directly calling subprocess.Popen without checking the presence of the
program is the optimal solution because:
1) Avoids race condition, where the program disappears between the
  check and the Popen call.
2) Popen will raise exception if the program is absent anyway,
  no race condition here.
2021-07-19 14:12:03 +08:00
marioalexis
b1a534930f Draft: Enable multiple selection for dumb task dialog in Modification commands 2021-07-19 02:45:17 -03:00
Syres916
a049b9118b [Draft] gui_utils Coin import addition 2021-07-18 19:52:31 +01:00
marioalexis
fd6290566d Draft: Save last WP used 2021-07-18 02:07:59 -03:00
marioalexis
1b8a886770 Draft: Fix regression generated in commit 76c7aa3 2021-07-18 02:07:08 -03:00