Commit Graph

345 Commits

Author SHA1 Message Date
Roy
db7b37dd1f Draft: Fix additional translation issues related to the snapping commands 2022-01-12 13:44:05 +01:00
Roy-043
0f79fe81f9 Update gui_arcs.py 2022-01-11 11:42:45 +01:00
Roy-043
cefd414f54 Update gui_arrays.py 2022-01-10 15:12:09 +01:00
Roy
91f037912e Draft: Fix translation issues 2022-01-10 10:17:53 +01:00
Roy-043
dede60c481 Draft: fix Draft_SelectGroup
The behavior of the Draft_SelectGroup command was a bit cryptic. Layers were also regarded as groups. And the selection result was not the same if a nested object, instead of the group that object was in, was selected. The new version selects all objects in the `Group` property of the selected groups (or group-like objects). Nested groups are selected, but their contents is not.
2022-01-09 21:09:42 -06:00
marioalexis
5acf2f5340 Draft: Use super() to call base class methods 2022-01-07 22:24:21 +01:00
Roy-043
ba3961574b Draft: make Draft_Snap_Angle work in 3D
Draft_Snap_Angle only worked for circular edges on a plane parallel to the XY plane of the global coordinate system.
2022-01-06 16:57:55 +01:00
Mariwan
e63472b10c Draft: change static to non-static declared variables (#5292)
* Draft: change static to non-static declared variables

* Change variable name and add some comment
2022-01-05 16:39:28 +01:00
Roy
3c1531b39a Draft: Commands acting on subelements did not load the Draft module 2022-01-01 16:26:26 -06:00
Yorik van Havre
a318c19711 Merge pull request #5249 from Roy-043/Draft-Draft_Label-fix-label-type-list
Draft: Draft_Label fix label type list
2021-12-21 11:45:16 +01:00
Roy-043
8529786fd1 Draft: fix Draft_Arc_3Points task panel issues
Fixed the following task panel issues:
1. Wrong title and icon.
2. Continue toggle missing.
2021-12-11 19:00:31 +01:00
Roy
418ca4a235 Draft: Draft_Label fix label type list 2021-12-10 18:40:43 +01:00
Roy-043
a62ffdf93d Draft: fix task panel_issues (gui_texts.py) 2021-12-04 22:01:29 +01:00
Roy-043
6684196c81 Draft: fix task panel issues (gui_polygons.py) 2021-12-04 22:00:43 +01:00
Roy-043
4f8094baec Draft: fix task panel issues (gui_points.py) 2021-12-04 21:59:47 +01:00
Roy-043
d97ba3c622 Draft: fix task panel issues (gui_edit.py) 2021-12-04 21:58:50 +01:00
Yorik van Havre
f938c74929 Merge pull request #5202 from Roy-043/Draft-fix-3-snap-issues
Draft: fix 3 snap issues
2021-12-01 15:01:27 +01:00
Roy-043
cbf9fbd79d Draft: fix style handling of PointColor and PointSize
Draft_SetStyle did not handle PointColor and PointSize.
2021-11-28 11:50:49 +01:00
Roy-043
f89078c01f Draft: fix 3 snap issues
1. Draft_Snap_Parallel only worked beyond the endpoints of the edge.
2. It was very hard to select an edge for Draft_Snap_Parallel if no other snaps were active.
3. Only two snap objects were stored.
2021-11-25 15:21:11 +01:00
Yorik van Havre
d4a2ddfbb6 Merge pull request #5179 from Roy-043/Draft-housekeeping-SS-shortcut-used-twice
Draft housekeeping: SS-shortcut used twice
2021-11-24 15:32:02 +01:00
Roy-043
413fff7ea2 Draft: fix toggle grid issue. 2021-11-17 19:26:36 +01:00
Roy-043
b03a1db7d0 Draft housekeeping: SS-shortcut used twice 2021-11-16 16:49:30 +01:00
Roy-043
84c517e333 Draft: Fix angle dimension issue
If the end points of the selected edges for an angular dimension were (almost) coincident with their intersection, random angles could be calculated. In essence a floating point inaccuracy issue.
2021-10-28 19:29:59 +02:00
Yorik van Havre
0b7018ce64 Merge pull request #5119 from Roy-043/Draft-Fix-Draft_SelectPlane-ignores-nesting
Draft: Fix Draft_SelectPlane ignores nesting
2021-10-25 14:16:44 +02:00
Roy-043
c8a9ec2e8b Draft: Fix Draft_Edit sketch issue
Draft_Edit did not work on wall sketch after reopening file
2021-10-21 21:40:55 +02:00
Roy-043
d0b34efa27 Draft: Fix Draft_SelectPlane ignores nesting 2021-10-20 10:16:49 +02:00
Yorik van Havre
24d1a3f054 Merge pull request #5023 from marioalexis84/gui-encoding
Gui:  Harmonize encoding/decoding between view, property editor and command line.
2021-10-14 12:24:49 +02:00
Roy-043
c34524668f Delete gui_lineops.py 2021-10-12 14:23:59 +02:00
Yorik van Havre
2d10bd6dca Merge pull request #5088 from Roy-043/Draft-improvements-for-Draft_Hatch
Draft: improvements for Draft_Hatch
2021-10-08 14:42:46 +02:00
Yorik van Havre
feb7faf173 Merge pull request #5092 from Roy-043/Draft-Draft_Text-should-use-working-plane
Draft: Draft_Text should be aligned with working plane
2021-10-08 14:39:15 +02:00
Roy-043
b6565da274 Draft housekeeping: gui_rectangles.py should use make_rectangle 2021-10-06 17:54:30 +02:00
Roy-043
50b8ed49a5 Draft: Draft_Text should be aligned toworking plane 2021-10-06 13:15:10 +02:00
Roy-043
812a0e787a Update gui_hatch.py 2021-10-05 15:58:09 +02:00
Yorik van Havre
00b24bc707 Merge pull request #4998 from carlopav/Draft_WPimprovements
Draft: Working Plane improvements
2021-10-05 12:56:58 +02:00
Chris Hennes
e4116758c5 [Draft] Silence LGTM warnings about unused vars
LGTM only recognizes "_" and "unused" as variable names that are
expected to be unused, so switch to "_".
2021-09-26 13:34:16 -05:00
carlopav
ffbaaa3526 Draft: updated working plane BIM figure
Display the human figure at the grid corner.
        The silhouette is displayed only if:
        - BIM Workbench is available;
        - preference BaseApp/Preferences/Mod/Draft/gridShowHuman is True;
        - the working plane normal is vertical.
2021-09-26 12:12:51 +02:00
carlopav
12f797ef65 Draft: Grid added option to disable human figure representation
The "gridShowHuman" preference was introduced to disable the human figure representation in the grid.
2021-09-26 09:59:34 +02:00
marioalexis
e2b3310277 Draft: Fix Unicode and UTF-8 encoding character behavior 2021-09-23 21:21:24 -03:00
Chris Hennes
28127c5f2d Merge pull request #5046 from carlopav/Draft_fixSnapGrid
Draft: fix Snapper GridSnap not working over a face
2021-09-19 16:36:38 -05:00
Chris Hennes
f99059e371 Draft: LGTM - don't catch BaseException 2021-09-19 14:36:38 -05:00
carlopav
967a97e9a8 Draft: fix Snapper GridSnap not working over a face
ref. https://forum.freecadweb.org/viewtopic.php?f=23&t=62274&sid=4c9d07255e4f0db219b661c345768319

If the cursor is over a Face and no SnapCenter is active, the snapToObject method returns the current cursor point instead of None. Doing so the snap() method does not check for extension and grid snaps.
It seems this is a bug since the snap() already contains the deleted code.

One note: the no snaps case was moved before the lastObj setting, since if no snap point was found, it's not right to set it to a non snapped object.
2021-09-19 14:31:44 +02:00
luz paz
60568ec32f Draft: fix comment typo 2021-09-08 10:22:26 -04:00
Yorik van Havre
36092cb588 Merge pull request #5014 from marioalexis84/draft-gui_label
Draft: Prevent working plane from restoring after label command
2021-09-07 12:45:22 +02:00
marioalexis
42775e6f3d Draft: Prevent working plane from restoring after label command 2021-09-07 02:50:38 -03:00
Yorik van Havre
2bf67f0191 Draft: Introduced Hatch command + object 2021-09-06 15:27:52 +02:00
Yorik van Havre
0fa90a320c Merge branch 'master' into Draft_addgroup 2021-09-06 12:02:36 +02:00
Yorik van Havre
d0a3a34665 Restored docstring 2021-09-06 11:55:42 +02:00
Yorik van Havre
1d043b8cd3 Changed M shortcut to M,G 2021-09-06 11:53:28 +02:00
marioalexis
da2195a04a Draft: Fix variable referenced before assignment 2021-09-06 01:14:14 -03:00
Yorik van Havre
4633ef67d2 Merge pull request #4891 from Roy-043/Draft_Fix_Misplaced_Edit_Nodes_BezCurve_2
Draft: Fix misplaced Draft_Edit nodes for BezCurve 2nd version
2021-09-02 11:41:51 +02:00