Commit Graph

24565 Commits

Author SHA1 Message Date
luz paz
147542aef0 Part: Part.CompoundTools.Explode.explodeCompound access a property of...
...a sometimes null object with an error

Python code, file `src/Mod/Part/CompoundTools/Explode.py`
The `explodeCompound` function can be called in a context without assigning the `ViewObject` property, for example from a command line script.

The error that is fixed by this patch. 
```
Traceback (most recent call last):
  ...
  File "/opt/freecad/Mod/Part/CompoundTools/Explode.py", line 23, in explodeCompound
    cf.ViewObject.DontUnhideOnDelete = True
AttributeError: 'NoneType' object has no attribute 'DontUnhideOnDelete']
```

Patch submitted by marioamb.  
Fix #004421  
https://tracker.freecadweb.org/view.php?id=4421
2021-02-21 11:40:20 +01:00
donovaly
8a4334abcd [Part] fix regression in location dialog layout
For some reason the horizontal alignment got broken. This PR replaces the different grids with each on grid per groupbox
2021-02-21 11:36:13 +01:00
sliptonic
afee9d3c36 Merge pull request #4484 from Russ4262/fix_profile_feature_filter
[Path] Fixes for Profile operation [0.19]
2021-02-20 17:27:00 -06:00
sliptonic
be2462d7ec Merge pull request #4498 from sliptonic/bug/slotexperimental
[PATH] move slot op to experimental status
2021-02-20 17:16:22 -06:00
sliptonic
e7200193bd Merge pull request #4497 from sliptonic/bug/adaptiveuseoutlineprop
[PATH]  Small fixes to Adaptive op and Heidenhain post processor
2021-02-20 17:15:45 -06:00
wmayer
8163e562f3 Sketcher: [skip ci] fix bad static_cast 2021-02-20 22:46:51 +01:00
David Osterberg
59dd9d72c5 PartDesign: Fix throughall distance when throughall is used together with midplane 2021-02-20 20:12:47 +01:00
wmayer
48fdbbab4c PD: [skip ci] fixes #0004573: missing bindings to expressions in primitives location dialog 2021-02-20 20:04:37 +01:00
donovaly
e3dff59c2e [Part] add missing bindings
For FC 0.19 we added bindings to the PD primitives but we forgot the Part primitives
2021-02-20 20:02:09 +01:00
Russell Johnson
929405e745 Path: LGTM cleanup 2021-02-20 12:32:25 -06:00
Russell Johnson
6ea5b2c69c Path: Remove unnecessary line return 2021-02-20 12:32:25 -06:00
Russell Johnson
2ff909b993 Path: Add error for incorrect open-edge usage
When profiling open edges, the user must currently select a top edge and then set the Final Depth manually to a value below the selected edge(s).
This fix provides the user with feedback for the empty path generated.
2021-02-20 12:32:25 -06:00
Russell Johnson
a1d3f8e490 Path: Catch error if ofstShape has no Area attribute 2021-02-20 12:32:25 -06:00
Russell Johnson
05b2b9e28e Path: Fix incorrect empty data type return 2021-02-20 12:32:25 -06:00
Russell Johnson
d90d176a86 Path: Catch openEdges error if None 2021-02-20 12:32:25 -06:00
Russell Johnson
a33a287475 Path: Fix spacing typo 2021-02-20 12:32:25 -06:00
Russell Johnson
b3cfb29038 Path: Fix range() input type per gcc-7 build 2021-02-20 12:32:25 -06:00
Russell Johnson
0718afa5e1 Path: Fix feature selection and handling
Fix error when working with selections containing edges and faces.  This fix effectively processes edges and only passes faces on to next processing step.  This simplifies the code a bit and changes some `obj.Base` references to `otherBase` to improve readability.
Path: Improve `obj.Base` reading and processing

`obj.Base` is first read in `self._processEdges()`.  All edges are identified and processed there.  Remaining features are saved in `remainingObjBaseFeatures` to be processed in the next section of the Profile code.
Path: Change `if` to `elif`
2021-02-20 12:32:25 -06:00
Russell Johnson
b86104b01e Path: Fix error for undefined profileshape variable 2021-02-20 12:32:25 -06:00
Russell Johnson
cda4d12ad2 Path: Fix open-edge profiling for micro bit usage 2021-02-20 12:32:25 -06:00
Russell Johnson
f1f584af2d Path: Change HandleMultipleFeatures default value to Collectively
This fixes error when attempting to profile loop of vertical faces, thus maintaining original Profile Faces behavior by default for vertical looped face set.
2021-02-20 12:32:25 -06:00
Russell Johnson
edab3c6ecc Path: Apply LazyLoader for DraftGeomUtils module 2021-02-20 12:32:25 -06:00
sliptonic
ce3249d0a8 move slot op to experimental status 2021-02-20 12:10:49 -06:00
sliptonic
7d4ca77f1a Merge pull request #4454 from lag-linaro/master
PathToolBitLibraryGui: Fix LinuxCNC tool table format
2021-02-20 11:54:51 -06:00
Stefano Chiaro
947dc038db Update src/Mod/Path/PathScripts/post/heidenhain_post.py
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2021-02-20 11:37:08 -06:00
Stefano Chiaro
f7de07a522 Update heidenhain_post.py
fixed pol_Angle
2021-02-20 11:37:08 -06:00
sliptonic
615573580d Pep8 cleanup 2021-02-20 11:37:08 -06:00
sliptonic
c40bce0597 Add useoutline property to op if doesn't exist 2021-02-20 11:37:08 -06:00
sliptonic
a7d62d0cf1 Merge pull request #4477 from sliptonic/bug/miscellaneous
[PATH]  Bug fixes for several minor issues, lgtm flags and input sanitizing.
2021-02-20 10:35:16 -06:00
donovaly
2d8ce4bcd0 [FEM] correct sorting order
all other menu items are sorted and we also keep the sorting in the Wiki
2021-02-20 16:40:04 +01:00
wmayer
0adfa17d0d Import: [skip ci] fixes #0003988: the function Import.readDXF doesn't import Bsplines 2021-02-20 16:37:02 +01:00
wmayer
7c4ff63079 PD: [skip ci] fixes #0004540: When manual size of DatumPlane is selected its Length property is not saved to the file and consequently not restored on opening 2021-02-20 13:33:54 +01:00
wmayer
c996988a9d Gui: [skip ci] fixes #0004569: Part Design Workbench - New Bodies selection issues 2021-02-20 02:06:27 +01:00
sliptonic
586b2e6aa7 add back translation string 2021-02-19 17:50:56 -06:00
wmayer
fab2a0d1fa PD: [skip ci] do not pop-up dialog when creating a body while another body is selected 2021-02-19 21:44:48 +01:00
David Osterberg
0e8e5c8d49 PartDesign: Fix helix for OCC versions < 7.5.0 2021-02-19 20:02:11 +01:00
wmayer
5cc3dde57b App: [skip ci] replace plain C API with PyCXX to avoid memory leaks 2021-02-19 17:26:33 +01:00
vosk
9ad15a0a3d [App] [skip ci] - Fix python new references leaking 2021-02-19 17:25:25 +01:00
vosk
08c2179a4f [GUI] - Fix leaking QObject 2021-02-19 16:52:25 +01:00
vosk
100a7ade4c [TD] - Fix geometry object leaking on every exec 2021-02-19 16:50:56 +01:00
vosk
21e5fb66c4 [APP] - Fix leaking QGraphicsScene in QuarterWidget 2021-02-19 16:44:16 +01:00
Yorik van Havre
2352474ede Tools: Updated offline wiki fetching script 2021-02-19 16:41:46 +01:00
Yorik van Havre
d873ace412 Updated splashscreen 2021-02-19 16:41:23 +01:00
bitacovir
ad1c767baa [UI] Add tools to Mesh WB toolbar 2021-02-19 16:28:42 +01:00
Benjamin Nauck
8fb44c3aa6 Gui: Minor cleanup
Cleans up code which was touched in previous commit.

* Don't call popup() twice when not needed
* use nullptr instead of 0 for pointers
2021-02-19 16:22:41 +01:00
Benjamin Nauck
eb400fe249 Spreadsheet: Don't autocomplete when writing strings
After pull request https://github.com/FreeCAD/FreeCAD/pull/4215 it
doesn't make much sense helping the user to write expressions without
leading '=', as that content will be parsed as a string.

This change adjusts the behaviour in SpreadsheetGui's LineEdit to avoid
popping up the ExpressionCompleter when no leading equal sign is used.
2021-02-19 16:22:41 +01:00
Benjamin Nauck
6eb89fe038 Spreadsheet: Fix coverity warning
There are no reason to check the return values for these functions
as the string passed as an argument will be set to an empty string
if it false. An empty string is a valid option in these instances.

Coverity warnings fixed:

CID 316520 (1 of 1): Unchecked return value (CHECKED_RETURN)
3. check_return: Calling getAlias without checking return value (as is done elsewhere 8 out of 10 times).

CID 316557 (1 of 1): Unchecked return value (CHECKED_RETURN)
8. check_return: Calling getAlias without checking return value (as is done elsewhere 8 out of 10 times).
2021-02-19 15:47:27 +01:00
donovaly
3fdce54be7 [PD] fix dressup feature display when broken
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
2021-02-19 14:51:52 +01:00
David Osterberg
1b07835aa5 PartDesign: Check closedness in AddSub refine function 2021-02-19 14:33:56 +01:00
bitacovir
72e33c44c1 [UI] 0.19 Replace FEM WB icons 2021-02-19 14:25:01 +01:00