Commit Graph

3170 Commits

Author SHA1 Message Date
Syres916
1ae3394be4 [TechDraw] Fix Qt6 compatability of FillTemplateFields tool 2025-07-06 16:49:18 +02:00
Kacper Donat
93a472c202 Merge pull request #22138 from chennes/compilerWarningCleanup20250622
Compiler warning cleanup
2025-07-06 16:32:08 +02:00
Ryan K
dd5cb6aa61 TechDraw: ActiveView rework (#22107)
* TechDraw: Rework ActiveView

* Update src/Mod/TechDraw/Gui/TaskActiveView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

---------

Co-authored-by: Ryan Kembrey <ryan.kembrey@student.uts>
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-06-30 12:04:12 -04:00
Ryan K
9b32202199 TechDraw: Add command tool label for vertex group (#22118)
Co-authored-by: Ryan Kembrey <ryan.kembrey@student.uts>
2025-06-23 12:26:40 -04:00
Ryan Kembrey
a3fb529bc8 TechDraw: Remove redundant apply button. (Fix #21792) 2025-06-23 11:15:03 -05:00
WandererFan
51184b99d5 [TechDraw]Detail highlight drag (fix #21828) (#22036)
* [TD]add preferences for detail highlight snapping

* [TD]fix highlight drag issues

* Update src/Mod/TechDraw/Gui/TaskDetail.cpp

minor format change from benj5378.

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

---------

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-06-23 11:13:27 -05:00
Chris Hennes
e38af07217 TD: Remove calls to now-empty clearLineSets() method 2025-06-22 19:10:48 -05:00
Chris Hennes
c0d22febd8 TD: Add missing override 2025-06-22 19:10:48 -05:00
Ryan Kembrey
f338a779e0 TechDraw: Add spacing preview without OCCT calls 2025-06-16 10:41:21 -05:00
Syres916
39dc1e6210 [Gui] C++ preparation for deprecation of QCheckBox…
…stateChanged -> checkStateChanged
2025-06-13 10:40:48 +02:00
Luz Paz
78d995f2b8 TechDraw: fix typo in comment 2025-06-11 21:51:23 +02:00
wandererfan
9a18895cd0 [TD]fix bad element name in Vertex::Restore 2025-06-10 13:46:57 -05:00
wandererfan
ca20e8baad [TD]fix dim reference repair 2025-06-09 11:49:25 -04:00
WandererFan
8d0e9be09b [TD]Cosmetic vertex tag save/restore fail (fix #21069) (#21374)
* [TD]fix tag handling on Save/Restore

* [TD]fix linter messages

* [TD]remove c-style cast x4

* [TD]do not write VertexTag element in Vertex::Save
2025-06-09 17:48:00 +02:00
Chris Hennes
30aee57880 Merge pull request #21659 from 3x380V/gui_fixes
Gui: random fixes
2025-06-03 19:23:21 -05:00
PaddleStroke
3fc9cac29c TechDraw: Sheet view: add property to claim sheet as child. (#21624)
* TechDraw: Sheet view: add property to claim sheet as child.

* Update ViewProviderSpreadsheet.cpp

* Fix bad scale of sheet views
2025-06-02 11:29:22 -05:00
WandererFan
935ac04995 Merge pull request #21377 from WandererFan/Removesnprintf
[TD]remove snprintf
2025-06-02 18:24:05 +02:00
Chris Hennes
dd4599c459 Merge pull request #21558 from WandererFan/PyRoutineInvertY
[TD]Return QT or Conventional coords for geometry in Py routines (fix #21473)
2025-06-02 10:41:29 -05:00
Yorik van Havre
640642eed2 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00
Yorik van Havre
26e16765b0 Translations: updated ts files 2025-06-02 11:07:28 +02:00
wmayer
b006a37010 Gui: Add Action::setBlockedChecked
Remove the second parameter of Action::setChecked and
provide Action::setBlockedChecked instead.
2025-05-30 14:21:53 +02:00
theo-vt
1a0a68ae69 PartDesign: Fix hole centered on point edge case (#21257)
* Light refactor of getTopoShape function

* Fix hole edge case

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Refactor simplifyCompound()

* Use Base::Flags<GetShapeOption>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Shorten enum name and move it from class scope to namespace scope

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2025-05-29 22:37:54 +02:00
Benjamin Bræstrup Sayoc
2438156b23 TechDraw: fix incorrect click handles of editable labels (#21131)
Fixes #20964:
- When `text` element doesn't have id
- When `text` element has transform attribute
2025-05-29 08:30:59 -04:00
PaddleStroke
42e98afa30 TechDraw: Fix DrawViewSpreadsheet being assigned wrong QGI in QGSPage.cpp (#21623) 2025-05-29 00:06:34 +02:00
WandererFan
009754581e [TD] fix small angle dims (fix #21114) (#21208)
* [TD]fix handling of very small angle dimensions

- also remove test for too small format specifier

* [TD]lint messages

* [TD]apply review comments.
2025-05-26 17:19:19 +02:00
PaddleStroke
d013890bf6 TechDraw: richannotation : Fix white text issue (#21515)
* TechDraw: richannotation : Fix white text issue

* Update QGIRichAnno.cpp
2025-05-26 17:18:21 +02:00
Benjamin Bræstrup Sayoc
41111c5ee9 TechDraw: fix state handling of dimensions
- Positioning was calculated using `boundingRect` while `transformOriginPoint` was set according to `tightBoundingRect`, causing mismatch when `QGIDatumLabel` contains more than text (eg. shapes around text). Now `transformOriginPoint` and positioning calculated according to `tightBoundingRect`, and setting `transformOriginPoint` of `QGIDatumLabel` are handled by itself. This fixes an issue where the gap between dimension lines and text varied depending on dimension's angle.
- `m_lineWidth` was set in multiple locations, causing confusion and bug introduction
- If `X` or `Y` property changed, the remaining changed properties were not handled due to using `if else` rather than `if` for property change checking. This became an issue due the above mentioned simplification of `m_lineWidth` setting: if `X` or `Y` had changed (upon document restore).
- Center position was uneededly saved in variables `posX` and `posY` when it could be calculated on demand using `tightBoundingRect`. Removing this uneeded state simplfies code and lowers the risk of bug introduction due to lack of updating state.
2025-05-26 17:18:04 +02:00
Benjamin Bræstrup Sayoc
4e95213e0a TechDraw: centralize usertype constants 2025-05-25 20:42:02 +02:00
wandererfan
8289f84e0c [TD]fix hidden vertex not created 2025-05-24 14:57:44 -04:00
wandererfan
4d3d0d78e4 [TD]fix vertex visible attribute not restored 2025-05-24 14:57:44 -04:00
wandererfan
053e745f44 [TD]return Qt or conventional coords 2025-05-24 14:57:44 -04:00
FC-FBXL5
8de45658e9 TechDraw: Update LineGroup.csv (#21513)
: -> ;

It seems a colon was mistakenly used instead of a semicolon, this has been corrected.
2025-05-22 22:45:22 +02:00
PaddleStroke
782e90b4cc TechDraw: Fix claiming of hatch 2025-05-19 17:33:19 +02:00
PaddleStroke
e423b1bf23 TechDraw: Lock multiple views 2025-05-19 09:37:37 +02:00
PaddleStroke
39b6a1e3a8 TechDraw: decorateLine fix (#21312)
* TechDraw: decorateLine fix

* Update CommandAnnotate.cpp
2025-05-19 09:36:47 +02:00
Chris Hennes
4cc069eb0a TD: Remove unused variable 2025-05-19 09:36:13 +02:00
Luz Paz
ee4fa234c9 Fix various typos
Missed by the codespell CI not being functional for a period of time.
2025-05-15 10:59:48 -05:00
Benjamin Bræstrup Sayoc
88dc2048cd TechDraw: fix face color not working
Fixes #20467
2025-05-15 12:16:24 +02:00
Chris Hennes
f9dbaac7aa TD: Fix hatch size constraint
Commit 1155f0d7 changed `UnitsApi::getDecimals()` from `int` to
`size_t`, which changes the meaning of the negation since it is now
unsigned. Cast it to an integer before the negation to restore the old
behavior.
2025-05-12 18:11:15 +02:00
Chris Hennes
952485dcbb Merge pull request #19907 from benj5378/getAttribute
Base: make getAttribute template
2025-05-12 10:39:55 -05:00
Benjamin Bræstrup Sayoc
2b6e73c29d Everywhere: clean up getAttribute conversions 2025-05-09 15:54:57 +02:00
Benjamin Bræstrup Sayoc
2b1aec0041 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
Chris Hennes
6a458b5ed0 TD: Fix capitalization of Console calls 2025-05-08 21:08:45 +02:00
WandererFan
3cabb3f7b8 [TD]Allow non-shape views to have children (#20768) (#21099)
* [TD]Allow non-shape views to have children (#20768)

* Update src/Mod/TechDraw/App/DrawView.cpp

Review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/App/DrawView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-08 09:18:09 -05:00
bofdahof
ba2c2ca5ad Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
Benjamin Nauck
afc54f74e4 Merge pull request #21083 from 3x380V/exception-stage-1
Base: simplify Exception
2025-05-06 09:29:45 +02:00
wandererfan
0d3b9e888c [TD]fix hidden line regression, 2025-05-05 21:26:35 -05:00
Ladislav Michl
9683cf1e4f Base: rename Exception's PascalCase methods to camelCase 2025-05-05 23:50:01 +02:00
Chris Hennes
f55063855a Merge pull request #20540 from 3x380V/cleanup-schemas-management
Simplify UnitsSchemas management
2025-05-05 10:43:27 -05:00
wandererfan
b4a9c2222c [TD]Lint brushing 2025-04-29 09:22:11 -04:00