Commit Graph

23918 Commits

Author SHA1 Message Date
Abdullah Tahiri
28415f53d4 GCS: renaming parameters to make them more descriptive 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
7f006e2c75 GCS: Augment information provided by GCS with groups of dependent parameters 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
270b0cbc33 GCS: Interface to query whether the used diagnose matrix is empty
=================================================================

Diagnose constraints do not include among others driven constraints. This
function allows to know whether the solver is considering an empty matrix.
2020-12-19 11:58:54 +01:00
Abdullah Tahiri
996f006de3 GCS: Deactivate Debug code and fix warnings in non-Debug mode 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
b2fd91c333 GCS: Asynchronous full geometry parameter identification for Dense QR 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
5e2a2cbbbb GCS: Make QR decompositions for constraints and parameters run asynchronously 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
9f2d34ac4b GCS: QR profiling debug code 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
ac7f6b8ceb GCS: Rewrite diagnose() so that it has a single return point 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
474d5550cf GCS: Diagnose() - Separate DenseQR and SparseQR 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
c635b4b954 GCS: Refactor new SparseQR Dependent Parameter detection code and const correctness 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
2d37d7194a GCS: Detect dependent parameters (geometry) during diagnosis using two SparseQR factorisations 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
982591b0d4 GCS: makeSparseQRDecomposition generalise for transposed and non-transposed matrices 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
820b02b295 GCS: SparseQR compilation guards 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
0f9af72f25 GCS: reduce input parameters in makeDenseQRDecomposition 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
dd4b29333a GCS: Refactor Non-Zero elimination over pivot 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
ed5af06d14 GCS: Refactor diagnose identification of conflicting and redundant constraints 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
a5927e1a61 GCS: Refactor dependent parameters identification which is only available for DenseQR 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
25d94d00cb GCS: Refactor QR decomposition into separate functions for Sparse and Dense 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
d9bca3e8c1 GCS: Increase documentation of diagnose() routine 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
ad549d49e1 Sketcher: ViewProviderSketch update of geometry extensions
==========================================================

The order of any operation, including setedit is first solve() and then draw().

This is consistent with geometry addition.

If ViewProviderSketch must insert its own extensions, for example for scaling
weights, then it is its responsibility to set this information wherever needed.
This includes the temporal geometry vector used in draw(true), the solver to
enable dragging operations, and SketchObject Geometry property.
2020-12-19 11:58:54 +01:00
Abdullah Tahiri
985f3510f5 Sketcher: Fix crash when creating an angle constrain on a line segment
======================================================================

Most of these crashes come from previous code not checking for Constraint::GeoUndef.

Most of these crashes come from isBSpline(), any of the two overloads.

isBSpline is made to throw exception when null, which should prevent the crash while
creating a reportable error.
2020-12-19 11:58:54 +01:00
Abdullah Tahiri
70f85505d0 Sketcher: delete internal alignment geometry using new delGeometries function 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
117c63ad21 Part: Geometry - BSplineCurve - add IsRational member function 2020-12-19 11:58:54 +01:00
Russell Johnson
bdf4d39793 Path: Fix reference to cutting edge angle in OCL_Tool() class
The class variable name was not corrected with previously committed changes.
The correct cutting edge variable name is located in the __init__() constructor method.
2020-12-18 16:04:28 -06:00
Russell Johnson
d67f636d9d Path: Fixes to path generation for certain selections
Fixes path generation for selection of two non-parallel edges.
Fixes path generation for selection of single, bottom face of slot with two non-parallel ends.
Fixes path generation for selection of two parallel, bottom bounding edges of slot.
2020-12-18 16:04:07 -06:00
Russell Johnson
3b2d06a481 Path: Add docStrings to some methods 2020-12-18 16:04:07 -06:00
Russell Johnson
4d35905a60 Path: LGTM and spelling correction 2020-12-18 16:04:07 -06:00
sliptonic
8e911b347c Merge pull request #4157 from sliptonic/bug/4466
fixes 4466  Path Template Saving incorrect attributes
2020-12-18 15:31:47 -06:00
wmayer
5aac143e66 PartDesign: [skip ci] fix Hole feature
* by default ThreadDirection must be set read-only since Threaded by default is None
* use suitable values to initialize the class properties
2020-12-18 21:18:41 +01:00
Chris Hennes
74e146610a Add prefs for import/export in Recent Files
Add two (currently hidden) preferences controlling whether imported and
exported files are included in the recent files list.

RecentIncludesImported defaults to true, and RecentIncludesExported
defaults to false.
2020-12-18 13:43:23 -06:00
sliptonic
e697a3de1e Merge branch 'master' into feature/suppress-warnings-preferences 2020-12-18 11:12:48 -06:00
sliptonic
b2e993e97a Merge branch 'master' into bug/4466 2020-12-18 11:11:18 -06:00
sliptonic
5cea165a66 Merge pull request #4160 from mlampert/bugfix/issue-4500-segfault
Path: Bugfix/issue 4500 segfault
2020-12-18 11:03:42 -06:00
wmayer
1c897b7ba9 PartDesign: [skip ci] fix order of controls so that by pressing TAB always the next control gets focus 2020-12-18 17:04:27 +01:00
M G Berberich
055424342e cleanup of hole dialog
* replaced widget with radiobuttons by button Group, to improve alignemt
  of DrillPointAngle with grid-layout

* made Thread Pitch/Angle/Cutoffs widgets wider
2020-12-18 16:38:46 +01:00
wmayer
9be9abe476 PartDesign: [skip ci] fix layout of Drill point controls 2020-12-18 16:28:35 +01:00
wmayer
126c58471a Gui: [skip ci] avoid adding a wrong file name to the recent files list 2020-12-18 14:35:17 +01:00
Bryan Bendall
d6cd6f288f Path: Added option for the finishing pass of the adaptive op 2020-12-18 08:03:42 -05:00
Aapo
8462fc1842 [TD] Balloon, fix Origin and scale refresh bugs, make Balloon scale change more reasonable per UI click. 2020-12-18 12:45:34 +01:00
Aapo
3038633069 [TD] Balloon, fix EndTypeScale refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
f3bce14f29 [TD] Balloon, move property LineVisible to View tab and fix a refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
b41cf98583 [TD] Balloon, change ordering of the data properties to more logical. 2020-12-18 12:45:34 +01:00
wmayer
def9e29fa9 Gui: [skip ci] fix crash when using a dialog instance twice for a task panel 2020-12-18 11:46:31 +01:00
Markus Lampert
72b70c52a1 Added provision for gcc peculiarities in unit tests 2020-12-17 23:11:02 -08:00
Markus Lampert
3b69d23571 Reuse existing QuantitySpinBox'es in order to avoid segfault on focus change. 2020-12-17 23:01:55 -08:00
Markus Lampert
c1549ba3a8 Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences. 2020-12-17 22:56:42 -08:00
Markus Lampert
d136394376 Rearranged BitTool shape update so dependent ops don't execute with invalid tool. 2020-12-17 20:27:42 -08:00
Markus Lampert
a5e992f700 Make BitShape read/writeable, so the tool can be edited when shared to a different system 2020-12-17 19:59:44 -08:00
Markus Lampert
3da82fa6af Hide document when loading a ToolBit. 2020-12-17 19:55:59 -08:00
Markus Lampert
7049c09448 Only update the shape if it has changed. 2020-12-17 19:14:44 -08:00