kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
22,652 Commits 40 Branches 6 Tags
1e2fb1099a64d6c2bd407d7858d76399ab83b84f
Commit Graph

1671 Commits

Author SHA1 Message Date
sliptonic
1e2fb1099a add task panel for dragknife 2020-10-07 12:17:36 -05:00
sliptonic
dfb02201b7 Merge pull request #3915 from Russ4262/fix_Profile 
Path: Profile - Fix rotation error and remove FinalDepth limit
 2020-10-06 09:04:02 -05:00
sliptonic
611806b26d add coolant mode 
fix Z depth
 2020-10-05 18:00:47 -05:00
sliptonic
027de684cb Merge pull request #3901 from J-Dunn/master 
[Path] fix 3Dsurface with countersink tools
 2020-10-05 14:23:48 -05:00
Russell Johnson
5eb5434c6a Path: Fix rotational error for certain situations 
Error discovered during recent troubleshooting of Pocket_Shape with rotation.
Initial application of new operation yields path, but subsequent changes and applications failed due to `if ...` statement removed here for the fix.
 2020-10-03 13:56:46 -05:00
Russell Johnson
d2981fb09a Path: Remove FinalDepth limitation for internal profile operation 
Requested in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=50341
 2020-10-01 22:51:33 -05:00
Russell Johnson
4e6741a027 Path: Add debug feedback and comment 2020-10-01 22:49:48 -05:00
sliptonic
ebae99c9e0 whitespace 2020-09-29 14:03:37 -05:00
sliptonic
af1dacf57f rename OTHER 2020-09-28 14:58:09 -05:00
sliptonic
1492aa01b5 remove need for cuttingedgeheight 
Calculating from diameter and cuttingedgeangle
 2020-09-28 14:58:09 -05:00
sliptonic
d22bfecdad improve selection and avoid border case with ultra short segments 2020-09-28 14:58:09 -05:00
sliptonic
8758cfce9f Resolve UI issues 
taskpanel threshold value
add constants to PathVoronoi calls
check for tool properties
set correct z height coloring exterior lines
 2020-09-28 14:58:09 -05:00
sliptonic
b1e5b5a902 Path: Vcarve fixes 
formatting fixes
remove reference to old ToolType
 2020-09-28 14:58:09 -05:00
sliptonic
a1852d1106 Rewrite for boost voronoi 2020-09-28 14:58:09 -05:00
sliptonic
f63d0fadcb Path: Vcarve - Added threshold property to remove unwanted segments 
code cleanup & debug
 2020-09-28 14:58:09 -05:00
sliptonic
d9d4387b1d Path: vcarve add feed rate 2020-09-28 14:58:09 -05:00
sliptonic
5df1f176e6 path: vcarve requires engraver with proper angle 
vcarve calculates depth with MIC now
 2020-09-28 14:58:09 -05:00
sliptonic
0b7eec6b79 Path: increasing the discretize precision 2020-09-28 14:58:09 -05:00
sliptonic
c141f41887 Path: add vcarve operation using openvoronoi 2020-09-28 14:58:08 -05:00
J-Dunn
1830c14bb0 Add files via upload 
fix 3Dsurface bugs: variable name error and OCL using half tip angle. 
https://forum.freecadweb.org/viewtopic.php?f=15&t=50570
 2020-09-27 18:34:31 +01:00
sliptonic
2921a0c64b Merge pull request #3861 from Russ4262/profile_reset_fix 
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
 2020-09-15 14:12:01 -05:00
sliptonic
6ab2b2e088 Merge pull request #3862 from Russ4262/pocketshape_fix 
[Path] PocketShape - fix improper path generation
 2020-09-15 14:09:57 -05:00
sliptonic
a723fd7cbe Merge pull request #3849 from Schildkroet/deburr+dressup 
[Path] Fixed DeburrOp not moving to safe height
 2020-09-15 12:48:33 -05:00
vocx-fc
b0f6920b4e Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
Russell Johnson
fd3efcdbd7 [Path] PocketShape - fix improper path generation 
Forum identification and discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49513.
 2020-09-12 09:35:34 -05:00
Russell Johnson
47b27edd6d [Path] Fixes #4433 - Cut Side reset with certain Base Geometry changes 
`Cut Side` value was hard-coded to reset when Base Geometry was empty.  This disallowed retention of the current value with changes to selected Base Geometry involving the clearing thereof.
Also restored fixed visibility to `Cut Side` option in Task panel editor per forum mention.
 2020-09-12 00:24:25 -05:00
Patrick F
fb0ecda0e1 Fixed DeburrOp not moving to safe height 2020-09-07 01:30:32 +02:00
luz paz
5cd408687b Fix typos in various files [skip-ci] 
Found via `codespell 2.0.dev0`  
```
codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-09-04 10:10:31 +02:00
luz paz
4344f6bc08 Fix typos in source comments 
Found via `codespell`
 2020-08-29 19:14:13 +02:00
sliptonic
e813c5adfd Merge pull request #3763 from Russ4262/PocketShape_fix_t4411 
Path: PocketShape - Fixes ticket #4411
 2020-08-04 10:40:53 -05:00
sliptonic
5c67c40dbd Merge pull request #3751 from J-Dunn/master 
Path: prevent added paths creating tool crash: fixed #4260
 2020-08-04 10:40:13 -05:00
sliptonic
bfa8cbf8a6 Merge pull request #3706 from etrombly/emptyPath 
[PATH] don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same.
 2020-08-04 10:20:13 -05:00
Russell Johnson
c7d34929ad Path: Fix reference to undefined ns, and adjust comments 
This `ns` fix might need further attention after testing.  The section to which it pertains deals with optimizing rotations between ops with similar rotational axes.
 2020-08-02 13:27:32 -05:00
Russell Johnson
2528898cb5 Path: Fix the rotational LimitDepthToFace feature 2020-08-02 13:27:32 -05:00
Russell Johnson
986775ec1a Path: Fix InverseAngle feature 
The `ReverseDirection` property is now hidden by default.  It should not be necessary due to recent implementation of `isFaceUp()` method.
 2020-08-02 13:27:32 -05:00
Russell Johnson
0697686695 Path: PocketShape - Fixes ticket #4411 
Existing code to determine if shape volume indeed existed, failed.
Added additional pre-check for existing edges in shape to determine if shape geometry indeed exists.
In forum:
[Ticket #4411 - Can only generate pocket once for this shape, then it fails.](https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49035).
 2020-08-02 13:27:32 -05:00
sliptonic
4bfa602368 Merge pull request #3700 from etrombly/deletedFaces 
[Path] handle makeOffset2D exception in path pocket operation
 2020-07-28 11:50:27 -05:00
sliptonic
ed9c94d9b6 Merge pull request #3585 from gwicke/unified_region_experiments 
Path: Area based unified projection implementation
 2020-07-28 11:48:56 -05:00
J-Dunn
0c3006e77c prevent added paths creating tool crash #4260 #3028 
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
 2020-07-28 14:12:11 +01:00
sliptonic
c10275b439 Merge pull request #3689 from etrombly/edgesMatchShape 
[PATH] fix pocket attribute error if edge cannot be flipped
 2020-07-27 12:53:37 -05:00
Mark Ganson TheMarkster
0491fa4ab9 coverity issue cid 305102 2020-07-23 13:55:32 +02:00
Gabriel Wicke
5c6de6dd14 Path: Area based unified projection implementation 
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
 2020-07-21 18:34:09 -07:00
Eric Trombly
fa8f3c2461 fix two never ending while loops in PathSurfaceSupport 2020-07-17 13:59:10 -05:00
Eric Trombly
8ab962ad85 handle offset error in PathPocketShapeGui 2020-07-15 21:31:34 -05:00
Eric Trombly
66b941b5fa handle makeOffset2D exception 2020-07-15 21:31:34 -05:00
Eric Trombly
465de60007 don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same. 2020-07-15 19:35:18 -05:00
Eric Trombly
cf95a6ee91 fix attributeError if edge can't be flipped 2020-07-14 18:53:54 -05:00
sliptonic
be1abcb96b Merge pull request #3688 from etrombly/deleted 
[PATH] fix Cannot access attribute 'Document' of deleted object when cancelling PathPocket operation
 2020-07-12 16:27:35 -05:00
Eric Trombly
2e251ee967 cleaner fix 2020-07-10 15:42:00 -05:00
Eric Trombly
b4c2082b9e fix deleted object error 2020-07-10 15:42:00 -05:00