kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
28,737 Commits 41 Branches 6 Tags
1fbd1fb38d62ce06501e963e36eab264cece1bf6
Commit Graph

2240 Commits

Author SHA1 Message Date
Yorik van Havre
1fbd1fb38d Merged crowdin translations 2022-04-21 14:18:33 +02:00
wmayer
c5bab68332 Gui: add convenience functions to SelectionFilterGate 2022-04-19 15:04:14 +02:00
wmayer
94c5d89d1f Sketcher: fix crash after having created a new B-Spline 
The crash might be related to issue #6324: Segmentation fault on knot insertion in older B-Spline
 2022-04-17 17:33:11 +02:00
Yorik van Havre
914069ded4 merged crowdin translations 2022-04-13 13:47:06 +02:00
Ed Williams
daaf81e346 Replace Line with LineSegment 
It doesn't run with Line
 2022-04-08 10:45:19 +02:00
0penBrain
7a16a2fff1 Sketcher: restore constraint filter if Multiple dialog is canceled 2022-04-07 12:30:36 +02:00
Yorik van Havre
19feabd072 Merged crowdin translations 2022-03-31 11:41:28 +02:00
Chris Hennes
589369a2cc Sketcher: PR6497 move return statement to new line 2022-03-29 13:25:06 -05:00
Chris Hennes
2443eadda2 Sketcher: PR4556 Step 3: sort QGridLayout by row-col 2022-03-28 10:43:22 -05:00
Chris Hennes
b41bf46c9f Sketcher: PR4556 Step 2: remove native=true 2022-03-28 10:43:21 -05:00
wmayer
72cf783493 Sketcher: include header with export macros 2022-03-24 21:09:14 +01:00
wmayer
d21a60b294 All: modernize C++11 
* replace deprecated headers
 2022-03-23 22:44:18 +01:00
wmayer
51186c018e Sketcher: modernize C++11 
* use nullptr
 2022-03-23 19:26:15 +01:00
Yorik van Havre
1563822763 Translations: Merged crowdin strings 2022-03-23 10:37:50 +01:00
Uwe
38d7b77237 [Sketch] remove Python.h and Xerces 
seems not to be necessary anymore
 2022-03-21 02:51:57 +01:00
wmayer
1a62c2024d lgtm: removes unused imports in Python scripts 2022-03-20 23:00:55 +01:00
wmayer
585bcb8708 lgtm: [skip ci] FIXME comment 
Change FIXME or remove it
 2022-03-20 16:51:23 +01:00
wmayer
723cd53cd6 Sketcher: [skip ci] close directory in unit test 2022-03-19 13:54:59 +01:00
Abdullah Tahiri
14d682c6c3 Sketcher: Fix edit curve drawing for bounded curves 2022-03-15 13:16:48 +01:00
Abdullah Tahiri
1aab305577 Sketcher: DrawSketchHandler draw multiple edit curves 
=====================================================

Extension of the framework to draw an arbitrary curve in draw sketch handlers, so that
a plurality of curves can be handled.

DrawSketchHandler is extended to additionally offer drawing several curves:
- void drawEdit(const std::list<std::vector<Base::Vector2d>> &list);
- void drawEdit(const std::vector<Part::Geometry *> &geometries);

A new class, CurveConverter, enables to convert individual Part::Geometry or vectors of them
to appropriate vectors or list of vectors of Vector2d representing the curves. This can be
used in a specific DrawSketchHandler to combine Part::Geometries and arbritary curves.
 2022-03-14 16:02:49 +01:00
Yorik van Havre
a55ee61840 Merged crowdin translations 2022-03-14 12:21:01 +01:00
wmayer
0f9768fb33 Fix coverity issue: 
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
 2022-03-14 11:35:04 +01:00
Abdullah Tahiri
ee98a3d87f Sketcher: Some code comments 2022-03-13 19:28:38 +01:00
Abdullah Tahiri
23f18505f2 Sketcher: Redraw constraints on wheel event 
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
 2022-03-13 11:33:52 +01:00
Ajinkya Dahale
9007662425 [Sketcher] Fix "toggle internal geo" on multi-selection 
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
 2022-03-13 06:58:40 +01:00
Abdullah Tahiri
bba7c89c2a Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bcfa246943 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
341cf32369 Sketcher: Coverity 332685, 332686, 332696 
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c8a57fb9b4 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
963cae4a0b Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bd84e883cf Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix 
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
 2022-03-12 15:47:50 +01:00
Ajinkya Dahale
201ef90a89 [Sketcher] Constrain first pole when created 
By doing this, duplicate radius constraints are not made when deleting and
redefining second pole.
 2022-03-09 16:43:47 +01:00
Ajinkya Dahale
f10ccfc0fb [Sketcher] Safeguard against spurious pre-selection 
Preselection is sometimes not updated under some circumstances
1. when deleting an object through python;
2. before autoconstraint when deleting previous pole in bspline creation mode.

When the preselected curve is the deleted object, segfault/crash can happen.
 2022-03-09 16:43:47 +01:00
Ajinkya Dahale
3fa1735088 [Sketcher] Redraw correctly on pole delete in "create b-spline" 
This ensures that the last preview line drawn is always at the cursor and that
the coordinates are always w.r.t. the last defined pole.
 2022-03-09 16:43:47 +01:00
Uwe
4f5c29edd6 [Gui] Quarter: remove unused includes 2022-03-09 01:12:15 +01:00
wmayer
b02cb69baa Sketch: [skip ci] fix linking error with MSVC 
For more details see: https://forum.freecadweb.org/viewtopic.php?f=10&t=66939
 2022-03-09 01:11:15 +01:00
Uwe
554635cc7d [Gui] rename the Qt header list 2022-03-07 20:35:38 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Yorik van Havre
2cff977548 Merged crowdin translations 2022-03-07 14:55:22 +01:00
Ajinkya Dahale
5bfe90b2aa [Sketcher] Check for b-spline before starting knot insertion "mode" 
The DrawSketchHandler will otherwise give confusing error messages.
 2022-03-07 14:27:28 +01:00
Ajinkya Dahale
ec132dc2e4 [Sketcher] Remove "incomplete" from insert knot command 
I had kept the qualifier there when developing the tool and forgot to remove it. At this time the tool is fairly well-developed.
 2022-03-06 16:25:08 +01:00
Ajinkya Dahale
ec2522130b [Sketcher] Allow deleting last knot during B-Spline creation 2022-03-06 16:14:07 +01:00
Ajinkya Dahale
c6f19758d1 [Sketcher] Reduce duplicate code in DrawSketchHandlerBSpline 2022-03-06 16:14:07 +01:00
wmayer
5e0cfc64ee App: use forward declarations 2022-03-04 21:09:46 +01:00
wmayer
1cbecdf122 App: use forward declaration to reduce compile time 2022-03-04 17:27:53 +01:00
Abdullah Tahiri
79f52556f4 Sketcher: Clean up old crosshair code 
====================================

- Remove old unconnected code
- Move member functions to correct cpp file
 2022-03-04 06:26:46 +01:00
Abdullah Tahiri
8de93cfaf7 Sketcher: GeoElementId VAxis fix - windows 2022-03-02 15:00:40 +01:00
Abdullah Tahiri
5d0e40a2ca Sketcher: Fix GeoElementId VAxis 2022-03-02 07:54:24 +01:00