Commit Graph

41 Commits

Author SHA1 Message Date
Kacper Donat
d9d518f905 TechDraw: Use freecad_cast whenever possible 2025-04-26 14:23:25 +02:00
Benjamin Bræstrup Sayoc
bf1f99c070 TechDraw: hard type enums, part 3 (#19418)
* Remove magic number and hard type enums in LineNameEnum.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGIFace.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in Enums.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGVPage.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in TaskSurfaceFinishSymbols.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGTracker.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-24 11:58:05 -05:00
Ladislav Michl
0ee3c9f8e6 Base: Drop QString-std::string conversion functions from Tools
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
2024-12-02 23:30:53 -05:00
wandererfan
9a5597a5fa [TD]fix projection group detection (fix #16179) 2024-09-02 18:23:37 +02:00
WandererFan
b71c2a3278 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
Farley Runkel
31f5ca51da TechDraw: Refractor tracker action with proper enum 2024-04-22 18:21:49 +08:00
wandererfan
37f7ccfc86 [TD]fix duplicate unscale of CosmeticVertex 2024-01-06 08:43:25 -05:00
wandererfan
e6517089df [TD]fix location of CV on rotated views 2023-12-24 12:27:25 -05:00
wandererfan
a40033ef9a [TD]rotate CosmeticVertex with View 2023-08-19 17:18:42 -04:00
wmayer
25a63f8750 TD: move to new style connect() 2023-02-01 01:33:34 +01:00
Uwe
cbd0140dcd [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
bdf4cea14e [TD]refactor scene/view/mdi
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
2022-08-18 09:34:32 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
c4e4b5cf02 TD: Use new-style syntax of connect()
When fixing clazy issues -Wclazy-fully-qualified-moc-types then old-style syntax of connect() may fail. Thus, replace it with the new-style syntax
2022-07-26 16:10:45 +02:00
Uwe
31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
af18a97913 [TD] Gui: remove more superfluous nullptr checks 2022-07-19 03:40:32 +02:00
Benjamin Bræstrup Sayoc
43f6c17942 [TechDraw] Rename icon filenames for consistency 2022-07-09 14:38:30 -04:00
Wanderer Fan
9894964eb6 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Wanderer Fan
8349a78dde [TD]fix icon in dialog 2022-06-06 18:47:51 -04:00
Kuzemko Alexsandr
3f04bf7b4d [TD] Add text to translate
This will fix https://github.com/FreeCAD/FreeCAD-translations/issues/47
2022-06-01 13:04:47 +02:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
Uwe
2e7cb2c3fb [TD] remove a single-header file 2022-03-25 04:11:53 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
cb280afbc4 [TD]remove redundant edits from 9 Task dialogs 2022-01-22 14:51:20 -05:00
Uwe
4b0767dec1 [TD] some style unification
automatically done by MSVC
2022-01-03 23:30:43 +01:00
Benjamin Bræstrup Sayoc
c14af5f5fe Make it possible to do new Pick Points 2022-01-03 09:58:33 -05:00
Benjamin Bræstrup Sayoc
b09822c417 Use latest user input for Add Cosmetic Vertex 2022-01-03 09:58:33 -05:00
Tomas Pavlicek
4edf18a630 TechDraw - Undo for Cosmetics Vertices and Lines 2021-08-11 10:07:02 +02:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
b25dee58d5 Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wandererfan
1fc2e755dd [TD]Handle ProjGroup in TaskCosmeticVertex 2020-04-28 09:11:28 -04:00
donovaly
2cac4898d7 [TD] sanitize TaskCosVertex
- add missing unit (therefore switch to Gui::QuantitySpinBox)
- remove unused and confusing z-parameter
2020-03-28 20:54:54 -04:00
WandererFan
a92e157a9d [TD]sync icon names and menu entries
- contributed by @uwe
2020-02-03 07:20:52 -05:00
wandererfan
12db0b8df4 [TD]Fix Tracker stays active on Cancel 2019-09-07 07:32:24 -04:00
wandererfan
f655857196 [TD] fix context menu 2019-07-15 12:36:48 -04:00
wandererfan
5970e91ef2 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wmayer
4072b2c9d7 move includes to repsect PCH option 2019-05-25 13:04:57 +02:00
wandererfan
94b167f3a2 Add Midpoint and Quadrant Cosmetic Vertex 2019-05-24 19:38:02 -04:00
wandererfan
59e47de506 Initial version addCosmeticVertex 2019-05-24 19:38:02 -04:00