Commit Graph

75 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc
e025b1bfe2 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
wmayer
a54a7862f4 TD: Fix compiler warnings
This fixes the compiler warning: unused parameter 'mode' [-Wunused-parameter]

It's a regression of #16889 to not initialize the class member m_createMode any more that causes UB,
i.e. whenever m_createMode is accessed it may return an unexpected value.
2024-10-07 17:40:32 +02:00
wandererfan
98906c5edf [TD]fix handling of projection convention (fix #16788 #16785) 2024-09-28 10:39:30 -04:00
PaddleStroke
a9cdb09df9 TechDraw: ProjGroup Fix dim disappearing on upgrade. And also scale and scaleType properties not reappearing on downgrade. 2024-08-08 10:23:07 -04:00
wandererfan
efa9c46752 [TD]fix camera/front buttons on Proj Group dialog 2024-07-06 12:49:18 -04:00
wmayer
af7efce41c TD: Fix compiler warning
Warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
2024-04-25 10:46:24 +02:00
PaddleStroke
2b0403dc27 TechDraw: Insert tool insert DrawViewProjGroupItem that can then be transfered into groups and back. 2024-04-22 15:53:14 +02:00
PaddleStroke
5eb73cf949 TechDraw: Enable setting a custom direction. Fixes #5821 2024-04-22 15:53:14 +02:00
PaddleStroke
246496eed1 TechDraw: Add taskbox to Part View. Removes Projection Group from toolbar. 2024-04-22 15:53:14 +02:00
ppphp
8863b9ac4c fix: c++20 deprecate [=] 2024-03-31 10:47:32 +02:00
pavltom
2f04fce75e [TechDraw] Issue #5903 - Autofill template information 2024-03-23 08:56:47 -04:00
wandererfan
24876bec50 [TD]fix Projection Group front view position
- also fix checkbox correspondence with view position
2024-02-29 13:06:22 -05:00
wandererfan
1853dd8680 [TD]use correct tooltip in first/third angle 2024-02-21 11:46:18 -05:00
wandererfan
b8bea76481 [TD]spelling in comments 2023-11-26 16:42:06 -05:00
wmayer
25beef481c TD: move to new style connect() 2023-02-01 01:33:34 +01:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
993c5b1574 [TD] Task*, part 1: remove unused includes
- also some sorting
2022-12-07 16:15:40 +01:00
berniev
89ced8e8a7 QString.midRef is removed in Qt6 2022-12-01 12:17:49 +01:00
wandererfan
02008c8877 [TD]fix fail on missing base view (#7856) 2022-11-22 20:38:46 -05:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
e97b95341a [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
47ac049e14 Mod: use emplace_back 2022-08-05 10:36:16 +02:00
wmayer
c5910c1530 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
47b98c0684 [TechDraw] Improve readability of TaskProjGroup.cpp 2022-07-15 11:31:11 -04:00
Chris Hennes
84ae226ec6 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Benjamin Bræstrup Sayoc
7edfd902a3 Improve code simplicity/readability 2022-02-01 09:10:36 -05:00
luz paz
f1eb1ff44e [TD] Renamed ProjectionGroup, Hatch, GeomericHatch 2021-04-17 11:38:10 +02:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
9424395afc PVS: V1004 A pointer was used unsafely after it was verified against nullptr 2020-07-18 10:59:27 +02:00
donovaly
eb6a8e5339 [TD] add spacing to ProjGroup dialog
Add the setting to auto-distribute projections to the dialog
2020-06-21 08:22:49 -04:00
donovaly
97e1274b00 Merge branch 'master' of github.com:FreeCAD/FreeCAD into TD-DetailWork 2020-05-09 01:36:49 +02:00
wandererfan
8b7d9ee749 [TD]handle ProjectionAngle changes 2020-04-24 11:13:49 -04:00
donovaly
ec58acb7df [TD] some Detail View fixes
see https://forum.freecadweb.org/viewtopic.php?f=35&t=45236&p=388925#p388925 for a description of the changes
2020-04-18 14:56:01 +02:00
wmayer
e14e5b845e [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
donovaly
056ff6d1b6 TD renaming tools
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
251e16b6f1 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
Zheng, Lei
ecc857cdf1 TechDraw: fix projection group editing update 2019-08-17 15:32:51 +02:00
wandererfan
db3a69ba11 Remove superfluous updates
- under certain conditions, unnecessary screen paints
  were being performed.
2019-03-07 10:58:28 +01:00
wandererfan
cf738047d4 Fix double scaling in DPG AutoScale 2018-09-26 16:59:39 +02:00
wandererfan
f2c6edbb19 Fix late repaint of secondary views
- when ScaleType=Automatic and Scale changes
  individual views were not being repainted until
  next document recompute.
2018-09-26 16:59:12 +02:00
wandererfan
95f95d54fb Use Face or 3D direction for View and ProjGroup
- use current 3D window direction as starting
  direction for DrawViewPart and ProjectionGroup
- if a Face is selected, use Face normal as
  starting direction.
2018-09-06 08:00:00 +02:00
TeroK
442892ffa7 Fixed indentation 2018-01-07 18:39:47 -02:00
TeroK
c5e5958a6e Fixes #3294 TechDraw: Prevent scale changing
Now scale number changing controls are disabled by default and enabled only in
Custom Scale mode.

Previously user was all time allowed to edit scale numerical values.
But this had effect on the size of generated views in drawing page only
when scale type was set to Custom.
2018-01-07 18:39:47 -02:00
WandererFan
857aca5e8b Fix calculation of integer scale
- conversion of <double> scale to/from integer scale
  n:d was generating odd fractions and overflowing
  spinboxes in ui.
2017-11-12 19:08:33 -05:00